test suite reviews and discussions
 help / color / mirror / Atom feed
From: "zhu,shuai" <shuaix.zhu@intel.com>
To: dts@dpdk.org
Cc: yinan.wang@intel.com, "zhu,shuai" <shuaix.zhu@intel.com>
Subject: [dts] [PATCH V1 7/9] tests/vhost_virtio_pmd_interrupt:add create_eal_parameters function.
Date: Sat, 18 Jan 2020 16:38:10 +0800	[thread overview]
Message-ID: <1579336692-98775-7-git-send-email-shuaix.zhu@intel.com> (raw)
In-Reply-To: <1579336692-98775-1-git-send-email-shuaix.zhu@intel.com>

add create_eal_parameters function.

Signed-off-by: zhu,shuai <shuaix.zhu@intel.com>
---
 tests/TestSuite_vhost_virtio_pmd_interrupt.py | 16 ++++++----------
 1 file changed, 6 insertions(+), 10 deletions(-)

diff --git a/tests/TestSuite_vhost_virtio_pmd_interrupt.py b/tests/TestSuite_vhost_virtio_pmd_interrupt.py
index f35f9a1..6a76bb2 100644
--- a/tests/TestSuite_vhost_virtio_pmd_interrupt.py
+++ b/tests/TestSuite_vhost_virtio_pmd_interrupt.py
@@ -57,7 +57,7 @@ class TestVhostVirtioPmdInterrupt(TestCase):
         self.ports_socket = self.dut.get_numa_id(self.dut_ports[0])
         self.cores_num = len([n for n in self.dut.cores if int(n['socket']) ==
                         self.ports_socket])
-        self.mem_channels = self.dut.get_memory_channels()
+        self.pci_info = self.dut.ports_info[0]['pci']
         self.tx_port = self.tester.get_local_port(self.dut_ports[0])
         self.dst_mac = self.dut.get_mac_address(self.dut_ports[0])
         self.logger.info("Please comfirm the kernel of vm greater than 4.8.0 "
@@ -93,7 +93,6 @@ class TestVhostVirtioPmdInterrupt(TestCase):
                     self.running_case)
         self.core_list = self.dut.get_core_list(core_config,
                                     socket=self.ports_socket)
-        self.core_mask = utils.create_mask(self.core_list)
 
     def prepare_vm_env(self):
         """
@@ -117,14 +116,11 @@ class TestVhostVirtioPmdInterrupt(TestCase):
         """
         # get the core list depend on current nb_cores number
         self.get_core_list()
-
-        command_client = self.dut.target + "/app/testpmd -c %s -n %d " + \
-                        "--socket-mem 1024,1024 --legacy-mem " + \
-                        "--vdev 'net_vhost0,iface=%s/vhost-net,queues=%d' " + \
-                        "-- -i --nb-cores=%d --rxq=%d --txq=%d --rss-ip"
-        command_line_client = command_client % (
-                        self.core_mask, self.mem_channels, self.base_dir,
-                        self.queues, self.nb_cores, self.queues, self.queues)
+        testcmd = self.dut.target + "/app/testpmd "
+        vdev = [r"'net_vhost0,iface=%s/vhost-net,queues=%d'" % (self.base_dir, self.queues)]
+        eal_params = self.dut.create_eal_parameters(cores=self.core_list, ports=[self.pci_info], vdevs=vdev)
+        para = " -- -i --nb-cores=%d --rxq=%d --txq=%d --rss-ip" % (self.nb_cores, self.queues, self.queues)
+        command_line_client = testcmd + eal_params + para
         self.vhost_user.send_expect(command_line_client, "testpmd> ", 120)
         self.vhost_user.send_expect("start", "testpmd> ", 120)
 
-- 
2.17.2


  parent reply	other threads:[~2020-01-18  8:32 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-01-18  8:38 [dts] [PATCH V1 1/9] tests/vhost_1024_ethports:add " zhu,shuai
2020-01-18  8:38 ` [dts] [PATCH V1 2/9] tests/vhost_enqueue_interrupt:add " zhu,shuai
2020-01-18  8:38 ` [dts] [PATCH V1 3/9] tests/vhost_event_idx_interrupt:add " zhu,shuai
2020-01-18  8:38 ` [dts] [PATCH V1 4/9] tests/vhost_multi_queue_qemu:add " zhu,shuai
2020-01-18  8:38 ` [dts] [PATCH V1 5/9] tests/vhost_pmd_xstats:add " zhu,shuai
2020-01-18  8:38 ` [dts] [PATCH V1 6/9] tests/vhost_virtio_user_interrupt:add " zhu,shuai
2020-01-18  8:38 ` zhu,shuai [this message]
2020-01-18  8:38 ` [dts] [PATCH V1 8/9] tests/vhost_user_live_migration:add " zhu,shuai
2020-01-18  8:38 ` [dts] [PATCH V1 9/9] tests/vhost_dequeue_zero_copy:add " zhu,shuai
2020-01-19  8:35 ` [dts] [PATCH V1 1/9] tests/vhost_1024_ethports:add " Tu, Lijuan

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1579336692-98775-7-git-send-email-shuaix.zhu@intel.com \
    --to=shuaix.zhu@intel.com \
    --cc=dts@dpdk.org \
    --cc=yinan.wang@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).