[dts] [PATCH V1] tests/unit_tests_ringpmd:Fix variable name and string concatenation error

test suite reviews and discussions
 help / color / mirror / Atom feed

* [dts] [PATCH V1] tests/unit_tests_ringpmd:Fix variable name and string concatenation error
@ 2020-01-22  9:05 Zhou,JunX W
  2020-01-22  9:31 ` Zeng, XiaoxiaoX
  0 siblings, 1 reply; 2+ messages in thread
From: Zhou,JunX W @ 2020-01-22  9:05 UTC (permalink / raw)
  To: dts; +Cc: Zhou,JunX W

dev_strt2 is not define,dev_str2 is right;
There should be only two '%' in 'self.dut.send_expect("./%s/app/test %s %s"'

Signed-off-by: Zhou,JunX W <junx.w.zhou@intel.com>
---
 tests/TestSuite_unit_tests_ringpmd.py | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/tests/TestSuite_unit_tests_ringpmd.py b/tests/TestSuite_unit_tests_ringpmd.py
index 49895a1..19abb6e 100644
--- a/tests/TestSuite_unit_tests_ringpmd.py
+++ b/tests/TestSuite_unit_tests_ringpmd.py
@@ -80,8 +80,8 @@ class TestUnitTestsRingPmd(TestCase):
         self.dut.send_expect("quit", "# ")
         self.verify("Test OK" in out, "Default no eth_ring devices Test failed")
 
-        eal_params = self.dut.create_eal_parameters(cores=self.cores,vdevs=[dev_str1,dev_strt2])
-        self.dut.send_expect("./%s/app/test %s %s" % (self.target, eal_params), "R.*T.*E.*>.*>", 10)
+        eal_params = self.dut.create_eal_parameters(cores=self.cores,vdevs=[dev_str1,dev_str2])
+        self.dut.send_expect("./%s/app/test %s" % (self.target, eal_params), "R.*T.*E.*>.*>", 10)
         out = self.dut.send_expect("ring_pmd_autotest", "RTE>>", 120)
         self.dut.send_expect("quit", "# ")
         self.verify("Test OK" in out, "Two eth_ring devices test failed")
-- 
2.17.2


^ permalink raw reply	[flat|nested] 2+ messages in thread

* Re: [dts] [PATCH V1] tests/unit_tests_ringpmd:Fix variable name and string concatenation error
  2020-01-22  9:05 [dts] [PATCH V1] tests/unit_tests_ringpmd:Fix variable name and string concatenation error Zhou,JunX W
@ 2020-01-22  9:31 ` Zeng, XiaoxiaoX
  0 siblings, 0 replies; 2+ messages in thread
From: Zeng, XiaoxiaoX @ 2020-01-22  9:31 UTC (permalink / raw)
  To: Zhou, JunX W, dts; +Cc: Zhou, JunX W

[-- Attachment #1: Type: text/plain, Size: 1736 bytes --]


Tested_by: Zeng,XiaoxiaoX<xiaoxiaox.zeng@intel.com>


> -----Original Message-----
> From: dts [mailto:dts-bounces@dpdk.org] On Behalf Of Zhou,JunX W
> Sent: Wednesday, January 22, 2020 5:06 PM
> To: dts@dpdk.org
> Cc: Zhou, JunX W <junx.w.zhou@intel.com>
> Subject: [dts] [PATCH V1] tests/unit_tests_ringpmd:Fix variable name and
> string concatenation error
> 
> dev_strt2 is not define,dev_str2 is right; There should be only two '%' in
> 'self.dut.send_expect("./%s/app/test %s %s"'
> 
> Signed-off-by: Zhou,JunX W <junx.w.zhou@intel.com>
> ---
>  tests/TestSuite_unit_tests_ringpmd.py | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/tests/TestSuite_unit_tests_ringpmd.py
> b/tests/TestSuite_unit_tests_ringpmd.py
> index 49895a1..19abb6e 100644
> --- a/tests/TestSuite_unit_tests_ringpmd.py
> +++ b/tests/TestSuite_unit_tests_ringpmd.py
> @@ -80,8 +80,8 @@ class TestUnitTestsRingPmd(TestCase):
>          self.dut.send_expect("quit", "# ")
>          self.verify("Test OK" in out, "Default no eth_ring devices Test failed")
> 
> -        eal_params =
> self.dut.create_eal_parameters(cores=self.cores,vdevs=[dev_str1,dev_strt2
> ])
> -        self.dut.send_expect("./%s/app/test %s %s" % (self.target,
> eal_params), "R.*T.*E.*>.*>", 10)
> +        eal_params =
> self.dut.create_eal_parameters(cores=self.cores,vdevs=[dev_str1,dev_str2])
> +        self.dut.send_expect("./%s/app/test %s" % (self.target,
> + eal_params), "R.*T.*E.*>.*>", 10)
>          out = self.dut.send_expect("ring_pmd_autotest", "RTE>>", 120)
>          self.dut.send_expect("quit", "# ")
>          self.verify("Test OK" in out, "Two eth_ring devices test failed")
> --
> 2.17.2


[-- Attachment #2: TestUnitTestsRingPmd.log --]
[-- Type: application/octet-stream, Size: 7556 bytes --]

22/01/2020 08:47:28                            dts: 
TEST SUITE : TestUnitTestsRingPmd
22/01/2020 08:47:28                            dts: NIC :        niantic
22/01/2020 08:47:28             dut.10.240.176.144: 
22/01/2020 08:47:28                         tester: 
22/01/2020 08:47:28           TestUnitTestsRingPmd: Test Case test_ring_pmd Begin
22/01/2020 08:47:28             dut.10.240.176.144: 
22/01/2020 08:47:28                         tester: 
22/01/2020 08:47:28             dut.10.240.176.144: ./x86_64-native-linuxapp-gcc/app/test -l 1,2,3,4,5,6,7,8,9,10,11 -n 4   --file-prefix=dpdk_23589_20200122084101  
22/01/2020 08:47:29             dut.10.240.176.144: EAL: Detected 12 lcore(s)
EAL: Detected 1 NUMA nodes
EAL: Multi-process socket /var/run/dpdk/dpdk_23589_20200122084101/mp_socket
EAL: Selected IOVA mode 'PA'
EAL: 1024 hugepages of size 2097152 reserved, but no mounted hugetlbfs found for that size
EAL: Probing VFIO support...
EAL: PCI device 0000:02:00.0 on NUMA socket -1
EAL:   Invalid NUMA socket, default to 0
EAL:   probe driver: 8086:10fb net_ixgbe
EAL: PCI device 0000:02:00.1 on NUMA socket -1
EAL:   Invalid NUMA socket, default to 0
EAL:   probe driver: 8086:10fb net_ixgbe
EAL: PCI device 0000:04:00.0 on NUMA socket -1
EAL:   Invalid NUMA socket, default to 0
EAL:   probe driver: 8086:1521 net_e1000_igb
EAL: PCI device 0000:04:00.1 on NUMA socket -1
EAL:   Invalid NUMA socket, default to 0
EAL:   probe driver: 8086:1521 net_e1000_igb
EAL: PCI device 0000:04:00.2 on NUMA socket -1
EAL:   Invalid NUMA socket, default to 0
EAL:   probe driver: 8086:1521 net_e1000_igb
EAL: PCI device 0000:04:00.3 on NUMA socket -1
EAL:   Invalid NUMA socket, default to 0
EAL:   probe driver: 8086:1521 net_e1000_igb
EAL: PCI device 0000:07:00.0 on NUMA socket -1
EAL:   Invalid NUMA socket, default to 0
EAL:   probe driver: 8086:15c8 net_ixgbe
EAL: PCI device 0000:07:00.1 on NUMA socket -1
EAL:   Invalid NUMA socket, default to 0
EAL:   probe driver: 8086:15c8 net_ixgbe
EAL: PCI device 0000:08:00.0 on NUMA socket -1
EAL:   Invalid NUMA socket, default to 0
EAL:   probe driver: 8086:15ce net_ixgbe
EAL: PCI device 0000:08:00.1 on NUMA socket -1
EAL:   Invalid NUMA socket, default to 0
EAL:   probe driver: 8086:15ce net_ixgbe
APP: HPET is not enabled, using TSC as default timer
22/01/2020 08:47:29             dut.10.240.176.144: ring_pmd_autotest
22/01/2020 08:47:29             dut.10.240.176.144: ring_pmd_autotest
 + ------------------------------------------------------- +
 + Test Suite : Test Pmd Ring Unit Test Suite
nb_ports=2
tx_porta=2 rx_portb=3 rxtx_portc=4 rxtx_portd=5 rxtx_porte=6
 + ------------------------------------------------------- +
 + TestCase [ 0] : test_ethdev_configure_ports succeeded
Testing send and receive RING_SIZE/2 packets (tx_porta -> rx_portb)
 + TestCase [ 1] : test_send_basic_packets succeeded
Testing ring PMD stats_get port 4
 + TestCase [ 2] : test_get_stats_for_port succeeded
Testing ring PMD stats_reset port 4
 + TestCase [ 3] : test_stats_reset_for_port succeeded
Testing send and receive 1 packet (rxtx_portd -> rxtx_porte)
Testing send and receive 1 packet (rxtx_porte -> rxtx_portd)
Testing send and receive 1 packet (rxtx_portd -> rxtx_portd)
Testing send and receive 1 packet (rxtx_porte -> rxtx_porte)
 + TestCase [ 4] : test_pmd_ring_pair_create_attach succeeded
 + TestCase [ 5] : test_command_line_ring_port succeeded
 + ------------------------------------------------------- +
 + Test Suite Summary 
 + Tests Total :        6
 + Tests Skipped :      0
 + Tests Executed :     6
 + Tests Unsupported:   0
 + Tests Passed :       6
 + Tests Failed :       0
 + ------------------------------------------------------- +
Test OK
22/01/2020 08:47:29             dut.10.240.176.144: quit
22/01/2020 08:47:30             dut.10.240.176.144: quit
22/01/2020 08:47:30             dut.10.240.176.144: ./x86_64-native-linuxapp-gcc/app/test -l 1,2,3,4,5,6,7,8,9,10,11 -n 4   --file-prefix=dpdk_23589_20200122084101  --vdev net_ring0 --vdev net_ring1
22/01/2020 08:47:30             dut.10.240.176.144: EAL: Detected 12 lcore(s)
EAL: Detected 1 NUMA nodes
EAL: Multi-process socket /var/run/dpdk/dpdk_23589_20200122084101/mp_socket
EAL: Selected IOVA mode 'PA'
EAL: 1024 hugepages of size 2097152 reserved, but no mounted hugetlbfs found for that size
EAL: Probing VFIO support...
EAL: PCI device 0000:02:00.0 on NUMA socket -1
EAL:   Invalid NUMA socket, default to 0
EAL:   probe driver: 8086:10fb net_ixgbe
EAL: PCI device 0000:02:00.1 on NUMA socket -1
EAL:   Invalid NUMA socket, default to 0
EAL:   probe driver: 8086:10fb net_ixgbe
EAL: PCI device 0000:04:00.0 on NUMA socket -1
EAL:   Invalid NUMA socket, default to 0
EAL:   probe driver: 8086:1521 net_e1000_igb
EAL: PCI device 0000:04:00.1 on NUMA socket -1
EAL:   Invalid NUMA socket, default to 0
EAL:   probe driver: 8086:1521 net_e1000_igb
EAL: PCI device 0000:04:00.2 on NUMA socket -1
EAL:   Invalid NUMA socket, default to 0
EAL:   probe driver: 8086:1521 net_e1000_igb
EAL: PCI device 0000:04:00.3 on NUMA socket -1
EAL:   Invalid NUMA socket, default to 0
EAL:   probe driver: 8086:1521 net_e1000_igb
EAL: PCI device 0000:07:00.0 on NUMA socket -1
EAL:   Invalid NUMA socket, default to 0
EAL:   probe driver: 8086:15c8 net_ixgbe
EAL: PCI device 0000:07:00.1 on NUMA socket -1
EAL:   Invalid NUMA socket, default to 0
EAL:   probe driver: 8086:15c8 net_ixgbe
EAL: PCI device 0000:08:00.0 on NUMA socket -1
EAL:   Invalid NUMA socket, default to 0
EAL:   probe driver: 8086:15ce net_ixgbe
EAL: PCI device 0000:08:00.1 on NUMA socket -1
EAL:   Invalid NUMA socket, default to 0
EAL:   probe driver: 8086:15ce net_ixgbe
APP: HPET is not enabled, using TSC as default timer
22/01/2020 08:47:30             dut.10.240.176.144: ring_pmd_autotest
22/01/2020 08:47:30             dut.10.240.176.144: ring_pmd_autotest
 + ------------------------------------------------------- +
 + Test Suite : Test Pmd Ring Unit Test Suite
nb_ports=4
tx_porta=4 rx_portb=5 rxtx_portc=6 rxtx_portd=7 rxtx_porte=8
 + ------------------------------------------------------- +
 + TestCase [ 0] : test_ethdev_configure_ports succeeded
Testing send and receive RING_SIZE/2 packets (tx_porta -> rx_portb)
 + TestCase [ 1] : test_send_basic_packets succeeded
Testing ring PMD stats_get port 6
 + TestCase [ 2] : test_get_stats_for_port succeeded
Testing ring PMD stats_reset port 6
 + TestCase [ 3] : test_stats_reset_for_port succeeded
Testing send and receive 1 packet (rxtx_portd -> rxtx_porte)
Testing send and receive 1 packet (rxtx_porte -> rxtx_portd)
Testing send and receive 1 packet (rxtx_portd -> rxtx_portd)
Testing send and receive 1 packet (rxtx_porte -> rxtx_porte)
 + TestCase [ 4] : test_pmd_ring_pair_create_attach succeeded
 + TestCase [ 5] : test_command_line_ring_port succeeded
 + ------------------------------------------------------- +
 + Test Suite Summary 
 + Tests Total :        6
 + Tests Skipped :      0
 + Tests Executed :     6
 + Tests Unsupported:   0
 + Tests Passed :       6
 + Tests Failed :       0
 + ------------------------------------------------------- +
Test OK
22/01/2020 08:47:30             dut.10.240.176.144: quit
22/01/2020 08:47:31             dut.10.240.176.144: quit
22/01/2020 08:47:31           TestUnitTestsRingPmd: Test Case test_ring_pmd Result PASSED:
22/01/2020 08:47:31                            dts: 
TEST SUITE ENDED: TestUnitTestsRingPmd

^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2020-01-22  9:31 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-01-22  9:05 [dts] [PATCH V1] tests/unit_tests_ringpmd:Fix variable name and string concatenation error Zhou,JunX W
2020-01-22  9:31 ` Zeng, XiaoxiaoX

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).