test suite reviews and discussions
 help / color / mirror / Atom feed
From: "zhu,shuai" <shuaix.zhu@intel.com>
To: dts@dpdk.org
Cc: "zhu,shuai" <shuaix.zhu@intel.com>
Subject: [dts] [PATCH V2] tests/virtio_pvp_regression:add create_eal_parameters function.
Date: Fri, 28 Feb 2020 09:32:36 +0800	[thread overview]
Message-ID: <1582853558-66855-4-git-send-email-shuaix.zhu@intel.com> (raw)
In-Reply-To: <1582853558-66855-1-git-send-email-shuaix.zhu@intel.com>



Signed-off-by: zhu,shuai <shuaix.zhu@intel.com>
---
 tests/TestSuite_virtio_pvp_regression.py | 17 ++++++-----------
 1 file changed, 6 insertions(+), 11 deletions(-)

diff --git a/tests/TestSuite_virtio_pvp_regression.py b/tests/TestSuite_virtio_pvp_regression.py
index e03048e..97e522c 100644
--- a/tests/TestSuite_virtio_pvp_regression.py
+++ b/tests/TestSuite_virtio_pvp_regression.py
@@ -57,14 +57,13 @@ class TestVirtioPVPRegression(TestCase):
         self.pf = self.dut_ports[0]
         # Get the port's socket
         netdev = self.dut.ports_info[self.pf]['port']
+        self.pci_info = self.dut.ports_info[self.pf]['pci']
         self.socket = netdev.get_nic_socket()
         self.cores = self.dut.get_core_list("1S/3C/1T", socket=self.socket)
 
         self.verify(len(self.dut_ports) >= 1, "Insufficient ports for testing")
         self.verify(len(self.cores) >= 3,
                     "There has not enought cores to test this suite")
-        self.coremask = utils.create_mask(self.cores)
-        self.memory_channel = self.dut.get_memory_channels()
         self.port_number = 2
         self.queues_number = 2
         self.dst_mac = self.dut.get_mac_address(self.dut_ports[0])
@@ -248,15 +247,11 @@ class TestVirtioPVPRegression(TestCase):
         """
         Launch the vhost testpmd
         """
-        command_line_client = self.dut.target + "/app/testpmd -n %d -c %s \
-            --socket-mem %s --file-prefix=vhost -w %s \
-            --vdev 'eth_vhost0,iface=%s/vhost-net,queues=%d,client=1' -- \
-            -i --nb-cores=%d --rxq=%d --txq=%d  --txd=1024 --rxd=1024"
-        command_line_client = command_line_client % (
-                        self.memory_channel, self.coremask, self.socket_mem,
-                        self.dut.ports_info[self.pf]['pci'], self.base_dir,
-                        self.queues_number, self.queues_number, self.queues_number,
-                        self.queues_number)
+        testcmd = self.dut.target + "/app/testpmd "
+        vdev = [r"'eth_vhost0,iface=%s/vhost-net,queues=%d,client=1'" % (self.base_dir, self.queues_number)]
+        eal_params = self.dut.create_eal_parameters(cores=self.cores, prefix='vhost', ports=[self.pci_info], vdevs=vdev)
+        para = " -- -i --nb-cores=%d --rxq=%d --txq=%d  --txd=1024 --rxd=1024" % (self.queues_number, self.queues_number, self.queues_number)
+        command_line_client = testcmd + eal_params + para
         self.vhost.send_expect(command_line_client, "testpmd> ", 30)
         self.vhost.send_expect("set fwd mac", "testpmd> ", 30)
         self.vhost.send_expect("start", "testpmd> ", 30)
-- 
2.17.2


  parent reply	other threads:[~2020-02-28  1:27 UTC|newest]

Thread overview: 17+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-02-28  1:32 [dts] [PATCH V2] tests/pvp_diff_qemu_version:add " zhu,shuai
2020-02-28  1:30 ` Zhu, ShuaiX
2020-02-28  1:32 ` [dts] [PATCH V2] tests/pvp_qemu_multi_paths_port_restart:add " zhu,shuai
2020-02-28  1:32   ` Zhu, ShuaiX
2020-03-03  7:24   ` Tu, Lijuan
2020-02-28  1:32 ` [dts] [PATCH V2] tests/pvp_virtio_user_2M_hugepages:add " zhu,shuai
2020-02-28  1:32   ` Zhu, ShuaiX
2020-03-03  7:24   ` Tu, Lijuan
2020-02-28  1:32 ` zhu,shuai [this message]
2020-02-28  1:31   ` [dts] [PATCH V2] tests/virtio_pvp_regression:add " Zhu, ShuaiX
2020-03-03  7:24   ` Tu, Lijuan
2020-02-28  1:32 ` [dts] [PATCH V2] tests/virtio_user_as_exceptional_path:add " zhu,shuai
2020-02-28  1:34   ` Zhu, ShuaiX
2020-03-03  7:24   ` Tu, Lijuan
2020-02-28  1:32 ` [dts] [PATCH V2] tests/vm2vm_virtio_pmd:add " zhu,shuai
2020-02-28  1:35   ` Zhu, ShuaiX
2020-03-03  7:24   ` Tu, Lijuan

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1582853558-66855-4-git-send-email-shuaix.zhu@intel.com \
    --to=shuaix.zhu@intel.com \
    --cc=dts@dpdk.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).