test suite reviews and discussions
 help / color / mirror / Atom feed
* [dts] [PATCH V1]tests/TestSuite_virtio_event_idx_interrupt: fix eal parameter error
@ 2020-03-07  4:22 Xiao Qimai
  2020-03-07  4:33 ` Xiao, QimaiX
  2020-03-13  6:32 ` Tu, Lijuan
  0 siblings, 2 replies; 3+ messages in thread
From: Xiao Qimai @ 2020-03-07  4:22 UTC (permalink / raw)
  To: dts; +Cc: Xiao Qimai

*. fix eal parameter error

Signed-off-by: Xiao Qimai <qimaix.xiao@intel.com>
---
 tests/TestSuite_virtio_event_idx_interrupt.py | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/tests/TestSuite_virtio_event_idx_interrupt.py b/tests/TestSuite_virtio_event_idx_interrupt.py
index 1fb0622..08ad676 100644
--- a/tests/TestSuite_virtio_event_idx_interrupt.py
+++ b/tests/TestSuite_virtio_event_idx_interrupt.py
@@ -93,9 +93,9 @@ class TestVirtioIdxInterrupt(TestCase):
         # get the core mask depend on the nb_cores number
         self.get_core_mask()
         testcmd = self.dut.target + "/app/testpmd "
-        vdev = [r"--vdev 'net_vhost,iface=%s/vhost-net,queues=%d' -- -i " % (self.base_dir, self.queues)]
+        vdev = ['net_vhost,iface=%s/vhost-net,queues=%d ' % (self.base_dir, self.queues)]
         eal_params = self.dut.create_eal_parameters(cores=self.core_list, prefix='vhost', ports=[self.pf_pci], vdevs=vdev)
-        para = " --nb-cores=%d --txd=1024 --rxd=1024 --rxq=%d --txq=%d" % (self.nb_cores, self.queues, self.queues)
+        para = " -- -i --nb-cores=%d --txd=1024 --rxd=1024 --rxq=%d --txq=%d" % (self.nb_cores, self.queues, self.queues)
         command_line = testcmd + eal_params + para
         self.vhost.send_expect(command_line, "testpmd> ", 30)
         self.vhost.send_expect("start", "testpmd> ", 30)
-- 
1.8.3.1


^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: [dts] [PATCH V1]tests/TestSuite_virtio_event_idx_interrupt: fix eal parameter error
  2020-03-07  4:22 [dts] [PATCH V1]tests/TestSuite_virtio_event_idx_interrupt: fix eal parameter error Xiao Qimai
@ 2020-03-07  4:33 ` Xiao, QimaiX
  2020-03-13  6:32 ` Tu, Lijuan
  1 sibling, 0 replies; 3+ messages in thread
From: Xiao, QimaiX @ 2020-03-07  4:33 UTC (permalink / raw)
  To: dts

Tested-by: Xiao, QimaiX <qimaix.xiao@intel.com>

-----Original Message-----
From: Xiao, QimaiX <qimaix.xiao@intel.com> 
Sent: Saturday, March 7, 2020 12:23 PM
To: dts@dpdk.org
Cc: Xiao, QimaiX <qimaix.xiao@intel.com>
Subject: [dts][PATCH V1]tests/TestSuite_virtio_event_idx_interrupt: fix eal parameter error

*. fix eal parameter error

Signed-off-by: Xiao Qimai <qimaix.xiao@intel.com>
---
 tests/TestSuite_virtio_event_idx_interrupt.py | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/tests/TestSuite_virtio_event_idx_interrupt.py b/tests/TestSuite_virtio_event_idx_interrupt.py
index 1fb0622..08ad676 100644
--- a/tests/TestSuite_virtio_event_idx_interrupt.py
+++ b/tests/TestSuite_virtio_event_idx_interrupt.py
@@ -93,9 +93,9 @@ class TestVirtioIdxInterrupt(TestCase):
         # get the core mask depend on the nb_cores number
         self.get_core_mask()
         testcmd = self.dut.target + "/app/testpmd "
-        vdev = [r"--vdev 'net_vhost,iface=%s/vhost-net,queues=%d' -- -i " % (self.base_dir, self.queues)]
+        vdev = ['net_vhost,iface=%s/vhost-net,queues=%d ' % (self.base_dir, self.queues)]
         eal_params = self.dut.create_eal_parameters(cores=self.core_list, prefix='vhost', ports=[self.pf_pci], vdevs=vdev)
-        para = " --nb-cores=%d --txd=1024 --rxd=1024 --rxq=%d --txq=%d" % (self.nb_cores, self.queues, self.queues)
+        para = " -- -i --nb-cores=%d --txd=1024 --rxd=1024 --rxq=%d --txq=%d" % (self.nb_cores, self.queues, self.queues)
         command_line = testcmd + eal_params + para
         self.vhost.send_expect(command_line, "testpmd> ", 30)
         self.vhost.send_expect("start", "testpmd> ", 30)
-- 
1.8.3.1


^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: [dts] [PATCH V1]tests/TestSuite_virtio_event_idx_interrupt: fix eal parameter error
  2020-03-07  4:22 [dts] [PATCH V1]tests/TestSuite_virtio_event_idx_interrupt: fix eal parameter error Xiao Qimai
  2020-03-07  4:33 ` Xiao, QimaiX
@ 2020-03-13  6:32 ` Tu, Lijuan
  1 sibling, 0 replies; 3+ messages in thread
From: Tu, Lijuan @ 2020-03-13  6:32 UTC (permalink / raw)
  To: Xiao, QimaiX, dts; +Cc: Xiao, QimaiX

Applied thanks

> -----Original Message-----
> From: dts [mailto:dts-bounces@dpdk.org] On Behalf Of Xiao Qimai
> Sent: Saturday, March 7, 2020 12:23 PM
> To: dts@dpdk.org
> Cc: Xiao, QimaiX <qimaix.xiao@intel.com>
> Subject: [dts] [PATCH V1]tests/TestSuite_virtio_event_idx_interrupt: fix eal
> parameter error
> 
> *. fix eal parameter error
> 
> Signed-off-by: Xiao Qimai <qimaix.xiao@intel.com>
> ---
>  tests/TestSuite_virtio_event_idx_interrupt.py | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/tests/TestSuite_virtio_event_idx_interrupt.py
> b/tests/TestSuite_virtio_event_idx_interrupt.py
> index 1fb0622..08ad676 100644
> --- a/tests/TestSuite_virtio_event_idx_interrupt.py
> +++ b/tests/TestSuite_virtio_event_idx_interrupt.py
> @@ -93,9 +93,9 @@ class TestVirtioIdxInterrupt(TestCase):
>          # get the core mask depend on the nb_cores number
>          self.get_core_mask()
>          testcmd = self.dut.target + "/app/testpmd "
> -        vdev = [r"--vdev 'net_vhost,iface=%s/vhost-net,queues=%d' -- -i " %
> (self.base_dir, self.queues)]
> +        vdev = ['net_vhost,iface=%s/vhost-net,queues=%d ' % (self.base_dir,
> self.queues)]
>          eal_params = self.dut.create_eal_parameters(cores=self.core_list,
> prefix='vhost', ports=[self.pf_pci], vdevs=vdev)
> -        para = " --nb-cores=%d --txd=1024 --rxd=1024 --rxq=%d --txq=%d" %
> (self.nb_cores, self.queues, self.queues)
> +        para = " -- -i --nb-cores=%d --txd=1024 --rxd=1024 --rxq=%d --txq=%d" %
> (self.nb_cores, self.queues, self.queues)
>          command_line = testcmd + eal_params + para
>          self.vhost.send_expect(command_line, "testpmd> ", 30)
>          self.vhost.send_expect("start", "testpmd> ", 30)
> --
> 1.8.3.1


^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, other threads:[~2020-03-13  6:32 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-03-07  4:22 [dts] [PATCH V1]tests/TestSuite_virtio_event_idx_interrupt: fix eal parameter error Xiao Qimai
2020-03-07  4:33 ` Xiao, QimaiX
2020-03-13  6:32 ` Tu, Lijuan

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).