From: Xiao Qimai <qimaix.xiao@intel.com>
To: dts@dpdk.org
Cc: Xiao Qimai <qimaix.xiao@intel.com>
Subject: [dts] [PATCH V1]link_status_interrupt: setup link-down-on-close on tester for this suite
Date: Fri, 17 Apr 2020 10:20:33 +0800 [thread overview]
Message-ID: <1587090033-272429-1-git-send-email-qimaix.xiao@intel.com> (raw)
*. set up link-down-on-close on tester side to support this suite
Signed-off-by: Xiao Qimai <qimaix.xiao@intel.com>
---
tests/TestSuite_link_status_interrupt.py | 20 ++++++++++++++++++--
1 file changed, 18 insertions(+), 2 deletions(-)
diff --git a/tests/TestSuite_link_status_interrupt.py b/tests/TestSuite_link_status_interrupt.py
index 3208d71..097bb8e 100644
--- a/tests/TestSuite_link_status_interrupt.py
+++ b/tests/TestSuite_link_status_interrupt.py
@@ -70,6 +70,22 @@ class TestLinkStatusInterrupt(TestCase):
self.basic_intr_mode = ["msix", "legacy"]
if self.drivername == "vfio-pci":
self.basic_intr_mode.append("msi")
+ self.intfs = [self.tester.get_interface(self.tester.get_local_port(i)) for i in self.dut_ports]
+ # check link-down-on-close flag
+ self.flag = "link-down-on-close"
+ for intf in self.intfs:
+ check_flag = "ethtool --show-priv-flags %s" % intf
+ set_flag = "ethtool --set-priv-flags %s %s on" % (intf, self.flag)
+ out = self.tester.send_expect(check_flag, "#")
+ p = re.compile('%s\s+:\s+(\w+)' % self.flag)
+ res = re.search(p, out).group(1)
+ if res == "off":
+ self.tester.send_expect(set_flag, "#")
+ time.sleep(0.5)
+ out = self.tester.send_expect(check_flag, "#")
+ self.verify(re.search(p, out).group(1) == "on", "set %s %s on failed" % (intf, self.flag))
+ elif not res:
+ self.logger.info("NIC %s might not support this case" % intf)
def set_link_status_and_verify(self, dutPort, status):
"""
@@ -93,7 +109,6 @@ class TestLinkStatusInterrupt(TestCase):
"""
Verify Link status change
"""
-
if self.drivername == "igb_uio":
cmdline = self.path + " -c %s -n %s -- -p %s " % (
self.coremask, self.dut.get_memory_channels(), self.portmask)
@@ -191,4 +206,5 @@ class TestLinkStatusInterrupt(TestCase):
"""
Run after each test suite.
"""
- pass
+ for i in self.intfs:
+ self.tester.send_expect("ethtool --set-priv-flags %s %s off" % (i, self.flag), "#")
--
1.8.3.1
next reply other threads:[~2020-04-17 2:27 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-04-17 2:20 Xiao Qimai [this message]
2020-04-17 3:04 ` Zhao, XinfengX
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1587090033-272429-1-git-send-email-qimaix.xiao@intel.com \
--to=qimaix.xiao@intel.com \
--cc=dts@dpdk.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).