test suite reviews and discussions
 help / color / mirror / Atom feed
From: Lijuan Tu <lijuan.tu@intel.com>
To: dts@dpdk.org
Cc: Lijuan Tu <lijuan.tu@intel.com>
Subject: [dts] [PATCH] pktgen_ixia: fix a issue taking ownership failed
Date: Tue, 18 May 2021 05:46:56 +0800	[thread overview]
Message-ID: <1621288016-63122-1-git-send-email-lijuan.tu@intel.com> (raw)

DTS has to take ownership of an ixia port, then can operate it.
If the port is owned by other user, DTS has to take ownership forcedly.
It seems DTS intend to do above but with wrong code implement.

Signed-off-by: Lijuan Tu <lijuan.tu@intel.com>
---
 framework/pktgen_ixia.py | 8 ++++----
 1 file changed, 4 insertions(+), 4 deletions(-)

diff --git a/framework/pktgen_ixia.py b/framework/pktgen_ixia.py
index 80c5cb5..0273f3a 100644
--- a/framework/pktgen_ixia.py
+++ b/framework/pktgen_ixia.py
@@ -610,13 +610,13 @@ class Ixia(SSHConnection):
                 for item in self.ports]),
             "% ", 10)
         if out.strip()[-1] != '0':
-            return False
-        out = self.send_expect("ixTakeOwnership [list %s] force" % ' '.join(
+            self.logger.info("Force to take ownership:")
+            out = self.send_expect("ixTakeOwnership [list %s] force" % ' '.join(
             ['[list %d %d %d]' % (self.chasId, item['card'], item['port'])
                 for item in self.ports]),
             "% ", 10)
-        if out.strip()[-1] != '0':
-            return False
+            if out.strip()[-1] != '0':
+                return False
 
         return True
 
-- 
1.8.3.1


             reply	other threads:[~2021-05-17 13:49 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-05-17 21:46 Lijuan Tu [this message]
2021-05-26  6:24 ` Tu, Lijuan

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1621288016-63122-1-git-send-email-lijuan.tu@intel.com \
    --to=lijuan.tu@intel.com \
    --cc=dts@dpdk.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).