From: Jiale Song <songx.jiale@intel.com>
To: dts@dpdk.org
Cc: Jiale Song <songx.jiale@intel.com>
Subject: [dts] [PATCH V1] tests/userspace_ethtool: modify the check method of mac
Date: Thu, 16 Sep 2021 16:23:58 +0800 [thread overview]
Message-ID: <1631780638-9232-1-git-send-email-songx.jiale@intel.com> (raw)
the case check failed because the mac echoed by the "macaddr" command of dpdk-ethtool
changed to uppercase letters. modify the script to solve the problem
Signed-off-by: Jiale Song <songx.jiale@intel.com>
---
tests/TestSuite_userspace_ethtool.py | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
mode change 100644 => 100755 tests/TestSuite_userspace_ethtool.py
diff --git a/tests/TestSuite_userspace_ethtool.py b/tests/TestSuite_userspace_ethtool.py
old mode 100644
new mode 100755
index 4536b7d..9ae84c0
--- a/tests/TestSuite_userspace_ethtool.py
+++ b/tests/TestSuite_userspace_ethtool.py
@@ -510,7 +510,7 @@ class TestUserspaceEthtool(TestCase):
port = self.ports[index]
mac = self.dut.ports_info[port]['mac']
dump_mac = self.strip_mac(index)
- self.verify(mac == dump_mac, "Userspace tool failed to dump mac")
+ self.verify(mac.lower() == dump_mac.lower(), "Userspace tool failed to dump mac")
self.dut.send_expect("macaddr %d %s" % (port, valid_mac), "EthApp>")
dump_mac = self.strip_mac(index)
self.verify(dump_mac == valid_mac, "Userspace tool failed to set mac")
--
2.17.1
next reply other threads:[~2021-09-16 8:11 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-09-16 8:23 Jiale Song [this message]
2021-09-27 6:29 ` Tu, Lijuan
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1631780638-9232-1-git-send-email-songx.jiale@intel.com \
--to=songx.jiale@intel.com \
--cc=dts@dpdk.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).