From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 4EF2FA0C41; Thu, 16 Sep 2021 10:11:43 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 308854003F; Thu, 16 Sep 2021 10:11:43 +0200 (CEST) Received: from mga17.intel.com (mga17.intel.com [192.55.52.151]) by mails.dpdk.org (Postfix) with ESMTP id 8ED004003E for ; Thu, 16 Sep 2021 10:11:41 +0200 (CEST) X-IronPort-AV: E=McAfee;i="6200,9189,10108"; a="202670394" X-IronPort-AV: E=Sophos;i="5.85,297,1624345200"; d="scan'208";a="202670394" Received: from fmsmga003.fm.intel.com ([10.253.24.29]) by fmsmga107.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 16 Sep 2021 01:11:40 -0700 X-IronPort-AV: E=Sophos;i="5.85,297,1624345200"; d="scan'208";a="545431659" Received: from unknown (HELO dpdk-zhaohy-t.sh.intel.com) ([10.240.183.68]) by fmsmga003-auth.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 16 Sep 2021 01:11:39 -0700 From: Jiale Song To: dts@dpdk.org Cc: Jiale Song Date: Thu, 16 Sep 2021 16:23:58 +0800 Message-Id: <1631780638-9232-1-git-send-email-songx.jiale@intel.com> X-Mailer: git-send-email 1.8.3.1 Subject: [dts] [PATCH V1] tests/userspace_ethtool: modify the check method of mac X-BeenThere: dts@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: test suite reviews and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dts-bounces@dpdk.org Sender: "dts" the case check failed because the mac echoed by the "macaddr" command of dpdk-ethtool changed to uppercase letters. modify the script to solve the problem Signed-off-by: Jiale Song --- tests/TestSuite_userspace_ethtool.py | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) mode change 100644 => 100755 tests/TestSuite_userspace_ethtool.py diff --git a/tests/TestSuite_userspace_ethtool.py b/tests/TestSuite_userspace_ethtool.py old mode 100644 new mode 100755 index 4536b7d..9ae84c0 --- a/tests/TestSuite_userspace_ethtool.py +++ b/tests/TestSuite_userspace_ethtool.py @@ -510,7 +510,7 @@ class TestUserspaceEthtool(TestCase): port = self.ports[index] mac = self.dut.ports_info[port]['mac'] dump_mac = self.strip_mac(index) - self.verify(mac == dump_mac, "Userspace tool failed to dump mac") + self.verify(mac.lower() == dump_mac.lower(), "Userspace tool failed to dump mac") self.dut.send_expect("macaddr %d %s" % (port, valid_mac), "EthApp>") dump_mac = self.strip_mac(index) self.verify(dump_mac == valid_mac, "Userspace tool failed to set mac") -- 2.17.1