test suite reviews and discussions
 help / color / mirror / Atom feed
From: Jiale Song <songx.jiale@intel.com>
To: dts@dpdk.org
Cc: Jiale Song <songx.jiale@intel.com>
Subject: [dts] [PATCH V1 1/2] tests/cvl_switch_filter: delete the placeholder fdir rule
Date: Sat,  9 Oct 2021 16:11:44 +0800	[thread overview]
Message-ID: <1633767105-231037-1-git-send-email-songx.jiale@intel.com> (raw)

in non-pipeline mode, "priority" is ignored, a flow rule can be created as a flow director rule or
a switch rule depends on its pattern/action. if a rule is supported by switch or fdir at the same time,
it will be created in the switch table first. we no longer need to populate the fdir table first

Signed-off-by: Jiale Song <songx.jiale@intel.com>
---
 test_plans/cvl_switch_filter_test_plan.rst | 8 ++------
 tests/TestSuite_cvl_switch_filter.py       | 5 +----
 2 files changed, 3 insertions(+), 10 deletions(-)
 mode change 100644 => 100755 test_plans/cvl_switch_filter_test_plan.rst
 mode change 100644 => 100755 tests/TestSuite_cvl_switch_filter.py

diff --git a/test_plans/cvl_switch_filter_test_plan.rst b/test_plans/cvl_switch_filter_test_plan.rst
old mode 100644
new mode 100755
index b8f7e14..0f04371
--- a/test_plans/cvl_switch_filter_test_plan.rst
+++ b/test_plans/cvl_switch_filter_test_plan.rst
@@ -51,11 +51,7 @@ for device's flow director engine.
 
 In non-pipeline mode, ``priority`` is ignored, a flow rule can be created as a flow director rule or a
 switch rule depends on its pattern/action. If a rule is supported by switch or fdir at the same time, it
-will be created in the fdir table first. Therefore, to test switch filter in non-pipeline mode, we need to
-fill the fdir table first, and then the rules are created in the switch filter table. The capacity of fdir
-table is 16K, of which 14K is shared by all pfs and vfs, and the remaining 2K is gurantee for pfs. If 4*25G
-NIC, the gurantee for each pf is 512. If 2*100G NIC, the gurantee of each pf is 1024. so 1 pf can create at
-most 14848 rules on 4 ports card and 15360 rules on 2 ports card.
+will be created in the switch table first.
 
 Pattern and input set
 ---------------------
@@ -181,7 +177,7 @@ Prerequisites
 
 6. Launch dpdk with the following arguments in non-pipeline mode::
 
-     ./x86_64-native-linuxapp-gcc/app/testpmd -c 0xf -n 4 -w 0000:18:00.0 --log-level="ice,8" -- -i --txq=16 --rxq=16 --cmdline-file=testpmd_fdir_rules
+     ./x86_64-native-linuxapp-gcc/app/testpmd -c 0xf -n 4 -w 0000:18:00.0 --log-level="ice,8" -- -i --txq=16 --rxq=16
      testpmd> port config 0 rss-hash-key ipv4 1234abcd1234abcd1234abcd1234abcd1234abcd1234abcd1234abcd1234abcd1234abcd1234abcd1234abcd1234abcd1234abcd
      testpmd> set fwd rxonly
      testpmd> set verbose 1
diff --git a/tests/TestSuite_cvl_switch_filter.py b/tests/TestSuite_cvl_switch_filter.py
old mode 100644
new mode 100755
index 5ec8b18..36420d1
--- a/tests/TestSuite_cvl_switch_filter.py
+++ b/tests/TestSuite_cvl_switch_filter.py
@@ -2607,7 +2607,7 @@ class CVLSwitchFilterTest(TestCase):
         """
         #Prepare testpmd EAL and parameters
         all_eal_param = self.dut.create_eal_parameters(cores='1S/4C/1T', ports=[0])
-        command = self.path + all_eal_param + " --log-level=\"ice,8\" -- -i --rxq=16 --txq=16 --cmdline-file=%s" % self.fdir_file
+        command = self.path + all_eal_param + " --log-level=\"ice,8\" -- -i --rxq=16 --txq=16"
         # command = "./%s/app/testpmd %s --log-level=\"ice,8\" -- -i %s" % (self.dut.target, all_eal_param, "--rxq=16 --txq=16")
         return command
 
@@ -2784,9 +2784,6 @@ class CVLSwitchFilterTest(TestCase):
             out_lines = out.splitlines()
             res = filter(bool, map(p_spec.match, out_lines))
             result = [i.group(1) for i in res]
-            if is_non_pipeline:
-                #remove 15360 fdir rules id
-                del result[:self.fdir_rule_number]
             if is_need_rss_rule:
                 #remove rss rule id
                 del result[0]
-- 
2.17.1


             reply	other threads:[~2021-10-09  7:58 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-10-09  8:11 Jiale Song [this message]
2021-10-09  8:11 ` [dts] [PATCH V1 2/2] tests/cvl_switch_filter_pppoe: " Jiale Song
2021-10-20  9:52 ` [dts] [PATCH V1 1/2] tests/cvl_switch_filter: " Huang, ZhiminX

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1633767105-231037-1-git-send-email-songx.jiale@intel.com \
    --to=songx.jiale@intel.com \
    --cc=dts@dpdk.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).