test suite reviews and discussions
 help / color / mirror / Atom feed
From: Jiale Song <songx.jiale@intel.com>
To: dts@dpdk.org
Cc: Jiale Song <songx.jiale@intel.com>
Subject: [dts] [PATCH V2] tests/link_status_interrupt: close nic link-down-on-close off
Date: Sat,  9 Oct 2021 17:00:25 +0800	[thread overview]
Message-ID: <1633770025-6422-1-git-send-email-songx.jiale@intel.com> (raw)

since the link-down-on-close of the tester is turned on, but 
not closed, the subsequent tests are affected.

Signed-off-by: Jiale Song <songx.jiale@intel.com>
---
 tests/TestSuite_link_status_interrupt.py | 19 +------------------
 1 file changed, 1 insertion(+), 18 deletions(-)

diff --git a/tests/TestSuite_link_status_interrupt.py b/tests/TestSuite_link_status_interrupt.py
index 5590d94..2ad1559 100755
--- a/tests/TestSuite_link_status_interrupt.py
+++ b/tests/TestSuite_link_status_interrupt.py
@@ -70,22 +70,6 @@ class TestLinkStatusInterrupt(TestCase):
             self.basic_intr_mode = ["msix", "legacy"]
         if self.drivername == "vfio-pci":
             self.basic_intr_mode.append("msi")
-        self.intfs = [self.tester.get_interface(self.tester.get_local_port(i)) for i in self.dut_ports]
-        # check link-down-on-close flag
-        self.flag = "link-down-on-close"
-        for intf in self.intfs:
-            check_flag = "ethtool --show-priv-flags %s" % intf
-            set_flag = "ethtool --set-priv-flags %s %s on" % (intf, self.flag)
-            out = self.tester.send_expect(check_flag, "#")
-            p = re.compile('%s\s+:\s+(\w+)' % self.flag)
-            res = re.search(p, out).group(1)
-            if res == "off":
-                self.tester.send_expect(set_flag, "#")
-                time.sleep(0.5)
-                out = self.tester.send_expect(check_flag, "#")
-                self.verify(re.search(p, out).group(1) == "on", "set %s %s on failed" % (intf, self.flag))
-            elif not res:
-                self.logger.info("NIC %s might not support this case" % intf)
 
     def set_link_status_and_verify(self, dutPort, status):
         """
@@ -210,5 +194,4 @@ class TestLinkStatusInterrupt(TestCase):
         Run after each test suite.
         """
         if self.dut.get_os_type() != 'freebsd':
-            for intf in self.intfs:
-                self.tester.send_expect("ethtool --set-priv-flags %s %s off" % (intf, self.flag), "#", 10)
+            self.tester.send_expect("ethtool --set-priv-flags %s link-down-on-close off" % self.intf, "#", 10)
-- 
2.17.1


             reply	other threads:[~2021-10-09  8:46 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-10-09  9:00 Jiale Song [this message]
2021-10-11  3:42 Jiale Song
2021-10-25  3:52 ` Tu, Lijuan
     [not found]   ` <BN0PR11MB574369AB412ABEA91792B917E7839@BN0PR11MB5743.namprd11.prod.outlook.com>
2021-10-25  6:37     ` Tu, Lijuan

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1633770025-6422-1-git-send-email-songx.jiale@intel.com \
    --to=songx.jiale@intel.com \
    --cc=dts@dpdk.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).