test suite reviews and discussions
 help / color / mirror / Atom feed
From: Jiale Song <songx.jiale@intel.com>
To: dts@dpdk.org
Cc: Jiale Song <songx.jiale@intel.com>
Subject: [dts] [PATCH V2] tests/rteflow_priority: update case code for dpdk code change
Date: Thu, 14 Oct 2021 16:10:23 +0800	[thread overview]
Message-ID: <1634199023-65745-1-git-send-email-songx.jiale@intel.com> (raw)

when dpdk fixed a bug, the code design changed, so in order to test the fdir rule,
need to add "mark" to the rule

Signed-off-by: Jiale Song <songx.jiale@intel.com>
---
 test_plans/rteflow_priority_test_plan.rst | 4 ++--
 tests/TestSuite_rteflow_priority.py       | 8 ++++----
 2 files changed, 6 insertions(+), 6 deletions(-)

diff --git a/test_plans/rteflow_priority_test_plan.rst b/test_plans/rteflow_priority_test_plan.rst
index b1815ce..4ca1c22 100644
--- a/test_plans/rteflow_priority_test_plan.rst
+++ b/test_plans/rteflow_priority_test_plan.rst
@@ -77,14 +77,14 @@ Patterns in this case:
 
 #. Create a rule with priority 0, Check the flow can be created but it will map to fdir filter::
 
-    testpmd> flow create 0 priority 0 ingress pattern eth / ipv4 src is 192.168.0.2 dst is 192.168.0.3 tos is 4 / end actions queue index 2 / end
+    testpmd> flow create 0 priority 0 ingress pattern eth / ipv4 src is 192.168.0.2 dst is 192.168.0.3 tos is 4 / end actions queue index 2 / mark / end
     ice_interrupt_handler(): OICR: MDD event
     ice_flow_create(): Succeeded to create (1) flow
     Flow rule #0 created
 
 #. Create a rule with priority 1, check the flow can not be created for the vallue of priority is 0 in non-pipeline mode::
 
-    testpmd> flow create 0 priority 1 ingress pattern eth / ipv4 src is 192.168.0.2 dst is 192.168.0.3 tos is 4 / end actions queue index 2 / end
+    testpmd> flow create 0 priority 1 ingress pattern eth / ipv4 src is 192.168.0.2 dst is 192.168.0.3 tos is 4 / end actions queue index 2 / mark / end
     ice_flow_create(): Failed to create flow
     Caught error type 4 (priority field): cause: 0x7ffe24e65738, Not support priority.: Invalid argument
 
diff --git a/tests/TestSuite_rteflow_priority.py b/tests/TestSuite_rteflow_priority.py
index 23aea82..61607c1 100755
--- a/tests/TestSuite_rteflow_priority.py
+++ b/tests/TestSuite_rteflow_priority.py
@@ -204,9 +204,9 @@ class TestRteflowPriority(TestCase):
         out = self.dut.send_expect(command, "testpmd> ", 120)
         self.logger.debug(out)
         
-        out=self.dut.send_expect("flow create 0 priority 0 ingress pattern eth / ipv4 src is 192.168.0.2 dst is 192.168.0.3 tos is 4 / end actions queue index 2 / end", "testpmd>", 15)       
+        out=self.dut.send_expect("flow create 0 priority 0 ingress pattern eth / ipv4 src is 192.168.0.2 dst is 192.168.0.3 tos is 4 / end actions queue index 2 / mark / end", "testpmd>", 15)
         self.verify( "Successed" and "(1)" in out, "failed: rule can't be created to fdir")
-        out=self.dut.send_expect("flow create 0 priority 1 ingress pattern eth / ipv4 src is 192.168.0.2 dst is 192.168.0.3 tos is 4 / end actions queue index 2 / end", "testpmd>", 15)       
+        out=self.dut.send_expect("flow create 0 priority 1 ingress pattern eth / ipv4 src is 192.168.0.2 dst is 192.168.0.3 tos is 4 / end actions queue index 2 / mark / end", "testpmd>", 15)
         self.verify( "Failed" in out, "failed: default value of priority is 0 in non-pipeline mode")
         self.dut.send_expect("flow flush 0", "testpmd>", 20)
         self.dut.send_expect("quit", "#", 50)
@@ -216,9 +216,9 @@ class TestRteflowPriority(TestCase):
         out = self.dut.send_expect(command, "testpmd> ", 120)
         self.logger.debug(out)
         
-        out=self.dut.send_expect("flow create 0 priority 0 ingress pattern eth / ipv4 src is 192.168.0.2 dst is 192.168.0.3 tos is 4 / end actions queue index 2 / end", "testpmd>", 15)       
+        out=self.dut.send_expect("flow create 0 priority 0 ingress pattern eth / ipv4 src is 192.168.0.2 dst is 192.168.0.3 tos is 4 / end actions queue index 2 / mark / end", "testpmd>", 15)
         self.verify( "Successed" and "(1)" in out, "failed: rule can't be created to fdir")
-        out=self.dut.send_expect("flow create 0 priority 1 ingress pattern eth / ipv4 src is 192.168.0.2 dst is 192.168.0.3 tos is 4 / end actions queue index 2 / end", "testpmd>", 15)       
+        out=self.dut.send_expect("flow create 0 priority 1 ingress pattern eth / ipv4 src is 192.168.0.2 dst is 192.168.0.3 tos is 4 / end actions queue index 2 / mark / end", "testpmd>", 15)
         self.verify( "Failed" in out, "failed: default value of priority is 0 in non-pipeline mode")
         self.dut.send_expect("flow flush 0", "testpmd>", 20)
         self.dut.send_expect("quit", "#", 50)
-- 
2.17.1


             reply	other threads:[~2021-10-14  7:56 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-10-14  8:10 Jiale Song [this message]
2021-10-21  2:02 ` Huang, ZhiminX
2021-10-26  6:14   ` Tu, Lijuan

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1634199023-65745-1-git-send-email-songx.jiale@intel.com \
    --to=songx.jiale@intel.com \
    --cc=dts@dpdk.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).