test suite reviews and discussions
 help / color / mirror / Atom feed
* [dts] [PATCH V2] tests/rteflow_priority: update case code for dpdk code change
@ 2021-10-14  8:10 Jiale Song
  2021-10-21  2:02 ` Huang, ZhiminX
  0 siblings, 1 reply; 3+ messages in thread
From: Jiale Song @ 2021-10-14  8:10 UTC (permalink / raw)
  To: dts; +Cc: Jiale Song

when dpdk fixed a bug, the code design changed, so in order to test the fdir rule,
need to add "mark" to the rule

Signed-off-by: Jiale Song <songx.jiale@intel.com>
---
 test_plans/rteflow_priority_test_plan.rst | 4 ++--
 tests/TestSuite_rteflow_priority.py       | 8 ++++----
 2 files changed, 6 insertions(+), 6 deletions(-)

diff --git a/test_plans/rteflow_priority_test_plan.rst b/test_plans/rteflow_priority_test_plan.rst
index b1815ce..4ca1c22 100644
--- a/test_plans/rteflow_priority_test_plan.rst
+++ b/test_plans/rteflow_priority_test_plan.rst
@@ -77,14 +77,14 @@ Patterns in this case:
 
 #. Create a rule with priority 0, Check the flow can be created but it will map to fdir filter::
 
-    testpmd> flow create 0 priority 0 ingress pattern eth / ipv4 src is 192.168.0.2 dst is 192.168.0.3 tos is 4 / end actions queue index 2 / end
+    testpmd> flow create 0 priority 0 ingress pattern eth / ipv4 src is 192.168.0.2 dst is 192.168.0.3 tos is 4 / end actions queue index 2 / mark / end
     ice_interrupt_handler(): OICR: MDD event
     ice_flow_create(): Succeeded to create (1) flow
     Flow rule #0 created
 
 #. Create a rule with priority 1, check the flow can not be created for the vallue of priority is 0 in non-pipeline mode::
 
-    testpmd> flow create 0 priority 1 ingress pattern eth / ipv4 src is 192.168.0.2 dst is 192.168.0.3 tos is 4 / end actions queue index 2 / end
+    testpmd> flow create 0 priority 1 ingress pattern eth / ipv4 src is 192.168.0.2 dst is 192.168.0.3 tos is 4 / end actions queue index 2 / mark / end
     ice_flow_create(): Failed to create flow
     Caught error type 4 (priority field): cause: 0x7ffe24e65738, Not support priority.: Invalid argument
 
diff --git a/tests/TestSuite_rteflow_priority.py b/tests/TestSuite_rteflow_priority.py
index 23aea82..61607c1 100755
--- a/tests/TestSuite_rteflow_priority.py
+++ b/tests/TestSuite_rteflow_priority.py
@@ -204,9 +204,9 @@ class TestRteflowPriority(TestCase):
         out = self.dut.send_expect(command, "testpmd> ", 120)
         self.logger.debug(out)
         
-        out=self.dut.send_expect("flow create 0 priority 0 ingress pattern eth / ipv4 src is 192.168.0.2 dst is 192.168.0.3 tos is 4 / end actions queue index 2 / end", "testpmd>", 15)       
+        out=self.dut.send_expect("flow create 0 priority 0 ingress pattern eth / ipv4 src is 192.168.0.2 dst is 192.168.0.3 tos is 4 / end actions queue index 2 / mark / end", "testpmd>", 15)
         self.verify( "Successed" and "(1)" in out, "failed: rule can't be created to fdir")
-        out=self.dut.send_expect("flow create 0 priority 1 ingress pattern eth / ipv4 src is 192.168.0.2 dst is 192.168.0.3 tos is 4 / end actions queue index 2 / end", "testpmd>", 15)       
+        out=self.dut.send_expect("flow create 0 priority 1 ingress pattern eth / ipv4 src is 192.168.0.2 dst is 192.168.0.3 tos is 4 / end actions queue index 2 / mark / end", "testpmd>", 15)
         self.verify( "Failed" in out, "failed: default value of priority is 0 in non-pipeline mode")
         self.dut.send_expect("flow flush 0", "testpmd>", 20)
         self.dut.send_expect("quit", "#", 50)
@@ -216,9 +216,9 @@ class TestRteflowPriority(TestCase):
         out = self.dut.send_expect(command, "testpmd> ", 120)
         self.logger.debug(out)
         
-        out=self.dut.send_expect("flow create 0 priority 0 ingress pattern eth / ipv4 src is 192.168.0.2 dst is 192.168.0.3 tos is 4 / end actions queue index 2 / end", "testpmd>", 15)       
+        out=self.dut.send_expect("flow create 0 priority 0 ingress pattern eth / ipv4 src is 192.168.0.2 dst is 192.168.0.3 tos is 4 / end actions queue index 2 / mark / end", "testpmd>", 15)
         self.verify( "Successed" and "(1)" in out, "failed: rule can't be created to fdir")
-        out=self.dut.send_expect("flow create 0 priority 1 ingress pattern eth / ipv4 src is 192.168.0.2 dst is 192.168.0.3 tos is 4 / end actions queue index 2 / end", "testpmd>", 15)       
+        out=self.dut.send_expect("flow create 0 priority 1 ingress pattern eth / ipv4 src is 192.168.0.2 dst is 192.168.0.3 tos is 4 / end actions queue index 2 / mark / end", "testpmd>", 15)
         self.verify( "Failed" in out, "failed: default value of priority is 0 in non-pipeline mode")
         self.dut.send_expect("flow flush 0", "testpmd>", 20)
         self.dut.send_expect("quit", "#", 50)
-- 
2.17.1


^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: [dts] [PATCH V2] tests/rteflow_priority: update case code for dpdk code change
  2021-10-14  8:10 [dts] [PATCH V2] tests/rteflow_priority: update case code for dpdk code change Jiale Song
@ 2021-10-21  2:02 ` Huang, ZhiminX
  2021-10-26  6:14   ` Tu, Lijuan
  0 siblings, 1 reply; 3+ messages in thread
From: Huang, ZhiminX @ 2021-10-21  2:02 UTC (permalink / raw)
  To: dts; +Cc: Jiale, SongX

> -----Original Message-----
> From: dts <dts-bounces@dpdk.org> On Behalf Of Jiale Song
> Sent: Thursday, October 14, 2021 4:10 PM
> To: dts@dpdk.org
> Cc: Jiale, SongX <songx.jiale@intel.com>
> Subject: [dts] [PATCH V2] tests/rteflow_priority: update case code for dpdk
> code change
> 
> when dpdk fixed a bug, the code design changed, so in order to test the fdir rule,
> need to add "mark" to the rule
> 
> Signed-off-by: Jiale Song <songx.jiale@intel.com>
> ---
Add dpdk code changed commit: e4a0a7599d974f05665fec3e4c251659f0b11453

^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: [dts] [PATCH V2] tests/rteflow_priority: update case code for dpdk code change
  2021-10-21  2:02 ` Huang, ZhiminX
@ 2021-10-26  6:14   ` Tu, Lijuan
  0 siblings, 0 replies; 3+ messages in thread
From: Tu, Lijuan @ 2021-10-26  6:14 UTC (permalink / raw)
  To: Huang, ZhiminX, dts; +Cc: Jiale, SongX



> -----Original Message-----
> From: dts <dts-bounces@dpdk.org> On Behalf Of Huang, ZhiminX
> Sent: 2021年10月21日 10:02
> To: dts@dpdk.org
> Cc: Jiale, SongX <songx.jiale@intel.com>
> Subject: Re: [dts] [PATCH V2] tests/rteflow_priority: update case code for dpdk
> code change
> 
> > -----Original Message-----
> > From: dts <dts-bounces@dpdk.org> On Behalf Of Jiale Song
> > Sent: Thursday, October 14, 2021 4:10 PM
> > To: dts@dpdk.org
> > Cc: Jiale, SongX <songx.jiale@intel.com>
> > Subject: [dts] [PATCH V2] tests/rteflow_priority: update case code for
> > dpdk code change
> >
> > when dpdk fixed a bug, the code design changed, so in order to test
> > the fdir rule, need to add "mark" to the rule
> >
> > Signed-off-by: Jiale Song <songx.jiale@intel.com>
> > ---
> Add dpdk code changed commit:
> e4a0a7599d974f05665fec3e4c251659f0b11453

Applied

^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, other threads:[~2021-10-26  6:14 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-10-14  8:10 [dts] [PATCH V2] tests/rteflow_priority: update case code for dpdk code change Jiale Song
2021-10-21  2:02 ` Huang, ZhiminX
2021-10-26  6:14   ` Tu, Lijuan

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).