From: Jiale Song <songx.jiale@intel.com>
To: dts@dpdk.org
Cc: Jiale Song <songx.jiale@intel.com>
Subject: [dts] [PATCH V3] tests/link_status_interrupt: optimize link-down-on-close checking method
Date: Mon, 25 Oct 2021 17:05:48 +0800 [thread overview]
Message-ID: <1635152748-95420-1-git-send-email-songx.jiale@intel.com> (raw)
some nic no link-down-on-close
Signed-off-by: Jiale Song <songx.jiale@intel.com>
---
tests/TestSuite_link_status_interrupt.py | 18 ++++++++++--------
1 file changed, 10 insertions(+), 8 deletions(-)
diff --git a/tests/TestSuite_link_status_interrupt.py b/tests/TestSuite_link_status_interrupt.py
index bdb43f42..b58099b0 100755
--- a/tests/TestSuite_link_status_interrupt.py
+++ b/tests/TestSuite_link_status_interrupt.py
@@ -79,14 +79,16 @@ class TestLinkStatusInterrupt(TestCase):
set_flag = "ethtool --set-priv-flags %s %s on" % (intf, self.flag)
out = self.tester.send_expect(check_flag, "#")
p = re.compile('%s\s+:\s+(\w+)' % self.flag)
- res = re.search(p, out).group(1)
- if res == "off":
- self.tester.send_expect(set_flag, "#")
- time.sleep(0.5)
- out = self.tester.send_expect(check_flag, "#")
- self.verify(re.search(p, out).group(1) == "on", "set %s %s on failed" % (intf, self.flag))
- elif not res:
- self.logger.info("NIC %s might not support this case" % intf)
+ match = re.search(p, out)
+ if match:
+ res = match.group(1)
+ if res == "off":
+ self.tester.send_expect(set_flag, "#")
+ time.sleep(0.5)
+ out = self.tester.send_expect(check_flag, "#")
+ self.verify(re.search(p, out).group(1) == "on", "set %s %s on failed" % (intf, self.flag))
+ elif not res:
+ self.logger.info("NIC %s might not support this case" % intf)
def set_link_status_and_verify(self, dutPort, status):
"""
--
2.17.1
reply other threads:[~2021-10-25 9:06 UTC|newest]
Thread overview: [no followups] expand[flat|nested] mbox.gz Atom feed
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1635152748-95420-1-git-send-email-songx.jiale@intel.com \
--to=songx.jiale@intel.com \
--cc=dts@dpdk.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).