From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id B78CEA0C45; Thu, 28 Oct 2021 09:12:30 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id AE2614067B; Thu, 28 Oct 2021 09:12:30 +0200 (CEST) Received: from mga17.intel.com (mga17.intel.com [192.55.52.151]) by mails.dpdk.org (Postfix) with ESMTP id 944734003F for ; Thu, 28 Oct 2021 09:12:28 +0200 (CEST) X-IronPort-AV: E=McAfee;i="6200,9189,10150"; a="211114543" X-IronPort-AV: E=Sophos;i="5.87,189,1631602800"; d="scan'208";a="211114543" Received: from orsmga007.jf.intel.com ([10.7.209.58]) by fmsmga107.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 28 Oct 2021 00:12:20 -0700 X-IronPort-AV: E=Sophos;i="5.87,189,1631602800"; d="scan'208";a="487012647" Received: from unknown (HELO dpdk-zhaohy-t.sh.intel.com) ([10.240.183.68]) by orsmga007-auth.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 28 Oct 2021 00:12:19 -0700 From: Jiale Song To: dts@dpdk.org Cc: Jiale Song Date: Thu, 28 Oct 2021 15:12:11 +0800 Message-Id: <1635405131-104331-1-git-send-email-songx.jiale@intel.com> X-Mailer: git-send-email 1.8.3.1 Subject: [dts] [PATCH V2] tests/link_status_interrupt: optimize the method of checking priv_flags X-BeenThere: dts@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: test suite reviews and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dts-bounces@dpdk.org Sender: "dts" Signed-off-by: Jiale Song --- tests/TestSuite_link_status_interrupt.py | 37 +++++++++++++++--------- 1 file changed, 24 insertions(+), 13 deletions(-) diff --git a/tests/TestSuite_link_status_interrupt.py b/tests/TestSuite_link_status_interrupt.py index bdb43f42..bdee2155 100755 --- a/tests/TestSuite_link_status_interrupt.py +++ b/tests/TestSuite_link_status_interrupt.py @@ -75,18 +75,29 @@ class TestLinkStatusInterrupt(TestCase): # check link-down-on-close flag self.flag = "link-down-on-close" for intf in self.intfs: - check_flag = "ethtool --show-priv-flags %s" % intf set_flag = "ethtool --set-priv-flags %s %s on" % (intf, self.flag) - out = self.tester.send_expect(check_flag, "#") - p = re.compile('%s\s+:\s+(\w+)' % self.flag) - res = re.search(p, out).group(1) - if res == "off": - self.tester.send_expect(set_flag, "#") + self.flag_stats = self.get_priv_flags_default_state(intf, self.flag) + if self.flag_stats == "off": + self.tester.send_expect(set_flag, "# ") time.sleep(0.5) - out = self.tester.send_expect(check_flag, "#") - self.verify(re.search(p, out).group(1) == "on", "set %s %s on failed" % (intf, self.flag)) - elif not res: - self.logger.info("NIC %s might not support this case" % intf) + self.verify(self.get_priv_flags_default_state(intf, self.flag) == "on", "set %s %s on failed" % (intf, self.flag)) + + def get_priv_flags_default_state(self, intf, flag): + ''' + + :param intf: nic name + :param flag: priv-flags flag + :return: flag default state + ''' + check_flag = "ethtool --show-priv-flags %s" % intf + out = self.tester.send_expect(check_flag, "# ") + p = re.compile('%s\s+:\s+(\w+)' % flag) + default_state = re.search(p, out) + if default_state: + return default_state.group(1) + else: + self.logger.info("NIC %s may be not find %s" % (intf, self.flag)) + return False def set_link_status_and_verify(self, dutPort, status): """ @@ -94,7 +105,7 @@ class TestLinkStatusInterrupt(TestCase): """ self.intf = self.tester.get_interface( self.tester.get_local_port(dutPort)) - if self.dut.get_os_type() != 'freebsd': + if self.dut.get_os_type() != 'freebsd' and self.flag_stats: self.tester.send_expect("ethtool --set-priv-flags %s link-down-on-close on" % self.intf, "#", 10) self.tester.send_expect("ifconfig %s %s" % (self.intf, status.lower()), "# ", 10) @@ -210,6 +221,6 @@ class TestLinkStatusInterrupt(TestCase): """ Run after each test suite. """ - if self.dut.get_os_type() != 'freebsd': + if self.dut.get_os_type() != 'freebsd' and self.flag_stats: for intf in self.intfs: - self.tester.send_expect("ethtool --set-priv-flags %s %s off" % (intf, self.flag), "#", 10) + self.tester.send_expect("ethtool --set-priv-flags %s %s %s" % (intf, self.flag, self.flag_stats), "# ") -- 2.17.1