test suite reviews and discussions
 help / color / mirror / Atom feed
* [dts] [PATCH V1] tests/iavf_fdir: optimization script
@ 2021-11-02  3:18 Jiale Song
  2021-11-02  8:37 ` Huang, ZhiminX
  2021-11-05 13:43 ` Tu, Lijuan
  0 siblings, 2 replies; 3+ messages in thread
From: Jiale Song @ 2021-11-02  3:18 UTC (permalink / raw)
  To: dts; +Cc: Jiale Song

initialize PF. because pf is not initialized after case test, other case tests fail

Signed-off-by: Jiale Song <songx.jiale@intel.com>
---
 tests/TestSuite_iavf_fdir.py | 3 +--
 1 file changed, 1 insertion(+), 2 deletions(-)
 mode change 100755 => 100644 tests/TestSuite_iavf_fdir.py

diff --git a/tests/TestSuite_iavf_fdir.py b/tests/TestSuite_iavf_fdir.py
old mode 100755
new mode 100644
index fab7cc27..5803f5f7
--- a/tests/TestSuite_iavf_fdir.py
+++ b/tests/TestSuite_iavf_fdir.py
@@ -7593,6 +7593,7 @@ class TestIAVFFdir(TestCase):
         """
         Run before each test case.
         """
+        self.dut.restore_interfaces_linux()
         self.setup_2pf_4vf_env()
         time.sleep(1)
         self.launch_testpmd()
@@ -8344,7 +8345,6 @@ class TestIAVFFdir(TestCase):
         create same rules on pf and vf, no conflict
         """
         self.dut.kill_all()
-        self.setup_2pf_4vf_env()
         self.session_secondary = self.dut.new_session()
         self.session_third = self.dut.new_session()
 
@@ -8496,7 +8496,6 @@ class TestIAVFFdir(TestCase):
         create same input set but different action rules on pf and vf, no conflict.
         """
         self.dut.kill_all()
-        self.setup_2pf_4vf_env()
         self.session_secondary = self.dut.new_session()
         self.session_third = self.dut.new_session()
 
-- 
2.17.1


^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: [dts] [PATCH V1] tests/iavf_fdir: optimization script
  2021-11-02  3:18 [dts] [PATCH V1] tests/iavf_fdir: optimization script Jiale Song
@ 2021-11-02  8:37 ` Huang, ZhiminX
  2021-11-05 13:43 ` Tu, Lijuan
  1 sibling, 0 replies; 3+ messages in thread
From: Huang, ZhiminX @ 2021-11-02  8:37 UTC (permalink / raw)
  To: dts; +Cc: Jiale, SongX

[-- Attachment #1: Type: text/plain, Size: 477 bytes --]

> -----Original Message-----
> From: dts <dts-bounces@dpdk.org> On Behalf Of Jiale Song
> Sent: Tuesday, November 2, 2021 11:18 AM
> To: dts@dpdk.org
> Cc: Jiale, SongX <songx.jiale@intel.com>
> Subject: [dts] [PATCH V1] tests/iavf_fdir: optimization script
> 
> initialize PF. because pf is not initialized after case test, other case tests fail
> 
> Signed-off-by: Jiale Song <songx.jiale@intel.com>
> ---

Tested-by: Zhimin Huang <zhiminx.huang@intel.com >



[-- Attachment #2: TestIAVFFdir.log --]
[-- Type: application/octet-stream, Size: 4139910 bytes --]

^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: [dts] [PATCH V1] tests/iavf_fdir: optimization script
  2021-11-02  3:18 [dts] [PATCH V1] tests/iavf_fdir: optimization script Jiale Song
  2021-11-02  8:37 ` Huang, ZhiminX
@ 2021-11-05 13:43 ` Tu, Lijuan
  1 sibling, 0 replies; 3+ messages in thread
From: Tu, Lijuan @ 2021-11-05 13:43 UTC (permalink / raw)
  To: Jiale, SongX, dts; +Cc: Jiale, SongX

> -----Original Message-----
> From: dts <dts-bounces@dpdk.org> On Behalf Of Jiale Song
> Sent: 2021年11月2日 11:18
> To: dts@dpdk.org
> Cc: Jiale, SongX <songx.jiale@intel.com>
> Subject: [dts] [PATCH V1] tests/iavf_fdir: optimization script
> 
> initialize PF. because pf is not initialized after case test, other case tests fail

For the reason, self.dut.kill_all() should be removed at the same time.

> 
> Signed-off-by: Jiale Song <songx.jiale@intel.com>

^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, other threads:[~2021-11-05 13:43 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-11-02  3:18 [dts] [PATCH V1] tests/iavf_fdir: optimization script Jiale Song
2021-11-02  8:37 ` Huang, ZhiminX
2021-11-05 13:43 ` Tu, Lijuan

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).