test suite reviews and discussions
 help / color / mirror / Atom feed
* [dts] [PATCH V2 1/4] tests/kernelpf_iavf: modify code to adapt avx512
@ 2021-11-04  6:51 Xiang An
  2021-11-04  6:51 ` [dts] [PATCH V2 2/4] tests/vf_vlan: " Xiang An
                   ` (2 more replies)
  0 siblings, 3 replies; 7+ messages in thread
From: Xiang An @ 2021-11-04  6:51 UTC (permalink / raw)
  To: dts; +Cc: xiangx.an

Based on dpdk commit:4b64ccb328 modify dts code to adapt avx512.

Signed-off-by: Xiang An <xiangx.an@intel.com>
---
 tests/TestSuite_kernelpf_iavf.py | 12 +++++++++---
 1 file changed, 9 insertions(+), 3 deletions(-)

diff --git a/tests/TestSuite_kernelpf_iavf.py b/tests/TestSuite_kernelpf_iavf.py
index dde59e1..59d16ae 100644
--- a/tests/TestSuite_kernelpf_iavf.py
+++ b/tests/TestSuite_kernelpf_iavf.py
@@ -44,7 +44,7 @@ import time
 import framework.utils as utils
 from framework.packet import Packet
 from framework.pmd_output import PmdOutput
-from framework.settings import HEADER_SIZE
+from framework.settings import HEADER_SIZE, load_global_setting, DPDK_RXMODE_SETTING
 from framework.test_case import TestCase
 from framework.utils import RED
 from framework.virt_common import VM
@@ -774,7 +774,10 @@ class TestKernelpfIavf(TestCase):
         self.verify(bad_l4csum == 2, "Bad-ipcsum check error")
 
     def test_vf_hw_checksum_offload(self):
-        self.vm_testpmd.start_testpmd("all")
+        if load_global_setting(DPDK_RXMODE_SETTING) == 'avx512':
+            self.vm_testpmd.start_testpmd("all", "--enable-rx-cksum")
+        else:
+            self.vm_testpmd.start_testpmd("all")
         self.enable_hw_checksum()
         self.vm_testpmd.execute_cmd("port start all")
         self.vm_testpmd.execute_cmd("set verbose 1")
@@ -782,7 +785,10 @@ class TestKernelpfIavf(TestCase):
         self.checksum_verify()
 
     def test_vf_sw_checksum_offload(self):
-        self.vm_testpmd.start_testpmd("all")
+        if load_global_setting(DPDK_RXMODE_SETTING) == 'avx512':
+            self.vm_testpmd.start_testpmd("all", "--enable-rx-cksum")
+        else:
+            self.vm_testpmd.start_testpmd("all")
         self.enable_sw_checksum()
         self.vm_testpmd.execute_cmd("port start all")
         self.vm_testpmd.execute_cmd("start")
-- 
1.8.3.1


^ permalink raw reply	[flat|nested] 7+ messages in thread

* [dts] [PATCH V2 2/4] tests/vf_vlan: modify code to adapt avx512
  2021-11-04  6:51 [dts] [PATCH V2 1/4] tests/kernelpf_iavf: modify code to adapt avx512 Xiang An
@ 2021-11-04  6:51 ` Xiang An
  2021-11-05 12:31   ` Tu, Lijuan
  2021-11-04  6:51 ` [dts] [PATCH V2 3/4] tests/l3fwdacl: " Xiang An
  2021-11-04  6:51 ` [dts] [PATCH V2 4/4] tests/unit_tests_eal: " Xiang An
  2 siblings, 1 reply; 7+ messages in thread
From: Xiang An @ 2021-11-04  6:51 UTC (permalink / raw)
  To: dts; +Cc: xiangx.an

Based on dpdk commit:4b64ccb328 modify dts code to adapt avx512.

Signed-off-by: Xiang An <xiangx.an@intel.com>
---
 tests/TestSuite_vf_vlan.py | 12 +++++++++---
 1 file changed, 9 insertions(+), 3 deletions(-)

diff --git a/tests/TestSuite_vf_vlan.py b/tests/TestSuite_vf_vlan.py
index 127eca3..ff3e13f 100644
--- a/tests/TestSuite_vf_vlan.py
+++ b/tests/TestSuite_vf_vlan.py
@@ -35,7 +35,7 @@ import time
 
 from framework.packet import Packet
 from framework.pmd_output import PmdOutput
-from framework.settings import get_nic_name
+from framework.settings import get_nic_name, load_global_setting, DPDK_RXMODE_SETTING
 from framework.test_case import TestCase
 from framework.virt_common import VM
 
@@ -346,7 +346,10 @@ class TestVfVlan(TestCase):
         self.vm0_dut_ports = self.vm_dut_0.get_ports('any')
 
         self.vm0_testpmd = PmdOutput(self.vm_dut_0)
-        self.vm0_testpmd.start_testpmd(VM_CORES_MASK)
+        if load_global_setting(DPDK_RXMODE_SETTING) == 'avx512':
+            self.vm0_testpmd.start_testpmd(VM_CORES_MASK, '--enable-rx-cksum')
+        else:
+            self.vm0_testpmd.start_testpmd(VM_CORES_MASK)
         self.vm0_testpmd.execute_cmd('set fwd rxonly')
         self.vm0_testpmd.execute_cmd('set verbose 1')
         self.vm0_testpmd.execute_cmd('vlan set strip on 0')
@@ -417,7 +420,10 @@ class TestVfVlan(TestCase):
         if self.kdriver == "i40e":
             self.vm0_testpmd.start_testpmd(VM_CORES_MASK, '')
         else:
-            self.vm0_testpmd.start_testpmd(VM_CORES_MASK)
+            if load_global_setting(DPDK_RXMODE_SETTING) == 'avx512':
+                self.vm0_testpmd.start_testpmd(VM_CORES_MASK, '--enable-rx-cksum')
+            else:
+                self.vm0_testpmd.start_testpmd(VM_CORES_MASK)
         self.vm0_testpmd.execute_cmd('set fwd rxonly')
         self.vm0_testpmd.execute_cmd('set verbose 1')
         self.vm0_testpmd.execute_cmd('start')
-- 
1.8.3.1


^ permalink raw reply	[flat|nested] 7+ messages in thread

* [dts] [PATCH V2 3/4] tests/l3fwdacl: modify code to adapt avx512
  2021-11-04  6:51 [dts] [PATCH V2 1/4] tests/kernelpf_iavf: modify code to adapt avx512 Xiang An
  2021-11-04  6:51 ` [dts] [PATCH V2 2/4] tests/vf_vlan: " Xiang An
@ 2021-11-04  6:51 ` Xiang An
  2021-11-05 13:24   ` Tu, Lijuan
  2021-11-04  6:51 ` [dts] [PATCH V2 4/4] tests/unit_tests_eal: " Xiang An
  2 siblings, 1 reply; 7+ messages in thread
From: Xiang An @ 2021-11-04  6:51 UTC (permalink / raw)
  To: dts; +Cc: xiangx.an

Modify code to adapt rxmod avx512.

Signed-off-by: Xiang An <xiangx.an@intel.com>
---
 tests/TestSuite_l3fwdacl.py | 6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)

diff --git a/tests/TestSuite_l3fwdacl.py b/tests/TestSuite_l3fwdacl.py
index 65c46b0..b812192 100644
--- a/tests/TestSuite_l3fwdacl.py
+++ b/tests/TestSuite_l3fwdacl.py
@@ -40,6 +40,7 @@ import time
 import framework.packet as packet
 import framework.utils as utils
 from framework.test_case import TestCase
+from framework.settings import load_global_setting, DPDK_RXMODE_SETTING
 
 
 class TestL3fwdacl(TestCase):
@@ -638,13 +639,12 @@ class TestL3fwdacl(TestCase):
         cores = self.get_core_list()
         self.verify(cores is not None, "Insufficient cores for speed testing")
 
-        self.eal_para = self.dut.create_eal_parameters(cores=self.get_core_list())
+        self.eal_para = self.dut.create_eal_parameters(cores=self.get_core_list(), other_eal_param='force-max-simd-bitwidth')
         self.core_mask = utils.create_mask(cores)
         print("Core mask: %s" % self.core_mask)
 
         if self.dut.dpdk_version >= '20.11.0':
-            self.eal_para += " --force-max-simd-bitwidth=0"
-
+                self.eal_para += " --force-max-simd-bitwidth=0"
         valid_ports = [port for port in ports if self.tester.get_local_port(port) != -1]
         self.verify(
             len(valid_ports) >= 2, "Insufficient active dut_ports for speed testing")
-- 
1.8.3.1


^ permalink raw reply	[flat|nested] 7+ messages in thread

* [dts] [PATCH V2 4/4] tests/unit_tests_eal: modify code to adapt avx512
  2021-11-04  6:51 [dts] [PATCH V2 1/4] tests/kernelpf_iavf: modify code to adapt avx512 Xiang An
  2021-11-04  6:51 ` [dts] [PATCH V2 2/4] tests/vf_vlan: " Xiang An
  2021-11-04  6:51 ` [dts] [PATCH V2 3/4] tests/l3fwdacl: " Xiang An
@ 2021-11-04  6:51 ` Xiang An
  2021-11-05 13:22   ` Tu, Lijuan
  2 siblings, 1 reply; 7+ messages in thread
From: Xiang An @ 2021-11-04  6:51 UTC (permalink / raw)
  To: dts; +Cc: xiangx.an

Modify code to adapt rxmod avx512.

Signed-off-by: Xiang An <xiangx.an@intel.com>
---
 tests/TestSuite_unit_tests_eal.py | 14 ++++++++------
 1 file changed, 8 insertions(+), 6 deletions(-)

diff --git a/tests/TestSuite_unit_tests_eal.py b/tests/TestSuite_unit_tests_eal.py
index 8096183..9b44132 100644
--- a/tests/TestSuite_unit_tests_eal.py
+++ b/tests/TestSuite_unit_tests_eal.py
@@ -38,7 +38,7 @@ EAL autotest.
 
 import framework.utils as utils
 from framework.test_case import TestCase
-
+from framework.settings import load_global_setting, DPDK_RXMODE_SETTING
 #
 #
 # Test class.
@@ -457,13 +457,15 @@ class TestUnitTestsEal(TestCase):
         """
         Run acl autotest.
         """
-
-        eal_params = self.dut.create_eal_parameters()
-        self.test_app_cmdline += "--no-pci"
+        default_cores = '1S/4C/1T'
+        eal_params = self.dut.create_eal_parameters(other_eal_param='force-max-simd-bitwidth')
+        app_name = self.dut.apps_name['test']
+        test_app_cmdline = app_name + eal_params
+        test_app_cmdline += "--no-pci"
 
         if self.dut.dpdk_version >= '20.11.0':
-            self.test_app_cmdline += " --force-max-simd-bitwidth=0"
-        self.dut.send_expect(self.test_app_cmdline, "R.*T.*E.*>.*>", self.start_test_time)
+            test_app_cmdline += " --force-max-simd-bitwidth=0"
+        self.dut.send_expect(test_app_cmdline, "R.*T.*E.*>.*>", self.start_test_time)
         out = self.dut.send_expect("acl_autotest", "RTE>>", self.run_cmd_time)
         self.dut.send_expect("quit", "# ")
         self.verify("Test OK" in out, "Test failed")
-- 
1.8.3.1


^ permalink raw reply	[flat|nested] 7+ messages in thread

* Re: [dts] [PATCH V2 2/4] tests/vf_vlan: modify code to adapt avx512
  2021-11-04  6:51 ` [dts] [PATCH V2 2/4] tests/vf_vlan: " Xiang An
@ 2021-11-05 12:31   ` Tu, Lijuan
  0 siblings, 0 replies; 7+ messages in thread
From: Tu, Lijuan @ 2021-11-05 12:31 UTC (permalink / raw)
  To: An, XiangX, dts; +Cc: An, XiangX



> -----Original Message-----
> From: dts <dts-bounces@dpdk.org> On Behalf Of Xiang An
> Sent: 2021年11月4日 14:52
> To: dts@dpdk.org
> Cc: An, XiangX <xiangx.an@intel.com>
> Subject: [dts] [PATCH V2 2/4] tests/vf_vlan: modify code to adapt avx512
> 
> Based on dpdk commit:4b64ccb328 modify dts code to adapt avx512.
> 
> Signed-off-by: Xiang An <xiangx.an@intel.com>
> ---
>  tests/TestSuite_vf_vlan.py | 12 +++++++++---
>  1 file changed, 9 insertions(+), 3 deletions(-)
> 
> diff --git a/tests/TestSuite_vf_vlan.py b/tests/TestSuite_vf_vlan.py index
> 127eca3..ff3e13f 100644
> --- a/tests/TestSuite_vf_vlan.py
> +++ b/tests/TestSuite_vf_vlan.py
> @@ -35,7 +35,7 @@ import time
> 
>  from framework.packet import Packet
>  from framework.pmd_output import PmdOutput -from framework.settings
> import get_nic_name
> +from framework.settings import get_nic_name, load_global_setting,
> +DPDK_RXMODE_SETTING
>  from framework.test_case import TestCase  from framework.virt_common
> import VM
> 
> @@ -346,7 +346,10 @@ class TestVfVlan(TestCase):
>          self.vm0_dut_ports = self.vm_dut_0.get_ports('any')
> 
>          self.vm0_testpmd = PmdOutput(self.vm_dut_0)
> -        self.vm0_testpmd.start_testpmd(VM_CORES_MASK)
> +        if load_global_setting(DPDK_RXMODE_SETTING) == 'avx512':
> +            self.vm0_testpmd.start_testpmd(VM_CORES_MASK, '--enable-rx-cksum')
> +        else:
> +            self.vm0_testpmd.start_testpmd(VM_CORES_MASK)
>          self.vm0_testpmd.execute_cmd('set fwd rxonly')
>          self.vm0_testpmd.execute_cmd('set verbose 1')
>          self.vm0_testpmd.execute_cmd('vlan set strip on 0') @@ -417,7 +420,10
> @@ class TestVfVlan(TestCase):
>          if self.kdriver == "i40e":
>              self.vm0_testpmd.start_testpmd(VM_CORES_MASK, '')
>          else:
> -            self.vm0_testpmd.start_testpmd(VM_CORES_MASK)
> +            if load_global_setting(DPDK_RXMODE_SETTING) == 'avx512':
> +                self.vm0_testpmd.start_testpmd(VM_CORES_MASK, '--enable-rx-
> cksum')
> +            else:
> +                self.vm0_testpmd.start_testpmd(VM_CORES_MASK)

AVX512 should have the same behavior with other path,  is this a know issue in dpdk21.11 ? if not, please submit a bug to dpdk.

^ permalink raw reply	[flat|nested] 7+ messages in thread

* Re: [dts] [PATCH V2 4/4] tests/unit_tests_eal: modify code to adapt avx512
  2021-11-04  6:51 ` [dts] [PATCH V2 4/4] tests/unit_tests_eal: " Xiang An
@ 2021-11-05 13:22   ` Tu, Lijuan
  0 siblings, 0 replies; 7+ messages in thread
From: Tu, Lijuan @ 2021-11-05 13:22 UTC (permalink / raw)
  To: An, XiangX, dts; +Cc: An, XiangX



> -----Original Message-----
> From: dts <dts-bounces@dpdk.org> On Behalf Of Xiang An
> Sent: 2021年11月4日 14:52
> To: dts@dpdk.org
> Cc: An, XiangX <xiangx.an@intel.com>
> Subject: [dts] [PATCH V2 4/4] tests/unit_tests_eal: modify code to adapt avx512
> 
> Modify code to adapt rxmod avx512.
> 
> Signed-off-by: Xiang An <xiangx.an@intel.com>
> ---
>  tests/TestSuite_unit_tests_eal.py | 14 ++++++++------
>  1 file changed, 8 insertions(+), 6 deletions(-)
> 
> diff --git a/tests/TestSuite_unit_tests_eal.py b/tests/TestSuite_unit_tests_eal.py
> index 8096183..9b44132 100644
> --- a/tests/TestSuite_unit_tests_eal.py
> +++ b/tests/TestSuite_unit_tests_eal.py
> @@ -38,7 +38,7 @@ EAL autotest.
> 
>  import framework.utils as utils
>  from framework.test_case import TestCase
> -
> +from framework.settings import load_global_setting,
> DPDK_RXMODE_SETTING
>  #
>  #
>  # Test class.
> @@ -457,13 +457,15 @@ class TestUnitTestsEal(TestCase):
>          """
>          Run acl autotest.
>          """
> -
> -        eal_params = self.dut.create_eal_parameters()
> -        self.test_app_cmdline += "--no-pci"
> +        default_cores = '1S/4C/1T'

default_cores defined but not used.


^ permalink raw reply	[flat|nested] 7+ messages in thread

* Re: [dts] [PATCH V2 3/4] tests/l3fwdacl: modify code to adapt avx512
  2021-11-04  6:51 ` [dts] [PATCH V2 3/4] tests/l3fwdacl: " Xiang An
@ 2021-11-05 13:24   ` Tu, Lijuan
  0 siblings, 0 replies; 7+ messages in thread
From: Tu, Lijuan @ 2021-11-05 13:24 UTC (permalink / raw)
  To: An, XiangX, dts; +Cc: An, XiangX



> -----Original Message-----
> From: dts <dts-bounces@dpdk.org> On Behalf Of Xiang An
> Sent: 2021年11月4日 14:52
> To: dts@dpdk.org
> Cc: An, XiangX <xiangx.an@intel.com>
> Subject: [dts] [PATCH V2 3/4] tests/l3fwdacl: modify code to adapt avx512
> 
> Modify code to adapt rxmod avx512.
> 
> Signed-off-by: Xiang An <xiangx.an@intel.com>
> ---
>  tests/TestSuite_l3fwdacl.py | 6 +++---
>  1 file changed, 3 insertions(+), 3 deletions(-)
> 
> diff --git a/tests/TestSuite_l3fwdacl.py b/tests/TestSuite_l3fwdacl.py index
> 65c46b0..b812192 100644
> --- a/tests/TestSuite_l3fwdacl.py
> +++ b/tests/TestSuite_l3fwdacl.py
> @@ -40,6 +40,7 @@ import time
>  import framework.packet as packet
>  import framework.utils as utils
>  from framework.test_case import TestCase
> +from framework.settings import load_global_setting,
> DPDK_RXMODE_SETTING

Useless import

^ permalink raw reply	[flat|nested] 7+ messages in thread

end of thread, other threads:[~2021-11-05 13:24 UTC | newest]

Thread overview: 7+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-11-04  6:51 [dts] [PATCH V2 1/4] tests/kernelpf_iavf: modify code to adapt avx512 Xiang An
2021-11-04  6:51 ` [dts] [PATCH V2 2/4] tests/vf_vlan: " Xiang An
2021-11-05 12:31   ` Tu, Lijuan
2021-11-04  6:51 ` [dts] [PATCH V2 3/4] tests/l3fwdacl: " Xiang An
2021-11-05 13:24   ` Tu, Lijuan
2021-11-04  6:51 ` [dts] [PATCH V2 4/4] tests/unit_tests_eal: " Xiang An
2021-11-05 13:22   ` Tu, Lijuan

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).