[dts] [PATCH V2] tests/iavf_fdir: optimization script

[dts] [PATCH V2] tests/iavf_fdir: optimization script

[Jiale Song]

initialize pf. because pf is not initialized after case test, other case tests fail

Signed-off-by: Jiale Song <songx.jiale@intel.com>
---
 tests/TestSuite_iavf_fdir.py | 4 +---
 1 file changed, 1 insertion(+), 3 deletions(-)
 mode change 100755 => 100644 tests/TestSuite_iavf_fdir.py

diff --git a/tests/TestSuite_iavf_fdir.py b/tests/TestSuite_iavf_fdir.py
old mode 100755
new mode 100644
index fab7cc27..6abb75c5
--- a/tests/TestSuite_iavf_fdir.py
+++ b/tests/TestSuite_iavf_fdir.py
@@ -7593,6 +7593,7 @@ class TestIAVFFdir(TestCase):
         """
         Run before each test case.
         """
+        self.dut.restore_interfaces_linux()
         self.setup_2pf_4vf_env()
         time.sleep(1)
         self.launch_testpmd()
@@ -8344,7 +8345,6 @@ class TestIAVFFdir(TestCase):
         create same rules on pf and vf, no conflict
         """
         self.dut.kill_all()
-        self.setup_2pf_4vf_env()
         self.session_secondary = self.dut.new_session()
         self.session_third = self.dut.new_session()
 
@@ -8496,7 +8496,6 @@ class TestIAVFFdir(TestCase):
         create same input set but different action rules on pf and vf, no conflict.
         """
         self.dut.kill_all()
-        self.setup_2pf_4vf_env()
         self.session_secondary = self.dut.new_session()
         self.session_third = self.dut.new_session()
 
@@ -9810,7 +9809,6 @@ class TestIAVFFdir(TestCase):
         
     def tear_down(self):
         # destroy all flow rule on port 0
-        self.dut.kill_all()
         self.destroy_env()
         if getattr(self, 'session_secondary', None):
             self.dut.close_session(self.session_secondary)
-- 
2.17.1

Re: [dts] [PATCH V2] tests/iavf_fdir: optimization script

[Tu, Lijuan]

> -----Original Message-----
> From: dts <dts-bounces@dpdk.org> On Behalf Of Jiale Song
> Sent: 2021年11月8日 13:10
> To: dts@dpdk.org
> Cc: Jiale, SongX <songx.jiale@intel.com>
> Subject: [dts] [PATCH V2] tests/iavf_fdir: optimization script
> 
> initialize pf. because pf is not initialized after case test, other case tests fail
> 
> Signed-off-by: Jiale Song <songx.jiale@intel.com>
> ---
>  tests/TestSuite_iavf_fdir.py | 4 +---
>  1 file changed, 1 insertion(+), 3 deletions(-)  mode change 100755 => 100644
> tests/TestSuite_iavf_fdir.py
> 
> diff --git a/tests/TestSuite_iavf_fdir.py b/tests/TestSuite_iavf_fdir.py old mode
> 100755 new mode 100644 index fab7cc27..6abb75c5
> --- a/tests/TestSuite_iavf_fdir.py
> +++ b/tests/TestSuite_iavf_fdir.py
> @@ -7593,6 +7593,7 @@ class TestIAVFFdir(TestCase):
>          """
>          Run before each test case.
>          """
> +        self.dut.restore_interfaces_linux()
>          self.setup_2pf_4vf_env()
>          time.sleep(1)
>          self.launch_testpmd()
> @@ -8344,7 +8345,6 @@ class TestIAVFFdir(TestCase):
>          create same rules on pf and vf, no conflict
>          """
>          self.dut.kill_all()
> -        self.setup_2pf_4vf_env()
Why still call kill_all here ?
>          self.session_secondary = self.dut.new_session()
>          self.session_third = self.dut.new_session()
> 
> @@ -8496,7 +8496,6 @@ class TestIAVFFdir(TestCase):
>          create same input set but different action rules on pf and vf, no conflict.
>          """
>          self.dut.kill_all()
> -        self.setup_2pf_4vf_env()
>          self.session_secondary = self.dut.new_session()
>          self.session_third = self.dut.new_session()
> 
> @@ -9810,7 +9809,6 @@ class TestIAVFFdir(TestCase):
> 
>      def tear_down(self):
>          # destroy all flow rule on port 0
> -        self.dut.kill_all()
>          self.destroy_env()
>          if getattr(self, 'session_secondary', None):
>              self.dut.close_session(self.session_secondary)
> --
> 2.17.1