test suite reviews and discussions
 help / color / mirror / Atom feed
From: Thomas Monjalon <thomas@monjalon.net>
To: "Juraj Linkeš" <juraj.linkes@pantheon.tech>,
	"lijuan.tu@intel.com" <lijuan.tu@intel.com>,
	"ohilyard@iol.unh.edu" <ohilyard@iol.unh.edu>,
	"Honnappa Nagarahalli" <Honnappa.Nagarahalli@arm.com>
Cc: "dts@dpdk.org" <dts@dpdk.org>,
	David Marchand <david.marchand@redhat.com>, nd <nd@arm.com>,
	"bruce.richardson@intel.com" <bruce.richardson@intel.com>
Subject: Re: [PATCH v1] cleanup: rename base classes
Date: Tue, 17 May 2022 08:48:47 +0200	[thread overview]
Message-ID: <16365457.Ash8RoxBsO@thomas> (raw)
In-Reply-To: <DBAPR08MB58146ACE761EB56E11656B6598CE9@DBAPR08MB5814.eurprd08.prod.outlook.com>

> > The current naming of the base elements DTS works with is a bit
> > confusing, which this patch attemps to ameliorate. The basic elements
> > could be divided into and described in short as follows:
> > * A node: a broad term encompassing a host where any of the DTS elements
> > are present. This could be a physical or virtualized server or a
> > container.

OK

> > * The control node: the host where DTS runs

OK

> > * An SUT (system under test) node: This is where DPDK along with the
> > tested hardware resides. The system comprises DPDK and the hardware.

Is there any difference between a SUT and a "tested node"?

> > * A traffic generator node: The node where the traffic generator is
> > present, such as Trex, Scapy or a hardware traffic generator (e.g. IXIA)

OK

> > All references to DUT were removed. This is because it was used to mean
> > both the server where DPDK/NIC are present and the DUT (device under
> > test, i.e. the NIC) in different contexts. Where applicable, DUT was
> > replaced with NIC and the rest were replaced with SUT. With this change,
> > it's clear what's meant and the abbreviations are very different, which
> > removes that layer of confusion.

"NIC" does not mean it is a device under test.
Also we could have other kind of devices under test, like crypto cards.

> > Rename the following classes:
> > Crb -> Node
> > Dut -> SutNode
> > Tester -> TrafficGeneratorNode
> > DPDKdut -> DpdkSut
> > DPDKtester -> DpdkTrafficGenerator
> > VirtDut -> VirtSut
> > CrbsConf -> TopologyConf
> > PktgenConf -> PacketGeneratorConf

I think you need to choose between "TrafficGenerator" and "PacketGenerator".



  reply	other threads:[~2022-05-17  6:49 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-05-16 13:33 Juraj Linkeš
2022-05-17  4:53 ` Honnappa Nagarahalli
2022-05-17  6:48   ` Thomas Monjalon [this message]
2022-05-17 23:01     ` Honnappa Nagarahalli
2022-05-18 14:35       ` Juraj Linkeš
2022-05-18 15:38         ` Honnappa Nagarahalli

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=16365457.Ash8RoxBsO@thomas \
    --to=thomas@monjalon.net \
    --cc=Honnappa.Nagarahalli@arm.com \
    --cc=bruce.richardson@intel.com \
    --cc=david.marchand@redhat.com \
    --cc=dts@dpdk.org \
    --cc=juraj.linkes@pantheon.tech \
    --cc=lijuan.tu@intel.com \
    --cc=nd@arm.com \
    --cc=ohilyard@iol.unh.edu \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).