test suite reviews and discussions
 help / color / mirror / Atom feed
From: "Yu.Jiang" <yux.jiang@intel.com>
To: yuan.peng@intel.com, dts@dpdk.org
Cc: Yu Jiang <yux.jiang@intel.com>
Subject: [dts][PATCH V1 2/2] tests/kernelpf_iavf: remove 2 duplicated vf jumboframe cases
Date: Wed,  8 Jun 2022 15:09:55 +0800	[thread overview]
Message-ID: <1654672195-6189-3-git-send-email-yux.jiang@intel.com> (raw)
In-Reply-To: <1654672195-6189-1-git-send-email-yux.jiang@intel.com>

From: Yu Jiang <yux.jiang@intel.com>

VF with/without jumboframe are duplicated to vf_jumboframe suite,
 so remove the two cases

Signed-off-by: Yu Jiang <yux.jiang@intel.com>
---
 tests/TestSuite_kernelpf_iavf.py | 72 --------------------------------
 1 file changed, 72 deletions(-)

diff --git a/tests/TestSuite_kernelpf_iavf.py b/tests/TestSuite_kernelpf_iavf.py
index bb20e687..811e55ee 100644
--- a/tests/TestSuite_kernelpf_iavf.py
+++ b/tests/TestSuite_kernelpf_iavf.py
@@ -568,78 +568,6 @@ class TestKernelpfIavf(TestCase):
         else:
             self.verify(len(receive_pkt) == 1, "Failed to received vlan packet!!!")
 
-    def test_vf_without_jumboframe(self):
-        self.tester.send_expect(
-            "ifconfig %s mtu %s" % (self.tester_intf, ETHER_JUMBO_FRAME_MTU), "#"
-        )
-
-        self.vm_testpmd.start_testpmd("all")
-        self.vm_testpmd.execute_cmd("set fwd mac")
-        self.vm_testpmd.execute_cmd("start")
-        self.jumboframes_send_packet(ETHER_STANDARD_MTU - 1, True)
-        self.jumboframes_send_packet(ETHER_STANDARD_MTU + 1 + 4 + 4, False)
-        self.tester.send_expect(
-            "ifconfig %s mtu %s" % (self.tester_intf, ETHER_STANDARD_MTU), "#"
-        )
-
-    def test_vf_with_jumboframe(self):
-        self.tester.send_expect(
-            "ifconfig %s mtu %d" % (self.tester_intf, ETHER_JUMBO_FRAME_MTU), "#"
-        )
-        conf_pkt_len = 3000
-        self.vm_testpmd.start_testpmd(
-            "all",
-            "--max-pkt-len=%d --port-topology=loop --tx-offloads=0x8000" % conf_pkt_len,
-        )
-        self.vm_testpmd.execute_cmd("set fwd mac")
-        self.vm_testpmd.execute_cmd("start")
-        self.jumboframes_send_packet(conf_pkt_len - 1, True)
-        self.jumboframes_send_packet(conf_pkt_len + 1, False)
-        self.tester.send_expect(
-            "ifconfig %s mtu %d" % (self.tester_intf, ETHER_STANDARD_MTU), "#"
-        )
-
-    def jumboframes_send_packet(self, pktsize, received=True):
-        """
-        Send 1 packet to portid
-        """
-        tx_pkts_ori, _, tx_bytes_ori = [
-            int(_) for _ in self.jumboframes_get_stat(self.vm_port, "tx")
-        ]
-        rx_pkts_ori, rx_err_ori, rx_bytes_ori = [
-            int(_) for _ in self.jumboframes_get_stat(self.vm_port, "rx")
-        ]
-
-        pkt = Packet(pkt_type="UDP", pkt_len=pktsize)
-        pkt.config_layer("ether", {"dst": self.vf_mac, "src": self.tester_mac})
-        self.vm_testpmd.execute_cmd("clear port stats all")
-        pkt.send_pkt(self.tester, tx_port=self.tester_intf)
-
-        time.sleep(1)
-
-        tx_pkts, _, tx_bytes = [
-            int(_) for _ in self.jumboframes_get_stat(self.port, "tx")
-        ]
-        rx_pkts, rx_err, rx_bytes = [
-            int(_) for _ in self.jumboframes_get_stat(self.vm_port, "rx")
-        ]
-
-        tx_pkts -= tx_pkts_ori
-        tx_bytes -= tx_bytes_ori
-        rx_pkts -= rx_pkts_ori
-        rx_bytes -= rx_bytes_ori
-        rx_err -= rx_err_ori
-        if received:
-            self.verify(
-                (rx_pkts == 1) and (tx_pkts == 1), "Packet forward assert error"
-            )
-
-            self.verify(rx_bytes + 4 == pktsize, "Rx packet size should be packet size")
-
-            self.verify(tx_bytes + 4 == pktsize, "Tx packet size should be packet size")
-        else:
-            self.verify(rx_err == 1 or tx_pkts == -1, "Packet drop assert error")
-
     def test_vf_rss(self):
         rss_type = ["ip", "tcp", "udp"]
         self.vm_testpmd.start_testpmd("all", "--txq=4 --rxq=4")
-- 
2.25.1


  parent reply	other threads:[~2022-06-08  7:10 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-06-08  7:09 [dts][PATCH V1 0/2] kernelpf_iavf: " Yu.Jiang
2022-06-08  7:09 ` [dts][PATCH V1 1/2] test_plans/kernelpf_iavf: " Yu.Jiang
2022-06-08  7:09 ` Yu.Jiang [this message]
2022-06-15  9:12   ` [dts][PATCH V1 2/2] tests/kernelpf_iavf: " lijuan.tu

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1654672195-6189-3-git-send-email-yux.jiang@intel.com \
    --to=yux.jiang@intel.com \
    --cc=dts@dpdk.org \
    --cc=yuan.peng@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).