test suite reviews and discussions
 help / color / mirror / Atom feed
* [dts][PATCH V1 0/2] kernelpf_iavf: remove 2 duplicated vf jumboframe cases
@ 2022-06-08  7:09 Yu.Jiang
  2022-06-08  7:09 ` [dts][PATCH V1 1/2] test_plans/kernelpf_iavf: " Yu.Jiang
  2022-06-08  7:09 ` [dts][PATCH V1 2/2] tests/kernelpf_iavf: " Yu.Jiang
  0 siblings, 2 replies; 4+ messages in thread
From: Yu.Jiang @ 2022-06-08  7:09 UTC (permalink / raw)
  To: yuan.peng, dts; +Cc: Yu Jiang

From: Yu Jiang <yux.jiang@intel.com>

kernelpf_iavf: remove 2 duplicated vf jumboframe cases

Yu Jiang (2):
  test_plans/kernelpf_iavf: remove duplicated vf jumboframe case
  tests/kernelpf_iavf: remove duplicated vf jumboframe case

 test_plans/kernelpf_iavf_test_plan.rst | 39 --------------
 tests/TestSuite_kernelpf_iavf.py       | 72 --------------------------
 2 files changed, 111 deletions(-)

-- 
2.25.1


^ permalink raw reply	[flat|nested] 4+ messages in thread

* [dts][PATCH V1 1/2] test_plans/kernelpf_iavf: remove 2 duplicated vf jumboframe cases
  2022-06-08  7:09 [dts][PATCH V1 0/2] kernelpf_iavf: remove 2 duplicated vf jumboframe cases Yu.Jiang
@ 2022-06-08  7:09 ` Yu.Jiang
  2022-06-08  7:09 ` [dts][PATCH V1 2/2] tests/kernelpf_iavf: " Yu.Jiang
  1 sibling, 0 replies; 4+ messages in thread
From: Yu.Jiang @ 2022-06-08  7:09 UTC (permalink / raw)
  To: yuan.peng, dts; +Cc: Yu Jiang

From: Yu Jiang <yux.jiang@intel.com>

 VF with/without jumboframe are duplicated to vf_jumboframe suite,
 so remove the two cases

Signed-off-by: Yu Jiang <yux.jiang@intel.com>
---
 test_plans/kernelpf_iavf_test_plan.rst | 39 --------------------------
 1 file changed, 39 deletions(-)

diff --git a/test_plans/kernelpf_iavf_test_plan.rst b/test_plans/kernelpf_iavf_test_plan.rst
index 6f65a529..e584a358 100644
--- a/test_plans/kernelpf_iavf_test_plan.rst
+++ b/test_plans/kernelpf_iavf_test_plan.rst
@@ -306,45 +306,6 @@ Send packets with vlan tag::
 Check that out from VF contains the vlan tag.
 
 
-Test case: VF without jumboframe
-================================
-
-Ensure tester's port supports sending jumboframe::
-
-    ifconfig 'tester interface' mtu 9000
-
-Launch testpmd for VF port without enabling jumboframe option::
-
-    ./<build_target>/app/dpdk-testpmd -c f -n 4 -- -i
-
-    testpmd> set fwd mac
-    testpmd> start
-
-Check packet less than the standard maximum frame (1518) can be received.
-
-Check packet more than the standard maximum frame (1518) can not be received.
-
-Test case: VF with jumboframe
-=============================
-
-Ensure tester's port supports sending jumboframe::
-
-    ifconfig 'tester interface' mtu 9000
-
-Launch testpmd for VF port with jumboframe option::
-
-    ./<build_target>/app/dpdk-testpmd -c f -n 4 -- -i --max-pkt-len=3000
-
-    testpmd> set fwd mac
-    testpmd> start
-
-Check that packet length larger than the standard maximum frame (1518) and
-lower or equal to the maximum frame length can be received.
-
-Check that packet length larger than the configured maximum packet can not
-be received.
-
-
 Test case: VF RSS
 =================
 
-- 
2.25.1


^ permalink raw reply	[flat|nested] 4+ messages in thread

* [dts][PATCH V1 2/2] tests/kernelpf_iavf: remove 2 duplicated vf jumboframe cases
  2022-06-08  7:09 [dts][PATCH V1 0/2] kernelpf_iavf: remove 2 duplicated vf jumboframe cases Yu.Jiang
  2022-06-08  7:09 ` [dts][PATCH V1 1/2] test_plans/kernelpf_iavf: " Yu.Jiang
@ 2022-06-08  7:09 ` Yu.Jiang
  2022-06-15  9:12   ` lijuan.tu
  1 sibling, 1 reply; 4+ messages in thread
From: Yu.Jiang @ 2022-06-08  7:09 UTC (permalink / raw)
  To: yuan.peng, dts; +Cc: Yu Jiang

From: Yu Jiang <yux.jiang@intel.com>

VF with/without jumboframe are duplicated to vf_jumboframe suite,
 so remove the two cases

Signed-off-by: Yu Jiang <yux.jiang@intel.com>
---
 tests/TestSuite_kernelpf_iavf.py | 72 --------------------------------
 1 file changed, 72 deletions(-)

diff --git a/tests/TestSuite_kernelpf_iavf.py b/tests/TestSuite_kernelpf_iavf.py
index bb20e687..811e55ee 100644
--- a/tests/TestSuite_kernelpf_iavf.py
+++ b/tests/TestSuite_kernelpf_iavf.py
@@ -568,78 +568,6 @@ class TestKernelpfIavf(TestCase):
         else:
             self.verify(len(receive_pkt) == 1, "Failed to received vlan packet!!!")
 
-    def test_vf_without_jumboframe(self):
-        self.tester.send_expect(
-            "ifconfig %s mtu %s" % (self.tester_intf, ETHER_JUMBO_FRAME_MTU), "#"
-        )
-
-        self.vm_testpmd.start_testpmd("all")
-        self.vm_testpmd.execute_cmd("set fwd mac")
-        self.vm_testpmd.execute_cmd("start")
-        self.jumboframes_send_packet(ETHER_STANDARD_MTU - 1, True)
-        self.jumboframes_send_packet(ETHER_STANDARD_MTU + 1 + 4 + 4, False)
-        self.tester.send_expect(
-            "ifconfig %s mtu %s" % (self.tester_intf, ETHER_STANDARD_MTU), "#"
-        )
-
-    def test_vf_with_jumboframe(self):
-        self.tester.send_expect(
-            "ifconfig %s mtu %d" % (self.tester_intf, ETHER_JUMBO_FRAME_MTU), "#"
-        )
-        conf_pkt_len = 3000
-        self.vm_testpmd.start_testpmd(
-            "all",
-            "--max-pkt-len=%d --port-topology=loop --tx-offloads=0x8000" % conf_pkt_len,
-        )
-        self.vm_testpmd.execute_cmd("set fwd mac")
-        self.vm_testpmd.execute_cmd("start")
-        self.jumboframes_send_packet(conf_pkt_len - 1, True)
-        self.jumboframes_send_packet(conf_pkt_len + 1, False)
-        self.tester.send_expect(
-            "ifconfig %s mtu %d" % (self.tester_intf, ETHER_STANDARD_MTU), "#"
-        )
-
-    def jumboframes_send_packet(self, pktsize, received=True):
-        """
-        Send 1 packet to portid
-        """
-        tx_pkts_ori, _, tx_bytes_ori = [
-            int(_) for _ in self.jumboframes_get_stat(self.vm_port, "tx")
-        ]
-        rx_pkts_ori, rx_err_ori, rx_bytes_ori = [
-            int(_) for _ in self.jumboframes_get_stat(self.vm_port, "rx")
-        ]
-
-        pkt = Packet(pkt_type="UDP", pkt_len=pktsize)
-        pkt.config_layer("ether", {"dst": self.vf_mac, "src": self.tester_mac})
-        self.vm_testpmd.execute_cmd("clear port stats all")
-        pkt.send_pkt(self.tester, tx_port=self.tester_intf)
-
-        time.sleep(1)
-
-        tx_pkts, _, tx_bytes = [
-            int(_) for _ in self.jumboframes_get_stat(self.port, "tx")
-        ]
-        rx_pkts, rx_err, rx_bytes = [
-            int(_) for _ in self.jumboframes_get_stat(self.vm_port, "rx")
-        ]
-
-        tx_pkts -= tx_pkts_ori
-        tx_bytes -= tx_bytes_ori
-        rx_pkts -= rx_pkts_ori
-        rx_bytes -= rx_bytes_ori
-        rx_err -= rx_err_ori
-        if received:
-            self.verify(
-                (rx_pkts == 1) and (tx_pkts == 1), "Packet forward assert error"
-            )
-
-            self.verify(rx_bytes + 4 == pktsize, "Rx packet size should be packet size")
-
-            self.verify(tx_bytes + 4 == pktsize, "Tx packet size should be packet size")
-        else:
-            self.verify(rx_err == 1 or tx_pkts == -1, "Packet drop assert error")
-
     def test_vf_rss(self):
         rss_type = ["ip", "tcp", "udp"]
         self.vm_testpmd.start_testpmd("all", "--txq=4 --rxq=4")
-- 
2.25.1


^ permalink raw reply	[flat|nested] 4+ messages in thread

* [dts][PATCH V1 2/2] tests/kernelpf_iavf: remove 2 duplicated vf jumboframe cases
  2022-06-08  7:09 ` [dts][PATCH V1 2/2] tests/kernelpf_iavf: " Yu.Jiang
@ 2022-06-15  9:12   ` lijuan.tu
  0 siblings, 0 replies; 4+ messages in thread
From: lijuan.tu @ 2022-06-15  9:12 UTC (permalink / raw)
  To: yuan.peng, dts, Yu.Jiang; +Cc: Yu Jiang

On Wed,  8 Jun 2022 15:09:55 +0800, "Yu.Jiang" <yux.jiang@intel.com> wrote:
> From: Yu Jiang <yux.jiang@intel.com>
> 
> VF with/without jumboframe are duplicated to vf_jumboframe suite,
>  so remove the two cases
> 
> Signed-off-by: Yu Jiang <yux.jiang@intel.com>


Series applied, thanks

^ permalink raw reply	[flat|nested] 4+ messages in thread

end of thread, other threads:[~2022-06-15  9:12 UTC | newest]

Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2022-06-08  7:09 [dts][PATCH V1 0/2] kernelpf_iavf: remove 2 duplicated vf jumboframe cases Yu.Jiang
2022-06-08  7:09 ` [dts][PATCH V1 1/2] test_plans/kernelpf_iavf: " Yu.Jiang
2022-06-08  7:09 ` [dts][PATCH V1 2/2] tests/kernelpf_iavf: " Yu.Jiang
2022-06-15  9:12   ` lijuan.tu

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).