test suite reviews and discussions
 help / color / mirror / Atom feed
* [dts] [PATCH V2] tests/virtio_event_idx_interrupt: optimize the code
@ 2021-08-02  7:20 Wei Ling
  2021-08-02  7:38 ` Ling, WeiX
  0 siblings, 1 reply; 4+ messages in thread
From: Wei Ling @ 2021-08-02  7:20 UTC (permalink / raw)
  To: dts; +Cc: Wei Ling

v1:
Add bind_dev parameter to replace restore_interfaces in start_vm
method to decide bind the NIC port to dpdk in vm or not.

v2:
Add set_target parameter because this suite no need build dpdk in vm.

Signed-off-by: Wei Ling <weix.ling@intel.com>
---
 tests/TestSuite_virtio_event_idx_interrupt.py | 5 ++---
 1 file changed, 2 insertions(+), 3 deletions(-)

diff --git a/tests/TestSuite_virtio_event_idx_interrupt.py b/tests/TestSuite_virtio_event_idx_interrupt.py
index 37634f05..041658e9 100644
--- a/tests/TestSuite_virtio_event_idx_interrupt.py
+++ b/tests/TestSuite_virtio_event_idx_interrupt.py
@@ -134,7 +134,7 @@ class TestVirtioIdxInterrupt(TestCase):
         self.vhost.send_expect(command_line, "testpmd> ", 30)
         self.vhost.send_expect("start", "testpmd> ", 30)
 
-    def start_vms(self, packed=False, mode=False):
+    def start_vms(self, packed=False, mode=False, set_target=False, bind_dev=False):
         """
         start qemus
         """
@@ -155,12 +155,11 @@ class TestVirtioIdxInterrupt(TestCase):
         vm_params['opt_settings'] = opt_args
         self.vm.set_vm_device(**vm_params)
         try:
-            self.vm_dut = self.vm.start()
+            self.vm_dut = self.vm.start(set_target=set_target, bind_dev=bind_dev)
             if self.vm_dut is None:
                 raise Exception("Set up VM ENV failed")
         except Exception as e:
             self.logger.error("ERROR: Failure for %s" % str(e))
-        self.vm_dut.restore_interfaces()
 
     def config_virito_net_in_vm(self):
         """
-- 
2.25.1


^ permalink raw reply	[flat|nested] 4+ messages in thread

* Re: [dts] [PATCH V2] tests/virtio_event_idx_interrupt: optimize the code
  2021-08-02  7:20 [dts] [PATCH V2] tests/virtio_event_idx_interrupt: optimize the code Wei Ling
@ 2021-08-02  7:38 ` Ling, WeiX
  2021-08-13  0:18   ` Wang, Yinan
  0 siblings, 1 reply; 4+ messages in thread
From: Ling, WeiX @ 2021-08-02  7:38 UTC (permalink / raw)
  To: dts

> -----Original Message-----
> From: Ling, WeiX <weix.ling@intel.com>
> Sent: Monday, August 2, 2021 03:21 PM
> To: dts@dpdk.org
> Cc: Ling, WeiX <weix.ling@intel.com>
> Subject: [dts][PATCH V2] tests/virtio_event_idx_interrupt: optimize the
> code
> 
Tested-by: Wei Ling <weix.ling@intel.com>

^ permalink raw reply	[flat|nested] 4+ messages in thread

* Re: [dts] [PATCH V2] tests/virtio_event_idx_interrupt: optimize the code
  2021-08-02  7:38 ` Ling, WeiX
@ 2021-08-13  0:18   ` Wang, Yinan
  2021-10-09  8:18     ` Tu, Lijuan
  0 siblings, 1 reply; 4+ messages in thread
From: Wang, Yinan @ 2021-08-13  0:18 UTC (permalink / raw)
  To: Ling, WeiX, dts

Acked-by:  Yinan Wang <yinan.wang@intel.com>

> -----Original Message-----
> From: dts <dts-bounces@dpdk.org> On Behalf Of Ling, WeiX
> Sent: 2021?8?2? 15:38
> To: dts@dpdk.org
> Subject: Re: [dts] [PATCH V2] tests/virtio_event_idx_interrupt: optimize
> the code
> 
> > -----Original Message-----
> > From: Ling, WeiX <weix.ling@intel.com>
> > Sent: Monday, August 2, 2021 03:21 PM
> > To: dts@dpdk.org
> > Cc: Ling, WeiX <weix.ling@intel.com>
> > Subject: [dts][PATCH V2] tests/virtio_event_idx_interrupt: optimize the
> > code
> >
> Tested-by: Wei Ling <weix.ling@intel.com>

^ permalink raw reply	[flat|nested] 4+ messages in thread

* Re: [dts] [PATCH V2] tests/virtio_event_idx_interrupt: optimize the code
  2021-08-13  0:18   ` Wang, Yinan
@ 2021-10-09  8:18     ` Tu, Lijuan
  0 siblings, 0 replies; 4+ messages in thread
From: Tu, Lijuan @ 2021-10-09  8:18 UTC (permalink / raw)
  To: Wang, Yinan, Ling, WeiX, dts



> -----Original Message-----
> From: dts <dts-bounces@dpdk.org> On Behalf Of Wang, Yinan
> Sent: 2021年8月13日 8:18
> To: Ling, WeiX <weix.ling@intel.com>; dts@dpdk.org
> Subject: Re: [dts] [PATCH V2] tests/virtio_event_idx_interrupt: optimize the
> code
> 
> Acked-by:  Yinan Wang <yinan.wang@intel.com>
> 
> > -----Original Message-----
> > From: dts <dts-bounces@dpdk.org> On Behalf Of Ling, WeiX
> > Sent: 2021?8?2? 15:38
> > To: dts@dpdk.org
> > Subject: Re: [dts] [PATCH V2] tests/virtio_event_idx_interrupt:
> > optimize the code
> >
> > > -----Original Message-----
> > > From: Ling, WeiX <weix.ling@intel.com>
> > > Sent: Monday, August 2, 2021 03:21 PM
> > > To: dts@dpdk.org
> > > Cc: Ling, WeiX <weix.ling@intel.com>
> > > Subject: [dts][PATCH V2] tests/virtio_event_idx_interrupt: optimize
> > > the code
> > >
> > Tested-by: Wei Ling <weix.ling@intel.com>

Applied

^ permalink raw reply	[flat|nested] 4+ messages in thread

end of thread, other threads:[~2021-10-09  8:18 UTC | newest]

Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-08-02  7:20 [dts] [PATCH V2] tests/virtio_event_idx_interrupt: optimize the code Wei Ling
2021-08-02  7:38 ` Ling, WeiX
2021-08-13  0:18   ` Wang, Yinan
2021-10-09  8:18     ` Tu, Lijuan

test suite reviews and discussions

This inbox may be cloned and mirrored by anyone:

	git clone --mirror http://inbox.dpdk.org/dts/0 dts/git/0.git

	# If you have public-inbox 1.1+ installed, you may
	# initialize and index your mirror using the following commands:
	public-inbox-init -V2 dts dts/ http://inbox.dpdk.org/dts \
		dts@dpdk.org
	public-inbox-index dts

Example config snippet for mirrors.
Newsgroup available over NNTP:
	nntp://inbox.dpdk.org/inbox.dpdk.dts


AGPL code for this site: git clone https://public-inbox.org/public-inbox.git