test suite reviews and discussions
 help / color / mirror / Atom feed
* Re: [dts] [PATCH V2] tests/cvl_advanced_rss_pppoe:remove destroy rule test steps
  2021-08-05 18:23 [dts] [PATCH V2] tests/cvl_advanced_rss_pppoe:remove destroy rule test steps Zhimin Huang
@ 2021-08-05  9:55 ` Huang, ZhiminX
  2021-09-29  6:53   ` Tu, Lijuan
  2021-08-10  5:55 ` Tu, Lijuan
  1 sibling, 1 reply; 4+ messages in thread
From: Huang, ZhiminX @ 2021-08-05  9:55 UTC (permalink / raw)
  To: dts

[-- Attachment #1: Type: text/plain, Size: 344 bytes --]


> -----Original Message-----
> From: Huang, ZhiminX <zhiminx.huang@intel.com>
> Sent: Friday, August 6, 2021 2:23 AM
> To: dts@dpdk.org
> Cc: Huang, ZhiminX <zhiminx.huang@intel.com>
> Subject: [dts] [PATCH V2] tests/cvl_advanced_rss_pppoe:remove destroy
> rule test steps
> 

Tested-by: Zhimin Huang <zhiminx.huang@intel.com >



[-- Attachment #2: Advanced_rss_pppoe.log --]
[-- Type: application/octet-stream, Size: 50029 bytes --]

^ permalink raw reply	[flat|nested] 4+ messages in thread

* [dts] [PATCH V2] tests/cvl_advanced_rss_pppoe:remove destroy rule test steps
@ 2021-08-05 18:23 Zhimin Huang
  2021-08-05  9:55 ` Huang, ZhiminX
  2021-08-10  5:55 ` Tu, Lijuan
  0 siblings, 2 replies; 4+ messages in thread
From: Zhimin Huang @ 2021-08-05 18:23 UTC (permalink / raw)
  To: dts; +Cc: Zhimin Huang

*.dpdk cannot guarantee the operation after destroy the rule,
so remove destroy rule test steps.

Signed-off-by: Zhimin Huang <zhiminx.huang@intel.com>
---
v2:fix typo issue

 .../cvl_advanced_rss_pppoe_test_plan.rst      | 16 ---------------
 tests/TestSuite_cvl_advanced_rss_pppoe.py     | 20 -------------------
 2 files changed, 36 deletions(-)

diff --git a/test_plans/cvl_advanced_rss_pppoe_test_plan.rst b/test_plans/cvl_advanced_rss_pppoe_test_plan.rst
index a8cb7171..e209e0d4 100644
--- a/test_plans/cvl_advanced_rss_pppoe_test_plan.rst
+++ b/test_plans/cvl_advanced_rss_pppoe_test_plan.rst
@@ -4278,14 +4278,6 @@ Test case: MAC_PPPOE_IPV4_UDP_PAY_symmetric
 
      check the hash values of the two packets are different.
 
-6. destroy the rule::
-
-     testpmd> flow destroy 0 rule 0
-     testpmd> flow list 0
-
-   check the rule not exists in the list.
-   repeat step 4, swap the values of [Source IP] and [Dest IP], [Source Port] and [Dest Port],
-   check the hash value is changed.
 
 Test case: MAC_PPPOE_IPV4_TCP_PAY_symmetric
 ===========================================
@@ -4540,14 +4532,6 @@ Test case: MAC_PPPOE_IPV6_UDP_PAY_symmetric
 
      check the hash values of the two packets are different.
 
-6. destroy the rule::
-
-     testpmd> flow destroy 0 rule 0
-     testpmd> flow list 0
-
-   check the rule not exists in the list.
-   repeat step 3, swap the values of [Source IP] and [Dest IP], [Source Port] and [Dest Port],
-   check the hash values are changed.
 
 Test case: MAC_PPPOE_IPV6_TCP_PAY_symmetric
 ===========================================
diff --git a/tests/TestSuite_cvl_advanced_rss_pppoe.py b/tests/TestSuite_cvl_advanced_rss_pppoe.py
index 2d3e226e..3952bbf0 100644
--- a/tests/TestSuite_cvl_advanced_rss_pppoe.py
+++ b/tests/TestSuite_cvl_advanced_rss_pppoe.py
@@ -3780,16 +3780,6 @@ mac_pppoe_ipv6_udp_pay_symmetric = {
             'action': {'check_hash_different': 'mac_ipv6_udp_pay_mismatch'},
         },
     ],
-    'post-test': [
-        {
-            'send_packet': mac_pppoe_ipv6_udp_pay_symmetric_packets['match']['mac_pppoe_ipv6_udp_pay'][0],
-            'action': {'save_hash': 'mac_pppoe_ipv6_udp_pay_match_post'},
-        },
-        {
-            'send_packet': mac_pppoe_ipv6_udp_pay_symmetric_packets['match']['mac_pppoe_ipv6_udp_pay'][1:],
-            'action': {'check_hash_different': 'mac_pppoe_ipv6_udp_pay_match_post'},
-        },
-    ],
 }
 
 mac_pppoe_ipv6_pay_symmetric_packets = {
@@ -4063,16 +4053,6 @@ mac_pppoe_ipv4_udp_pay_symmetric = {
             'action': {'check_hash_different': 'mac_ipv4_udp_pay_mismatch'},
         },
     ],
-    'post-test': [
-        {
-            'send_packet': mac_pppoe_ipv4_udp_pay_symmetric_packets['match']['mac_pppoe_ipv4_udp_pay'][0],
-            'action': {'save_hash': 'mac_ipv4_udp_pay_match_post'},
-        },
-        {
-            'send_packet': mac_pppoe_ipv4_udp_pay_symmetric_packets['match']['mac_pppoe_ipv4_udp_pay'][1:],
-            'action': {'check_hash_different': 'mac_ipv4_udp_pay_match_post'},
-        },
-    ],
 }
 
 mac_pppoe_ipv4_tcp_pay_symmetric_packets = {
-- 
2.17.1


^ permalink raw reply	[flat|nested] 4+ messages in thread

* Re: [dts] [PATCH V2] tests/cvl_advanced_rss_pppoe:remove destroy rule test steps
  2021-08-05 18:23 [dts] [PATCH V2] tests/cvl_advanced_rss_pppoe:remove destroy rule test steps Zhimin Huang
  2021-08-05  9:55 ` Huang, ZhiminX
@ 2021-08-10  5:55 ` Tu, Lijuan
  1 sibling, 0 replies; 4+ messages in thread
From: Tu, Lijuan @ 2021-08-10  5:55 UTC (permalink / raw)
  To: Huang, ZhiminX, dts; +Cc: Huang, ZhiminX

> -----Original Message-----
> From: dts <dts-bounces@dpdk.org> On Behalf Of Zhimin Huang
> Sent: 2021年8月6日 2:23
> To: dts@dpdk.org
> Cc: Huang, ZhiminX <zhiminx.huang@intel.com>
> Subject: [dts] [PATCH V2] tests/cvl_advanced_rss_pppoe:remove destroy rule
> test steps
> 
> *.dpdk cannot guarantee the operation after destroy the rule, so remove
> destroy rule test steps.
> 
> Signed-off-by: Zhimin Huang <zhiminx.huang@intel.com>

I think because of the reason, multiple cases/suites/plans should be changed accordingly.
It is strongly requested to include them in the same patch series.

thanks

^ permalink raw reply	[flat|nested] 4+ messages in thread

* Re: [dts] [PATCH V2] tests/cvl_advanced_rss_pppoe:remove destroy rule test steps
  2021-08-05  9:55 ` Huang, ZhiminX
@ 2021-09-29  6:53   ` Tu, Lijuan
  0 siblings, 0 replies; 4+ messages in thread
From: Tu, Lijuan @ 2021-09-29  6:53 UTC (permalink / raw)
  To: Huang, ZhiminX, dts



> -----Original Message-----
> From: dts <dts-bounces@dpdk.org> On Behalf Of Huang, ZhiminX
> Sent: 2021年8月5日 17:56
> To: dts@dpdk.org
> Subject: Re: [dts] [PATCH V2] tests/cvl_advanced_rss_pppoe:remove destroy
> rule test steps
> 
> 
> > -----Original Message-----
> > From: Huang, ZhiminX <zhiminx.huang@intel.com>
> > Sent: Friday, August 6, 2021 2:23 AM
> > To: dts@dpdk.org
> > Cc: Huang, ZhiminX <zhiminx.huang@intel.com>
> > Subject: [dts] [PATCH V2] tests/cvl_advanced_rss_pppoe:remove destroy
> > rule test steps
> >
> 
> Tested-by: Zhimin Huang <zhiminx.huang@intel.com >

Applied


^ permalink raw reply	[flat|nested] 4+ messages in thread

end of thread, other threads:[~2021-09-29  6:53 UTC | newest]

Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-08-05 18:23 [dts] [PATCH V2] tests/cvl_advanced_rss_pppoe:remove destroy rule test steps Zhimin Huang
2021-08-05  9:55 ` Huang, ZhiminX
2021-09-29  6:53   ` Tu, Lijuan
2021-08-10  5:55 ` Tu, Lijuan

test suite reviews and discussions

This inbox may be cloned and mirrored by anyone:

	git clone --mirror http://inbox.dpdk.org/dts/0 dts/git/0.git

	# If you have public-inbox 1.1+ installed, you may
	# initialize and index your mirror using the following commands:
	public-inbox-init -V2 dts dts/ http://inbox.dpdk.org/dts \
		dts@dpdk.org
	public-inbox-index dts

Example config snippet for mirrors.
Newsgroup available over NNTP:
	nntp://inbox.dpdk.org/inbox.dpdk.dts


AGPL code for this site: git clone https://public-inbox.org/public-inbox.git