test suite reviews and discussions
 help / color / mirror / Atom feed
* Re: [dts] [PATCH V4] tests/loopback_virtio_user_server_mode:modify execute virtio-user server side testpmd command after client side started
  2021-02-02 14:33 [dts] [PATCH V4] tests/loopback_virtio_user_server_mode:modify execute virtio-user server side testpmd command after client side started Ling Wei
@ 2021-02-02  6:41 ` Ling, WeiX
  2021-02-02 13:48   ` Wang, Yinan
  2021-02-03  6:25 ` Tu, Lijuan
  1 sibling, 1 reply; 4+ messages in thread
From: Ling, WeiX @ 2021-02-02  6:41 UTC (permalink / raw)
  To: Ling, WeiX, dts

[-- Attachment #1: Type: text/plain, Size: 394 bytes --]

Tested-by: Wei Ling <weix.ling@intel.com>

Regards,
Ling Wei

> -----Original Message-----
> From: Ling Wei <weix.ling@intel.com>
> Sent: Tuesday, February 2, 2021 10:33 PM
> To: dts@dpdk.org
> Cc: Ling, WeiX <weix.ling@intel.com>
> Subject: [dts][PATCH V4] tests/loopback_virtio_user_server_mode:modify
> execute virtio-user server side testpmd command after client side started


[-- Attachment #2: TestLoopbackVirtioUserServerMode.log --]
[-- Type: application/octet-stream, Size: 29649 bytes --]

^ permalink raw reply	[flat|nested] 4+ messages in thread

* Re: [dts] [PATCH V4] tests/loopback_virtio_user_server_mode:modify execute virtio-user server side testpmd command after client side started
  2021-02-02  6:41 ` Ling, WeiX
@ 2021-02-02 13:48   ` Wang, Yinan
  0 siblings, 0 replies; 4+ messages in thread
From: Wang, Yinan @ 2021-02-02 13:48 UTC (permalink / raw)
  To: Ling, WeiX, Ling, WeiX, dts

Acked-by: Wang, Yinan <yinan.wang@intel.com>

> -----Original Message-----
> From: dts <dts-bounces@dpdk.org> On Behalf Of Ling, WeiX
> Sent: 2021?2?2? 14:41
> To: Ling, WeiX <weix.ling@intel.com>; dts@dpdk.org
> Subject: Re: [dts] [PATCH V4]
> tests/loopback_virtio_user_server_mode:modify execute virtio-user server
> side testpmd command after client side started
> 
> Tested-by: Wei Ling <weix.ling@intel.com>
> 
> Regards,
> Ling Wei
> 
> > -----Original Message-----
> > From: Ling Wei <weix.ling@intel.com>
> > Sent: Tuesday, February 2, 2021 10:33 PM
> > To: dts@dpdk.org
> > Cc: Ling, WeiX <weix.ling@intel.com>
> > Subject: [dts][PATCH V4] tests/loopback_virtio_user_server_mode:modify
> > execute virtio-user server side testpmd command after client side started


^ permalink raw reply	[flat|nested] 4+ messages in thread

* [dts] [PATCH V4] tests/loopback_virtio_user_server_mode:modify execute virtio-user server side testpmd command after client side started
@ 2021-02-02 14:33 Ling Wei
  2021-02-02  6:41 ` Ling, WeiX
  2021-02-03  6:25 ` Tu, Lijuan
  0 siblings, 2 replies; 4+ messages in thread
From: Ling Wei @ 2021-02-02 14:33 UTC (permalink / raw)
  To: dts; +Cc: Ling Wei

v1:
In DPDK 9af79db20f4cf, when launch virtio-user testpmd as server mode,
virtio-user server side testpmd expected character will be 
'wait for client side started...', after client side started, 
it change to 'testpmd>', so dts need modify execute virtio-user server
side testpmd command after client side started.

v2:
Fix comments about dpdk commit description error dut to checkpatch error.

v3:
Fix comments about dpdk commit description error dut to checkpatch error.

v4:
Fix comments about dpdk commit description error dut to checkpatch error.

Signed-off-by: Ling Wei <weix.ling@intel.com>
---
 tests/TestSuite_loopback_virtio_user_server_mode.py | 13 ++++++++-----
 1 file changed, 8 insertions(+), 5 deletions(-)

diff --git a/tests/TestSuite_loopback_virtio_user_server_mode.py b/tests/TestSuite_loopback_virtio_user_server_mode.py
index 9801175..0178ca3 100644
--- a/tests/TestSuite_loopback_virtio_user_server_mode.py
+++ b/tests/TestSuite_loopback_virtio_user_server_mode.py
@@ -92,7 +92,7 @@ class TestLoopbackVirtioUserServerMode(TestCase):
         out = self.dut.send_expect("cat /proc/meminfo |grep Hugepagesize|awk '{print($2)}'", "# ")
         return True if out == '2048' else False
 
-    def lanuch_virtio_user_testpmd(self, args):
+    def lanuch_virtio_user_testpmd(self, args, set_fwd_mac=True, expected='testpmd> '):
         """
         start testpmd of vhost user
         """
@@ -103,8 +103,9 @@ class TestLoopbackVirtioUserServerMode(TestCase):
             eal_param += " --force-max-simd-bitwidth=512"
         param = "--rxq=1 --txq=1 --no-numa"
         self.virtio_user_pmd.start_testpmd(cores=self.core_list_user, param=param, eal_param=eal_param, \
-                no_pci=True, ports=[], prefix="virtio", fixed_prefix=True)
-        self.virtio_user_pmd.execute_cmd("set fwd mac", "testpmd> ", 120)
+                no_pci=True, ports=[], prefix="virtio", fixed_prefix=True, expected=expected)
+        if set_fwd_mac:
+            self.virtio_user_pmd.execute_cmd("set fwd mac", "testpmd> ", 120)
 
     def lanuch_vhost_testpmd_with_multi_queue(self, extern_params=""):
         """
@@ -251,8 +252,9 @@ class TestLoopbackVirtioUserServerMode(TestCase):
         self.nb_cores = 1
         virtio_pmd_arg = {"version": "packed_vq=0,in_order=0,mrg_rxbuf=1",
                           "path": "--tx-offloads=0x0 --enable-hw-vlan-strip"}
-        self.lanuch_virtio_user_testpmd(virtio_pmd_arg)
+        self.lanuch_virtio_user_testpmd(virtio_pmd_arg, set_fwd_mac=False, expected='waiting for client connection...')
         self.lanuch_vhost_testpmd()
+        self.virtio_user_pmd.execute_cmd("set fwd mac", "testpmd> ", 120)
         self.start_to_send_packets(self.virtio_user, self.vhost)
         self.calculate_avg_throughput("lanuch virtio first", "")
         self.result_table_print()
@@ -266,8 +268,9 @@ class TestLoopbackVirtioUserServerMode(TestCase):
         self.nb_cores = 1
         virtio_pmd_arg = {"version": "packed_vq=1,in_order=0,mrg_rxbuf=1",
                           "path": "--tx-offloads=0x0 --enable-hw-vlan-strip"}
-        self.lanuch_virtio_user_testpmd(virtio_pmd_arg)
+        self.lanuch_virtio_user_testpmd(virtio_pmd_arg, set_fwd_mac=False, expected='waiting for client connection...')
         self.lanuch_vhost_testpmd()
+        self.virtio_user_pmd.execute_cmd("set fwd mac", "testpmd> ", 120)
         self.start_to_send_packets(self.virtio_user, self.vhost)
         self.calculate_avg_throughput("lanuch virtio first", "")
         self.result_table_print()
-- 
2.25.1


^ permalink raw reply	[flat|nested] 4+ messages in thread

* Re: [dts] [PATCH V4] tests/loopback_virtio_user_server_mode:modify execute virtio-user server side testpmd command after client side started
  2021-02-02 14:33 [dts] [PATCH V4] tests/loopback_virtio_user_server_mode:modify execute virtio-user server side testpmd command after client side started Ling Wei
  2021-02-02  6:41 ` Ling, WeiX
@ 2021-02-03  6:25 ` Tu, Lijuan
  1 sibling, 0 replies; 4+ messages in thread
From: Tu, Lijuan @ 2021-02-03  6:25 UTC (permalink / raw)
  To: Ling, WeiX, dts; +Cc: Ling, WeiX

> v1:
> In DPDK 9af79db20f4cf, when launch virtio-user testpmd as server mode, virtio-
> user server side testpmd expected character will be 'wait for client side
> started...', after client side started, it change to 'testpmd>', so dts need modify
> execute virtio-user server side testpmd command after client side started.
> 
> v2:
> Fix comments about dpdk commit description error dut to checkpatch error.
> 
> v3:
> Fix comments about dpdk commit description error dut to checkpatch error.
> 
> v4:
> Fix comments about dpdk commit description error dut to checkpatch error.
> 
> Signed-off-by: Ling Wei <weix.ling@intel.com>

Applied

^ permalink raw reply	[flat|nested] 4+ messages in thread

end of thread, other threads:[~2021-02-03  6:25 UTC | newest]

Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-02-02 14:33 [dts] [PATCH V4] tests/loopback_virtio_user_server_mode:modify execute virtio-user server side testpmd command after client side started Ling Wei
2021-02-02  6:41 ` Ling, WeiX
2021-02-02 13:48   ` Wang, Yinan
2021-02-03  6:25 ` Tu, Lijuan

test suite reviews and discussions

This inbox may be cloned and mirrored by anyone:

	git clone --mirror http://inbox.dpdk.org/dts/0 dts/git/0.git

	# If you have public-inbox 1.1+ installed, you may
	# initialize and index your mirror using the following commands:
	public-inbox-init -V2 dts dts/ http://inbox.dpdk.org/dts \
		dts@dpdk.org
	public-inbox-index dts

Example config snippet for mirrors.
Newsgroup available over NNTP:
	nntp://inbox.dpdk.org/inbox.dpdk.dts


AGPL code for this site: git clone https://public-inbox.org/public-inbox.git