From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-qt0-f228.google.com (mail-qt0-f228.google.com [209.85.216.228]) by dpdk.org (Postfix) with ESMTP id 0BB025F38 for ; Thu, 29 Mar 2018 21:16:47 +0200 (CEST) Received: by mail-qt0-f228.google.com with SMTP id s48so7349604qtb.10 for ; Thu, 29 Mar 2018 12:16:46 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=iol.unh.edu; s=unh-iol; h=from:to:cc:subject:date:message-id:in-reply-to:references; bh=cYnsm5b5zypcuAUCUKGS2+SDM6NRavI0H1c32OPqcD0=; b=dudAhwGkDv/Q/h+crNNkUsE+B9s/l1SSqxYqDafTDu9Qx1S9fvzfirAdIAtZJdQV4r BK6PIFXiQ/nJ4mmzceH/922RCypUQJv0KpBU6UM5thCwrkE/XbQ4V1JvSjrJYk0FC6J5 UigEGbNKN674ovGJnzAj0LNDG562qnDbvMRI4= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references; bh=cYnsm5b5zypcuAUCUKGS2+SDM6NRavI0H1c32OPqcD0=; b=eZLPnLcRMShqmHgSChnVkPRvwJ7bRP2Vy17AsCB/kNh0yEZRDYRge5U9fWGXdmsQKS 4CuQiDO8A95oDUnb8yqdIU3CJEVLD8lutZUrj4dDLhr0pHHVNkrWmqIA0IIxjbybLL4A RWaamG13ZHO9amvE5MF5MzVU3TI/8IhsrB9UIuJJfnl/YMCGE4kubZ9zg4XAOP20+DyY H5og6ca3EjMaCGzGU8ezuip1i4lBPyxbTZElhDonYy0aEY3UzXQ+u2lPWFoGBgvK5wjB 8RCdmjNeAPO9Eq3uMJIdolh4p3k/paL4KmANdfje+ntbCfrQIHnsOSHMCPtuNPULk6Js D73g== X-Gm-Message-State: ALQs6tBv0jC8kYtz9bKRJc1pyM2XxRhAMIDa4IArmTLq39uSKsVP2FVb 9JjgLDcCGsiR4g5JGwNEjRK8Tl7qv+uggMzUDBZn7Hcu7qO9vG/VnHn0GxRBTyxQXUl6TCTznf9 p7vz1dgE/+tty0mqEUFB8V/AnHp9FSNgy9R26WacmMadepuxNwaDArv7+vQ5J/1gpv4ryEPyUZA == X-Google-Smtp-Source: AIpwx4+rnNHkHVbyXqXB9IuOqzyXQ+9FAozFIctSFI4Thjy+Ugs6CJ0lBKpBEPXxW2L2qqXUNTZB5UwvA8fU X-Received: by 10.200.4.148 with SMTP id s20mr13110754qtg.144.1522351006445; Thu, 29 Mar 2018 12:16:46 -0700 (PDT) Received: from postal.iol.unh.edu (postal.iol.unh.edu. [132.177.123.84]) by smtp-relay.gmail.com with ESMTPS id a193sm1254875qkb.4.2018.03.29.12.16.46 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Thu, 29 Mar 2018 12:16:46 -0700 (PDT) X-Relaying-Domain: iol.unh.edu Received: from groose.ofa (unknown [IPv6:2606:4100:3880:1240:cc3b:885c:7cb:4a8e]) by postal.iol.unh.edu (Postfix) with ESMTP id F41E06045DC2; Thu, 29 Mar 2018 15:16:45 -0400 (EDT) From: Patrick MacArthur To: dts@dpdk.org Cc: dpdklab@iol.unh.edu Date: Thu, 29 Mar 2018 15:16:00 -0400 Message-Id: <20180329191605.5404-3-pmacarth@iol.unh.edu> X-Mailer: git-send-email 2.14.1 In-Reply-To: <20180329191605.5404-1-pmacarth@iol.unh.edu> References: <20180329191605.5404-1-pmacarth@iol.unh.edu> Subject: [dts] [PATCH for-next v3 2/7] framework: Do not attempt ping6 on T-Rex ports X-BeenThere: dts@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: test suite reviews and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 29 Mar 2018 19:16:47 -0000 DTS uses ping6 to determine whether the DUT and tester node ports are connected. Currently the IXIA ports are excluded from this test because they are matched explicitly with DUT ports in the ports.cfg file and the traffic generator will not respond to pings in the usual fashion. For the same reason, exclude T-Rex ports from ping6 matching and connectivity testing. This avoids a traceback due to the T-Rex ports not having enough available information to complete the ping6 check. Tested-by: Ali Alnubani Signed-off-by: Patrick MacArthur --- framework/dut.py | 4 ++-- framework/tester.py | 10 ++++++---- framework/virt_dut.py | 2 +- 3 files changed, 9 insertions(+), 7 deletions(-) diff --git a/framework/dut.py b/framework/dut.py index 31b3daaaebcb..5b72c7a523e3 100644 --- a/framework/dut.py +++ b/framework/dut.py @@ -980,13 +980,13 @@ class Dut(Crb): def disable_tester_ipv6(self): for tester_port in self.ports_map: - if self.tester.ports_info[tester_port]['type'] != 'ixia': + if self.tester.ports_info[tester_port]['type'].lower() not in ('ixia', 'trex'): port = self.tester.ports_info[tester_port]['port'] port.disable_ipv6() def enable_tester_ipv6(self): for tester_port in range(len(self.tester.ports_info)): - if self.tester.ports_info[tester_port]['type'] != 'ixia': + if self.tester.ports_info[tester_port]['type'].lower() not in ('ixia', 'trex'): port = self.tester.ports_info[tester_port]['port'] port.enable_ipv6() diff --git a/framework/tester.py b/framework/tester.py index 151200872338..be5b0e13897c 100755 --- a/framework/tester.py +++ b/framework/tester.py @@ -200,7 +200,7 @@ class Tester(Crb): if localPort == -1: raise ParameterInvalidException("local port should not be -1") - if self.ports_info[localPort]['type'] == 'ixia': + if self.ports_info[localPort]['type'] in ('ixia', 'trex'): return "00:00:00:00:00:01" else: return self.ports_info[localPort]['mac'] @@ -305,7 +305,7 @@ class Tester(Crb): return for port_info in self.ports_info: - if port_info['type'] == 'ixia': + if port_info['type'].lower() in ('ixia', 'trex'): continue addr_array = port_info['pci'].split(':') @@ -394,7 +394,7 @@ class Tester(Crb): """ Send ping6 packet from local port with destination ipv4 address. """ - if self.ports_info[localPort]['type'] == 'ixia': + if self.ports_info[localPort]['type'].lower() in ('ixia', 'trex'): return "Not implemented yet" else: return self.send_expect("ping -w 5 -c 5 -A -I %s %s" % (self.ports_info[localPort]['intf'], ipv4), "# ", 10) @@ -403,8 +403,10 @@ class Tester(Crb): """ Send ping6 packet from local port with destination ipv6 address. """ - if self.ports_info[localPort]['type'] == 'ixia': + if self.ports_info[localPort]['type'].lower() == 'ixia': return self.ixia_packet_gen.send_ping6(self.ports_info[localPort]['pci'], mac, ipv6) + elif self.ports_info[localPort]['type'].lower() == 'trex': + return "Not implemented yet" else: return self.send_expect("ping6 -w 5 -c 5 -A %s%%%s" % (ipv6, self.ports_info[localPort]['intf']), "# ", 10) diff --git a/framework/virt_dut.py b/framework/virt_dut.py index 62688dc83b9e..d4cd805d2a03 100644 --- a/framework/virt_dut.py +++ b/framework/virt_dut.py @@ -385,7 +385,7 @@ class VirtDut(DPDKdut): remotepci = self.tester.ports_info[remotePort]['pci'] port_type = self.tester.ports_info[remotePort]['type'] # IXIA port should not check whether has vfs - if port_type != 'ixia': + if port_type.lower() not in ('ixia', 'trex'): remoteport = self.tester.ports_info[remotePort]['port'] vfs = [] # vm_dut and tester in same dut -- 2.14.1