test suite reviews and discussions
 help / color / Atom feed
* [dts] [PATCH V1 0/1] tests/l2fwd: wait l2fwd boot up ready
@ 2019-09-05  3:26 yufengmx
  2019-09-05  3:26 ` [dts] [PATCH V1 1/1] " yufengmx
  0 siblings, 1 reply; 4+ messages in thread
From: yufengmx @ 2019-09-05  3:26 UTC (permalink / raw)
  To: dts, lijuan.tu, zhaoyan.chen; +Cc: yufengmx

fix l2fwd 'Effective bandwidth is zero' issue when run trex. l2fwd doesn't offer link up query, 
here wait 5 second after l2fwd boot up. It is aimed to make sure trex detect link up status. 
 

yufengmx (1):
  tests/l2fwd: wait l2fwd boot up ready

 tests/TestSuite_l2fwd.py | 5 ++++-
 1 file changed, 4 insertions(+), 1 deletion(-)

-- 
2.21.0


^ permalink raw reply	[flat|nested] 4+ messages in thread

* [dts] [PATCH V1 1/1] tests/l2fwd: wait l2fwd boot up ready
  2019-09-05  3:26 [dts] [PATCH V1 0/1] tests/l2fwd: wait l2fwd boot up ready yufengmx
@ 2019-09-05  3:26 ` " yufengmx
  2019-09-05  3:26   ` Mo, YufengX
  2019-09-18  6:36   ` Tu, Lijuan
  0 siblings, 2 replies; 4+ messages in thread
From: yufengmx @ 2019-09-05  3:26 UTC (permalink / raw)
  To: dts, lijuan.tu, zhaoyan.chen; +Cc: yufengmx


wait 5 second after l2fwd boot up. It is aimed to make sure trex detect link up status.

Signed-off-by: yufengmx <yufengx.mo@intel.com>
---
 tests/TestSuite_l2fwd.py | 5 ++++-
 1 file changed, 4 insertions(+), 1 deletion(-)

diff --git a/tests/TestSuite_l2fwd.py b/tests/TestSuite_l2fwd.py
index e2c4118..ace5dff 100644
--- a/tests/TestSuite_l2fwd.py
+++ b/tests/TestSuite_l2fwd.py
@@ -196,7 +196,10 @@ class TestL2fwd(TestCase):
 
 #                self.dut.send_expect(command_line, "memory mapped", 60)
                 self.dut.send_expect(command_line, "L2FWD: entering main loop", 60)
-
+                # wait 5 second after l2fwd boot up. 
+                # It is aimed to make sure trex detect link up status.
+                if self.tester.is_pktgen:
+                    time.sleep(5)
                 info = "Executing l2fwd using %s queues, frame size %d and %s setup.\n" % \
                        (queues['queues'], frame_size, self.core_config)
 
-- 
2.21.0


^ permalink raw reply	[flat|nested] 4+ messages in thread

* Re: [dts] [PATCH V1 1/1] tests/l2fwd: wait l2fwd boot up ready
  2019-09-05  3:26 ` [dts] [PATCH V1 1/1] " yufengmx
@ 2019-09-05  3:26   ` Mo, YufengX
  2019-09-18  6:36   ` Tu, Lijuan
  1 sibling, 0 replies; 4+ messages in thread
From: Mo, YufengX @ 2019-09-05  3:26 UTC (permalink / raw)
  To: dts, Tu, Lijuan, Chen,  Zhaoyan

Tested by Mo, YufengX <yufengx.mo@intel.com>

> -----Original Message-----
> From: Mo, YufengX
> Sent: Thursday, September 5, 2019 11:27 AM
> To: dts@dpdk.org; Tu, Lijuan <lijuan.tu@intel.com>; Chen, Zhaoyan <zhaoyan.chen@intel.com>
> Cc: Mo, YufengX <yufengx.mo@intel.com>
> Subject: [dts][PATCH V1 1/1] tests/l2fwd: wait l2fwd boot up ready
> 
> 
> wait 5 second after l2fwd boot up. It is aimed to make sure trex detect link up status.
> 
> Signed-off-by: yufengmx <yufengx.mo@intel.com>
> ---
>  tests/TestSuite_l2fwd.py | 5 ++++-
>  1 file changed, 4 insertions(+), 1 deletion(-)
> 
> diff --git a/tests/TestSuite_l2fwd.py b/tests/TestSuite_l2fwd.py
> index e2c4118..ace5dff 100644
> --- a/tests/TestSuite_l2fwd.py
> +++ b/tests/TestSuite_l2fwd.py
> @@ -196,7 +196,10 @@ class TestL2fwd(TestCase):
> 
>  #                self.dut.send_expect(command_line, "memory mapped", 60)
>                  self.dut.send_expect(command_line, "L2FWD: entering main loop", 60)
> -
> +                # wait 5 second after l2fwd boot up.
> +                # It is aimed to make sure trex detect link up status.
> +                if self.tester.is_pktgen:
> +                    time.sleep(5)
>                  info = "Executing l2fwd using %s queues, frame size %d and %s setup.\n" % \
>                         (queues['queues'], frame_size, self.core_config)
> 
> --
> 2.21.0


^ permalink raw reply	[flat|nested] 4+ messages in thread

* Re: [dts] [PATCH V1 1/1] tests/l2fwd: wait l2fwd boot up ready
  2019-09-05  3:26 ` [dts] [PATCH V1 1/1] " yufengmx
  2019-09-05  3:26   ` Mo, YufengX
@ 2019-09-18  6:36   ` Tu, Lijuan
  1 sibling, 0 replies; 4+ messages in thread
From: Tu, Lijuan @ 2019-09-18  6:36 UTC (permalink / raw)
  To: Mo, YufengX, dts, Chen, Zhaoyan

Applied, thanks

> -----Original Message-----
> From: Mo, YufengX
> Sent: Thursday, September 5, 2019 11:27 AM
> To: dts@dpdk.org; Tu, Lijuan <lijuan.tu@intel.com>; Chen, Zhaoyan
> <zhaoyan.chen@intel.com>
> Cc: Mo, YufengX <yufengx.mo@intel.com>
> Subject: [dts][PATCH V1 1/1] tests/l2fwd: wait l2fwd boot up ready
> 
> 
> wait 5 second after l2fwd boot up. It is aimed to make sure trex detect link
> up status.
> 
> Signed-off-by: yufengmx <yufengx.mo@intel.com>
> ---
>  tests/TestSuite_l2fwd.py | 5 ++++-
>  1 file changed, 4 insertions(+), 1 deletion(-)
> 
> diff --git a/tests/TestSuite_l2fwd.py b/tests/TestSuite_l2fwd.py index
> e2c4118..ace5dff 100644
> --- a/tests/TestSuite_l2fwd.py
> +++ b/tests/TestSuite_l2fwd.py
> @@ -196,7 +196,10 @@ class TestL2fwd(TestCase):
> 
>  #                self.dut.send_expect(command_line, "memory mapped", 60)
>                  self.dut.send_expect(command_line, "L2FWD: entering main loop",
> 60)
> -
> +                # wait 5 second after l2fwd boot up.
> +                # It is aimed to make sure trex detect link up status.
> +                if self.tester.is_pktgen:
> +                    time.sleep(5)
>                  info = "Executing l2fwd using %s queues, frame size %d and %s
> setup.\n" % \
>                         (queues['queues'], frame_size, self.core_config)
> 
> --
> 2.21.0


^ permalink raw reply	[flat|nested] 4+ messages in thread

end of thread, back to index

Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-09-05  3:26 [dts] [PATCH V1 0/1] tests/l2fwd: wait l2fwd boot up ready yufengmx
2019-09-05  3:26 ` [dts] [PATCH V1 1/1] " yufengmx
2019-09-05  3:26   ` Mo, YufengX
2019-09-18  6:36   ` Tu, Lijuan

test suite reviews and discussions

Archives are clonable:
	git clone --mirror http://inbox.dpdk.org/dts/0 dts/git/0.git

	# If you have public-inbox 1.1+ installed, you may
	# initialize and index your mirror using the following commands:
	public-inbox-init -V2 dts dts/ http://inbox.dpdk.org/dts \
		dts@dpdk.org
	public-inbox-index dts


Newsgroup available over NNTP:
	nntp://inbox.dpdk.org/inbox.dpdk.dts


AGPL code for this site: git clone https://public-inbox.org/ public-inbox