test suite reviews and discussions
 help / color / Atom feed
* [dts] [PATCH V1] add support for cvl
@ 2019-10-25 15:08 Peng Zhihong
  0 siblings, 0 replies; 6+ messages in thread
From: Peng Zhihong @ 2019-10-25 15:08 UTC (permalink / raw)
  To: dts; +Cc: Peng Zhihong

add support for cvl

Signed-off-by: Peng Zhihong <zhihongx.peng@intel.com>
---
 tests/TestSuite_userspace_ethtool.py | 12 ++++++++----
 1 file changed, 8 insertions(+), 4 deletions(-)

diff --git a/tests/TestSuite_userspace_ethtool.py b/tests/TestSuite_userspace_ethtool.py
index 116fd3a..9a30199 100644
--- a/tests/TestSuite_userspace_ethtool.py
+++ b/tests/TestSuite_userspace_ethtool.py
@@ -546,9 +546,14 @@ class TestUserspaceEthtool(TestCase, IxiaPacketGenerator):
         mtus = [1519, 2048]
         mtu_threshold = 2022
         offset = 0
+
         if self.nic in ['powerville', 'springville']:
             mtu_threshold = 2026
             offset = 4
+        elif self.nic in ['columbiaville_25g', 'columbiaville_100g']:
+            #mtu + ICE_ETH_OVERHEAD  = mtu + HEADER_SIZE['eth'] + offset (ICE_ETH_OVERHEAD is 26)
+            offset = 8
+
         for index in range(len(self.ports)):
             port = self.ports[index]
             # change mtu
@@ -561,12 +566,11 @@ class TestUserspaceEthtool(TestCase, IxiaPacketGenerator):
                 if mtu > mtu_threshold:
                     if self.nic in ['powerville', 'springville']:
                         mtu = mtu_threshold
-                    self.dut.send_expect("stop %s" % index, "EthApp>")
-                    self.dut.send_expect("mtu %d %d" % (index, mtu), "EthApp>")
-                    self.dut.send_expect("open %s" % index, "EthApp>")
+                self.dut.send_expect("stop %s" % index, "EthApp>")
                 self.dut.send_expect("mtu %d %d" % (index, mtu), "EthApp>")
-                time.sleep(5)
+                self.dut.send_expect("open %s" % index, "EthApp>")
                 ori_rx_pkts, _ = self.strip_portstats(index)
+                time.sleep(5)
                 pkt_size = mtu + HEADER_SIZE['eth'] + offset
                 pkt = Packet(pkt_type='UDP', pkt_len=pkt_size)
                 pkt.send_pkt(self.tester, tx_port=intf, count=4)
-- 
2.17.1


^ permalink raw reply	[flat|nested] 6+ messages in thread

* Re: [dts] [PATCH V1] add support for cvl
  2019-10-25 16:52 Peng Zhihong
@ 2019-11-04  3:19 ` Tu, Lijuan
  0 siblings, 0 replies; 6+ messages in thread
From: Tu, Lijuan @ 2019-11-04  3:19 UTC (permalink / raw)
  To: Peng, ZhihongX, dts; +Cc: Peng, ZhihongX

Applied, thanks

> -----Original Message-----
> From: dts [mailto:dts-bounces@dpdk.org] On Behalf Of Peng Zhihong
> Sent: Saturday, October 26, 2019 12:52 AM
> To: dts@dpdk.org
> Cc: Peng, ZhihongX <zhihongx.peng@intel.com>
> Subject: [dts] [PATCH V1] add support for cvl
> 
> add support for cvl
> 
> Signed-off-by: Peng Zhihong <zhihongx.peng@intel.com>
> ---
>  tests/TestSuite_userspace_ethtool.py | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/tests/TestSuite_userspace_ethtool.py
> b/tests/TestSuite_userspace_ethtool.py
> index 116fd3a..92724aa 100644
> --- a/tests/TestSuite_userspace_ethtool.py
> +++ b/tests/TestSuite_userspace_ethtool.py
> @@ -259,7 +259,7 @@ class TestUserspaceEthtool(TestCase,
> IxiaPacketGenerator):
>          # only detect physical link disconnect status
>          verify_pass = True
>          verify_msg = ''
> -        if self.nic.startswith("fortville") == False:
> +        if self.nic.startswith("fortville") == False or
> self.nic.startswith("columbiaville"):
>              # check link status dump function
>              for port in self.ports:
>                  tester_port = self.tester.get_local_port(port)
> --
> 2.17.1


^ permalink raw reply	[flat|nested] 6+ messages in thread

* Re: [dts] [[PATCH V1] add support for cvl
  2019-10-23 15:59 [dts] [[PATCH " Peng Zhihong
  2019-10-24  8:20 ` He, Zhiwei
@ 2019-11-04  2:44 ` Tu, Lijuan
  1 sibling, 0 replies; 6+ messages in thread
From: Tu, Lijuan @ 2019-11-04  2:44 UTC (permalink / raw)
  To: Peng, ZhihongX, dts; +Cc: Peng, ZhihongX

Applied, thanks

> -----Original Message-----
> From: dts [mailto:dts-bounces@dpdk.org] On Behalf Of Peng Zhihong
> Sent: Wednesday, October 23, 2019 11:59 PM
> To: dts@dpdk.org
> Cc: Peng, ZhihongX <zhihongx.peng@intel.com>
> Subject: [dts] [[PATCH V1] add support for cvl
> 
> add support for cvl
> 
> Signed-off-by: Peng Zhihong <zhihongx.peng@intel.com>
> ---
>  conf/test_case_supportlist.json | 4 +++-
>  1 file changed, 3 insertions(+), 1 deletion(-)
> 
> diff --git a/conf/test_case_supportlist.json b/conf/test_case_supportlist.json
> index 37f9158..ffb2e6b 100644
> --- a/conf/test_case_supportlist.json
> +++ b/conf/test_case_supportlist.json
> @@ -286,7 +286,9 @@
>                  "fortville_spirit",
>                  "fortville_spirit_single",
>                  "fortville_25g",
> -		"carlsville"
> +		"carlsville",
> +                "columbiaville_25g",
> +                "columbiaville_100g"
>              ],
>              "Target": [
>                  "ALL"
> --
> 2.17.1


^ permalink raw reply	[flat|nested] 6+ messages in thread

* [dts] [PATCH V1] add support for cvl
@ 2019-10-25 16:52 Peng Zhihong
  2019-11-04  3:19 ` Tu, Lijuan
  0 siblings, 1 reply; 6+ messages in thread
From: Peng Zhihong @ 2019-10-25 16:52 UTC (permalink / raw)
  To: dts; +Cc: Peng Zhihong

add support for cvl

Signed-off-by: Peng Zhihong <zhihongx.peng@intel.com>
---
 tests/TestSuite_userspace_ethtool.py | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/tests/TestSuite_userspace_ethtool.py b/tests/TestSuite_userspace_ethtool.py
index 116fd3a..92724aa 100644
--- a/tests/TestSuite_userspace_ethtool.py
+++ b/tests/TestSuite_userspace_ethtool.py
@@ -259,7 +259,7 @@ class TestUserspaceEthtool(TestCase, IxiaPacketGenerator):
         # only detect physical link disconnect status
         verify_pass = True
         verify_msg = ''
-        if self.nic.startswith("fortville") == False:  
+        if self.nic.startswith("fortville") == False or self.nic.startswith("columbiaville"):  
             # check link status dump function
             for port in self.ports:
                 tester_port = self.tester.get_local_port(port)
-- 
2.17.1


^ permalink raw reply	[flat|nested] 6+ messages in thread

* Re: [dts] [[PATCH V1] add support for cvl
  2019-10-23 15:59 [dts] [[PATCH " Peng Zhihong
@ 2019-10-24  8:20 ` He, Zhiwei
  2019-11-04  2:44 ` Tu, Lijuan
  1 sibling, 0 replies; 6+ messages in thread
From: He, Zhiwei @ 2019-10-24  8:20 UTC (permalink / raw)
  To: Peng, ZhihongX, dts; +Cc: Peng, ZhihongX, He, Zhiwei

Acked-by zhiwei  <zhiwei.he@intel.com>

-----Original Message-----
From: dts [mailto:dts-bounces@dpdk.org] On Behalf Of Peng Zhihong
Sent: Wednesday, October 23, 2019 11:59 PM
To: dts@dpdk.org
Cc: Peng, ZhihongX <zhihongx.peng@intel.com>
Subject: [dts] [[PATCH V1] add support for cvl

add support for cvl

Signed-off-by: Peng Zhihong <zhihongx.peng@intel.com>
---
 conf/test_case_supportlist.json | 4 +++-
 1 file changed, 3 insertions(+), 1 deletion(-)

diff --git a/conf/test_case_supportlist.json b/conf/test_case_supportlist.json index 37f9158..ffb2e6b 100644
--- a/conf/test_case_supportlist.json
+++ b/conf/test_case_supportlist.json
@@ -286,7 +286,9 @@
                 "fortville_spirit",
                 "fortville_spirit_single",
                 "fortville_25g",
-		"carlsville"
+		"carlsville",
+                "columbiaville_25g",
+                "columbiaville_100g"
             ],
             "Target": [
                 "ALL"
--
2.17.1


^ permalink raw reply	[flat|nested] 6+ messages in thread

* [dts] [[PATCH V1] add support for cvl
@ 2019-10-23 15:59 " Peng Zhihong
  2019-10-24  8:20 ` He, Zhiwei
  2019-11-04  2:44 ` Tu, Lijuan
  0 siblings, 2 replies; 6+ messages in thread
From: Peng Zhihong @ 2019-10-23 15:59 UTC (permalink / raw)
  To: dts; +Cc: Peng Zhihong

add support for cvl

Signed-off-by: Peng Zhihong <zhihongx.peng@intel.com>
---
 conf/test_case_supportlist.json | 4 +++-
 1 file changed, 3 insertions(+), 1 deletion(-)

diff --git a/conf/test_case_supportlist.json b/conf/test_case_supportlist.json
index 37f9158..ffb2e6b 100644
--- a/conf/test_case_supportlist.json
+++ b/conf/test_case_supportlist.json
@@ -286,7 +286,9 @@
                 "fortville_spirit",
                 "fortville_spirit_single",
                 "fortville_25g",
-		"carlsville"
+		"carlsville",
+                "columbiaville_25g",
+                "columbiaville_100g"
             ],
             "Target": [
                 "ALL"
-- 
2.17.1


^ permalink raw reply	[flat|nested] 6+ messages in thread

end of thread, back to index

Thread overview: 6+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-10-25 15:08 [dts] [PATCH V1] add support for cvl Peng Zhihong
  -- strict thread matches above, loose matches on Subject: below --
2019-10-25 16:52 Peng Zhihong
2019-11-04  3:19 ` Tu, Lijuan
2019-10-23 15:59 [dts] [[PATCH " Peng Zhihong
2019-10-24  8:20 ` He, Zhiwei
2019-11-04  2:44 ` Tu, Lijuan

test suite reviews and discussions

Archives are clonable:
	git clone --mirror http://inbox.dpdk.org/dts/0 dts/git/0.git

	# If you have public-inbox 1.1+ installed, you may
	# initialize and index your mirror using the following commands:
	public-inbox-init -V2 dts dts/ http://inbox.dpdk.org/dts \
		dts@dpdk.org
	public-inbox-index dts


Newsgroup available over NNTP:
	nntp://inbox.dpdk.org/inbox.dpdk.dts


AGPL code for this site: git clone https://public-inbox.org/ public-inbox