[dts] [PATCH V1] tests/ multiple_pthread: add killall scapy in tear_down

[dts] [PATCH V1] tests/ multiple_pthread: add killall scapy in tear_down

[Xiaoxiao Zeng]

*.This suit not close send_package tool,it make next suit's testpmd get large rx_pakage when start

Signed-off-by: Xiaoxiao Zeng <xiaoxiaox.zeng@intel.com>
---
 tests/TestSuite_multiple_pthread.py | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/tests/TestSuite_multiple_pthread.py b/tests/TestSuite_multiple_pthread.py
index 1ea71a5..f247751 100644
--- a/tests/TestSuite_multiple_pthread.py
+++ b/tests/TestSuite_multiple_pthread.py
@@ -237,4 +237,4 @@ class TestMultiplePthread(TestCase):
         """
         Run after each test suite.
         """
-        pass
+        self.tester.send_expect("killall scapy", "#", 5)
-- 
2.17.0

Re: [dts] [PATCH V1] tests/ multiple_pthread: add killall scapy in tear_down

[Ma, LihongX]

Hi, xiaoxiao
In this suite, the scapy is called multiple times, so I think you should put the command `self.tester.send_expect("killall scapy", "#", 5)`  in tear_down instead of tear_down_all
And by the way ,after kill the scapy, the session ' self.send_packets_session' which create by tester should ' destroy_session' too.

-----Original Message-----
From: dts [mailto:dts-bounces@dpdk.org] On Behalf Of Xiaoxiao Zeng
Sent: Friday, November 1, 2019 11:00 PM
To: dts@dpdk.org
Cc: Zeng, XiaoxiaoX <xiaoxiaox.zeng@intel.com>
Subject: [dts] [PATCH V1] tests/ multiple_pthread: add killall scapy in tear_down

*.This suit not close send_package tool,it make next suit's testpmd get large rx_pakage when start

Signed-off-by: Xiaoxiao Zeng <xiaoxiaox.zeng@intel.com>
---
 tests/TestSuite_multiple_pthread.py | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/tests/TestSuite_multiple_pthread.py b/tests/TestSuite_multiple_pthread.py
index 1ea71a5..f247751 100644
--- a/tests/TestSuite_multiple_pthread.py
+++ b/tests/TestSuite_multiple_pthread.py
@@ -237,4 +237,4 @@ class TestMultiplePthread(TestCase):
         """
         Run after each test suite.
         """
-        pass
+        self.tester.send_expect("killall scapy", "#", 5)
-- 
2.17.0

Re: [dts] [PATCH V1] tests/ multiple_pthread: add killall scapy in tear_down

[Tu, Lijuan]

It's not a good idea to kill all scapy, it will impact other users who is also using scapy but another process.

> -----Original Message-----
> From: dts [mailto:dts-bounces@dpdk.org] On Behalf Of Xiaoxiao Zeng
> Sent: Friday, November 1, 2019 11:00 PM
> To: dts@dpdk.org
> Cc: Zeng, XiaoxiaoX <xiaoxiaox.zeng@intel.com>
> Subject: [dts] [PATCH V1] tests/ multiple_pthread: add killall scapy in
> tear_down
> 
> *.This suit not close send_package tool,it make next suit's testpmd get large
> rx_pakage when start
> 
> Signed-off-by: Xiaoxiao Zeng <xiaoxiaox.zeng@intel.com>
> ---
>  tests/TestSuite_multiple_pthread.py | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/tests/TestSuite_multiple_pthread.py
> b/tests/TestSuite_multiple_pthread.py
> index 1ea71a5..f247751 100644
> --- a/tests/TestSuite_multiple_pthread.py
> +++ b/tests/TestSuite_multiple_pthread.py
> @@ -237,4 +237,4 @@ class TestMultiplePthread(TestCase):
>          """
>          Run after each test suite.
>          """
> -        pass
> +        self.tester.send_expect("killall scapy", "#", 5)
> --
> 2.17.0