test suite reviews and discussions
 help / color / mirror / Atom feed
* [dts] [PATCH V1] framework/dut:optimize code
@ 2020-02-18  4:22 Haiyang Zhao
  2020-02-18  4:22 ` [dts] [PATCH V1] tests/l2fwd:fix a bug Haiyang Zhao
                   ` (2 more replies)
  0 siblings, 3 replies; 8+ messages in thread
From: Haiyang Zhao @ 2020-02-18  4:22 UTC (permalink / raw)
  To: dts; +Cc: Haiyang Zhao

*.test performance with trex support two port map methods, 
  add the pci map method.

Signed-off-by: Haiyang Zhao <haiyangx.zhao@intel.com>
---
 framework/dut.py | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/framework/dut.py b/framework/dut.py
index 4f376f5..4b8bd3e 100644
--- a/framework/dut.py
+++ b/framework/dut.py
@@ -1149,7 +1149,8 @@ class Dut(Crb):
             if peer is not None:
                 for remotePort in range(len(self.tester.ports_info)):
                     if self.tester.ports_info[remotePort]['type'].lower() == 'trex':
-                        if self.tester.ports_info[remotePort]['intf'].lower() == peer.lower():
+                        if self.tester.ports_info[remotePort]['intf'].lower() == peer.lower() or \
+                                self.tester.ports_info[remotePort]['pci'].lower() == peer.lower():
                             hits[remotePort] = True
                             self.ports_map[dutPort] = remotePort
                             break
-- 
2.17.1


^ permalink raw reply	[flat|nested] 8+ messages in thread

* [dts] [PATCH V1] tests/l2fwd:fix a bug
  2020-02-18  4:22 [dts] [PATCH V1] framework/dut:optimize code Haiyang Zhao
@ 2020-02-18  4:22 ` Haiyang Zhao
  2020-02-18  7:09   ` Tu, Lijuan
  2020-02-18  4:22 ` [dts] [PATCH V1] tests/vhost_virtio_pmd_interrupt:optimize code Haiyang Zhao
  2020-02-18  7:09 ` [dts] [PATCH V1] framework/dut:optimize code Tu, Lijuan
  2 siblings, 1 reply; 8+ messages in thread
From: Haiyang Zhao @ 2020-02-18  4:22 UTC (permalink / raw)
  To: dts; +Cc: Haiyang Zhao

*.delete the slice of test_queues,
  which is to reduce the test time for debuging case.

Signed-off-by: Haiyang Zhao <haiyangx.zhao@intel.com>
---
 tests/TestSuite_l2fwd.py | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/tests/TestSuite_l2fwd.py b/tests/TestSuite_l2fwd.py
index 459b9c9..382ec60 100644
--- a/tests/TestSuite_l2fwd.py
+++ b/tests/TestSuite_l2fwd.py
@@ -191,7 +191,7 @@ class TestL2fwd(TestCase):
                 self.tester.scapy_execute()
                 cnt += 1
 
-            for queues in self.test_queues[0:2]:
+            for queues in self.test_queues:
 
                 command_line = "./examples/l2fwd/build/app/l2fwd %s -- -q %s -p %s &" % \
                     (eal_params, str(queues['queues']), port_mask)
-- 
2.17.1


^ permalink raw reply	[flat|nested] 8+ messages in thread

* [dts] [PATCH V1] tests/vhost_virtio_pmd_interrupt:optimize code
  2020-02-18  4:22 [dts] [PATCH V1] framework/dut:optimize code Haiyang Zhao
  2020-02-18  4:22 ` [dts] [PATCH V1] tests/l2fwd:fix a bug Haiyang Zhao
@ 2020-02-18  4:22 ` Haiyang Zhao
  2020-02-18  7:09   ` Tu, Lijuan
  2020-02-18  7:09 ` [dts] [PATCH V1] framework/dut:optimize code Tu, Lijuan
  2 siblings, 1 reply; 8+ messages in thread
From: Haiyang Zhao @ 2020-02-18  4:22 UTC (permalink / raw)
  To: dts; +Cc: Haiyang Zhao

*.In some test env, the function get_core_list return cores 
  not as much as we expected, so use all.

Signed-off-by: Haiyang Zhao <haiyangx.zhao@intel.com>
---
 tests/TestSuite_vhost_virtio_pmd_interrupt.py | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/tests/TestSuite_vhost_virtio_pmd_interrupt.py b/tests/TestSuite_vhost_virtio_pmd_interrupt.py
index 6a76bb2..bf97a91 100644
--- a/tests/TestSuite_vhost_virtio_pmd_interrupt.py
+++ b/tests/TestSuite_vhost_virtio_pmd_interrupt.py
@@ -91,7 +91,7 @@ class TestVhostVirtioPmdInterrupt(TestCase):
         self.verify(self.cores_num >= (self.nb_cores + 1),
                     "There has not enough cores to running case: %s" %
                     self.running_case)
-        self.core_list = self.dut.get_core_list(core_config,
+        self.core_list = self.dut.get_core_list('all',
                                     socket=self.ports_socket)
 
     def prepare_vm_env(self):
-- 
2.17.1


^ permalink raw reply	[flat|nested] 8+ messages in thread

* Re: [dts] [PATCH V1] tests/l2fwd:fix a bug
  2020-02-18  4:22 ` [dts] [PATCH V1] tests/l2fwd:fix a bug Haiyang Zhao
@ 2020-02-18  7:09   ` Tu, Lijuan
  0 siblings, 0 replies; 8+ messages in thread
From: Tu, Lijuan @ 2020-02-18  7:09 UTC (permalink / raw)
  To: Zhao, HaiyangX, dts; +Cc: Zhao, HaiyangX

Applied, thanks

> -----Original Message-----
> From: dts [mailto:dts-bounces@dpdk.org] On Behalf Of Haiyang Zhao
> Sent: Tuesday, February 18, 2020 12:23 PM
> To: dts@dpdk.org
> Cc: Zhao, HaiyangX <haiyangx.zhao@intel.com>
> Subject: [dts] [PATCH V1] tests/l2fwd:fix a bug
> 
> *.delete the slice of test_queues,
>   which is to reduce the test time for debuging case.
> 
> Signed-off-by: Haiyang Zhao <haiyangx.zhao@intel.com>
> ---
>  tests/TestSuite_l2fwd.py | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/tests/TestSuite_l2fwd.py b/tests/TestSuite_l2fwd.py index
> 459b9c9..382ec60 100644
> --- a/tests/TestSuite_l2fwd.py
> +++ b/tests/TestSuite_l2fwd.py
> @@ -191,7 +191,7 @@ class TestL2fwd(TestCase):
>                  self.tester.scapy_execute()
>                  cnt += 1
> 
> -            for queues in self.test_queues[0:2]:
> +            for queues in self.test_queues:
> 
>                  command_line = "./examples/l2fwd/build/app/l2fwd %s -- -q %s -
> p %s &" % \
>                      (eal_params, str(queues['queues']), port_mask)
> --
> 2.17.1


^ permalink raw reply	[flat|nested] 8+ messages in thread

* Re: [dts] [PATCH V1] framework/dut:optimize code
  2020-02-18  4:22 [dts] [PATCH V1] framework/dut:optimize code Haiyang Zhao
  2020-02-18  4:22 ` [dts] [PATCH V1] tests/l2fwd:fix a bug Haiyang Zhao
  2020-02-18  4:22 ` [dts] [PATCH V1] tests/vhost_virtio_pmd_interrupt:optimize code Haiyang Zhao
@ 2020-02-18  7:09 ` Tu, Lijuan
  2 siblings, 0 replies; 8+ messages in thread
From: Tu, Lijuan @ 2020-02-18  7:09 UTC (permalink / raw)
  To: Zhao, HaiyangX, dts; +Cc: Zhao, HaiyangX

Applied, thanks

> -----Original Message-----
> From: dts [mailto:dts-bounces@dpdk.org] On Behalf Of Haiyang Zhao
> Sent: Tuesday, February 18, 2020 12:23 PM
> To: dts@dpdk.org
> Cc: Zhao, HaiyangX <haiyangx.zhao@intel.com>
> Subject: [dts] [PATCH V1] framework/dut:optimize code
> 
> *.test performance with trex support two port map methods,
>   add the pci map method.
> 
> Signed-off-by: Haiyang Zhao <haiyangx.zhao@intel.com>
> ---
>  framework/dut.py | 3 ++-
>  1 file changed, 2 insertions(+), 1 deletion(-)
> 
> diff --git a/framework/dut.py b/framework/dut.py index 4f376f5..4b8bd3e
> 100644
> --- a/framework/dut.py
> +++ b/framework/dut.py
> @@ -1149,7 +1149,8 @@ class Dut(Crb):
>              if peer is not None:
>                  for remotePort in range(len(self.tester.ports_info)):
>                      if self.tester.ports_info[remotePort]['type'].lower() == 'trex':
> -                        if self.tester.ports_info[remotePort]['intf'].lower() ==
> peer.lower():
> +                        if self.tester.ports_info[remotePort]['intf'].lower() ==
> peer.lower() or \
> +                                self.tester.ports_info[remotePort]['pci'].lower() ==
> peer.lower():
>                              hits[remotePort] = True
>                              self.ports_map[dutPort] = remotePort
>                              break
> --
> 2.17.1


^ permalink raw reply	[flat|nested] 8+ messages in thread

* Re: [dts] [PATCH V1] tests/vhost_virtio_pmd_interrupt:optimize code
  2020-02-18  4:22 ` [dts] [PATCH V1] tests/vhost_virtio_pmd_interrupt:optimize code Haiyang Zhao
@ 2020-02-18  7:09   ` Tu, Lijuan
  0 siblings, 0 replies; 8+ messages in thread
From: Tu, Lijuan @ 2020-02-18  7:09 UTC (permalink / raw)
  To: Zhao, HaiyangX, dts; +Cc: Zhao, HaiyangX

Applied, thanks

> -----Original Message-----
> From: dts [mailto:dts-bounces@dpdk.org] On Behalf Of Haiyang Zhao
> Sent: Tuesday, February 18, 2020 12:23 PM
> To: dts@dpdk.org
> Cc: Zhao, HaiyangX <haiyangx.zhao@intel.com>
> Subject: [dts] [PATCH V1] tests/vhost_virtio_pmd_interrupt:optimize code
> 
> *.In some test env, the function get_core_list return cores
>   not as much as we expected, so use all.
> 
> Signed-off-by: Haiyang Zhao <haiyangx.zhao@intel.com>
> ---
>  tests/TestSuite_vhost_virtio_pmd_interrupt.py | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/tests/TestSuite_vhost_virtio_pmd_interrupt.py
> b/tests/TestSuite_vhost_virtio_pmd_interrupt.py
> index 6a76bb2..bf97a91 100644
> --- a/tests/TestSuite_vhost_virtio_pmd_interrupt.py
> +++ b/tests/TestSuite_vhost_virtio_pmd_interrupt.py
> @@ -91,7 +91,7 @@ class TestVhostVirtioPmdInterrupt(TestCase):
>          self.verify(self.cores_num >= (self.nb_cores + 1),
>                      "There has not enough cores to running case: %s" %
>                      self.running_case)
> -        self.core_list = self.dut.get_core_list(core_config,
> +        self.core_list = self.dut.get_core_list('all',
>                                      socket=self.ports_socket)
> 
>      def prepare_vm_env(self):
> --
> 2.17.1


^ permalink raw reply	[flat|nested] 8+ messages in thread

* Re: [dts] [PATCH V1] framework/dut:optimize code
  2020-01-22  3:41 Haiyang Zhao
@ 2020-02-10  8:54 ` Tu, Lijuan
  0 siblings, 0 replies; 8+ messages in thread
From: Tu, Lijuan @ 2020-02-10  8:54 UTC (permalink / raw)
  To: Zhao, HaiyangX, dts; +Cc: Zhao, HaiyangX

Applied, thanks

> -----Original Message-----
> From: dts [mailto:dts-bounces@dpdk.org] On Behalf Of Haiyang Zhao
> Sent: Wednesday, January 22, 2020 11:41 AM
> To: dts@dpdk.org
> Cc: Zhao, HaiyangX <haiyangx.zhao@intel.com>
> Subject: [dts] [PATCH V1] framework/dut:optimize code
> 
> *.add a blank for eal_str if
>  need to add shared lib patch.
> 
> Signed-off-by: Haiyang Zhao <haiyangx.zhao@intel.com>
> ---
>  framework/dut.py | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/framework/dut.py b/framework/dut.py index 8af5bed..4f376f5
> 100644
> --- a/framework/dut.py
> +++ b/framework/dut.py
> @@ -224,7 +224,7 @@ class Dut(Crb):
>          use_shared_lib =
> settings.load_global_setting(settings.HOST_SHARED_LIB_SETTING)
>          shared_lib_path =
> settings.load_global_setting(settings.HOST_SHARED_LIB_PATH)
>          if use_shared_lib == 'true' and shared_lib_path and 'Virt' not in str(self):
> -            eal_str = eal_str + ' -d {}'.format(shared_lib_path)
> +            eal_str = eal_str + ' -d {} '.format(shared_lib_path)
> 
>          return eal_str
> 
> --
> 1.8.3.1


^ permalink raw reply	[flat|nested] 8+ messages in thread

* [dts] [PATCH V1] framework/dut:optimize code
@ 2020-01-22  3:41 Haiyang Zhao
  2020-02-10  8:54 ` Tu, Lijuan
  0 siblings, 1 reply; 8+ messages in thread
From: Haiyang Zhao @ 2020-01-22  3:41 UTC (permalink / raw)
  To: dts; +Cc: Haiyang Zhao

*.add a blank for eal_str if
 need to add shared lib patch.

Signed-off-by: Haiyang Zhao <haiyangx.zhao@intel.com>
---
 framework/dut.py | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/framework/dut.py b/framework/dut.py
index 8af5bed..4f376f5 100644
--- a/framework/dut.py
+++ b/framework/dut.py
@@ -224,7 +224,7 @@ class Dut(Crb):
         use_shared_lib = settings.load_global_setting(settings.HOST_SHARED_LIB_SETTING)
         shared_lib_path = settings.load_global_setting(settings.HOST_SHARED_LIB_PATH)
         if use_shared_lib == 'true' and shared_lib_path and 'Virt' not in str(self):
-            eal_str = eal_str + ' -d {}'.format(shared_lib_path)
+            eal_str = eal_str + ' -d {} '.format(shared_lib_path)
 
         return eal_str
 
-- 
1.8.3.1


^ permalink raw reply	[flat|nested] 8+ messages in thread

end of thread, other threads:[~2020-02-18  7:09 UTC | newest]

Thread overview: 8+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-02-18  4:22 [dts] [PATCH V1] framework/dut:optimize code Haiyang Zhao
2020-02-18  4:22 ` [dts] [PATCH V1] tests/l2fwd:fix a bug Haiyang Zhao
2020-02-18  7:09   ` Tu, Lijuan
2020-02-18  4:22 ` [dts] [PATCH V1] tests/vhost_virtio_pmd_interrupt:optimize code Haiyang Zhao
2020-02-18  7:09   ` Tu, Lijuan
2020-02-18  7:09 ` [dts] [PATCH V1] framework/dut:optimize code Tu, Lijuan
  -- strict thread matches above, loose matches on Subject: below --
2020-01-22  3:41 Haiyang Zhao
2020-02-10  8:54 ` Tu, Lijuan

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).