test suite reviews and discussions
 help / color / mirror / Atom feed
* [dts] [PATCH V1 0/1] metrics: add prefix for new frame work
@ 2020-03-04  2:53 yufengmx
  2020-03-04  2:53 ` [dts] [PATCH V1 1/1] " yufengmx
  2020-03-04  4:49 ` [dts] [PATCH V1 0/1] " Mo, YufengX
  0 siblings, 2 replies; 5+ messages in thread
From: yufengmx @ 2020-03-04  2:53 UTC (permalink / raw)
  To: dts, weix.xie, yinan.wang; +Cc: yufengmx

 add prefix for new frame work. 

yufengmx (1):
  metrics: add prefix for new frame work.

 tests/TestSuite_metrics.py | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

-- 
2.21.0


^ permalink raw reply	[flat|nested] 5+ messages in thread

* [dts] [PATCH V1 1/1] metrics: add prefix for new frame work.
  2020-03-04  2:53 [dts] [PATCH V1 0/1] metrics: add prefix for new frame work yufengmx
@ 2020-03-04  2:53 ` yufengmx
  2020-03-11  4:34   ` Tu, Lijuan
  2020-03-04  4:49 ` [dts] [PATCH V1 0/1] " Mo, YufengX
  1 sibling, 1 reply; 5+ messages in thread
From: yufengmx @ 2020-03-04  2:53 UTC (permalink / raw)
  To: dts, weix.xie, yinan.wang; +Cc: yufengmx


add prefix for new frame work.

Signed-off-by: yufengmx <yufengx.mo@intel.com>
---
 tests/TestSuite_metrics.py | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/tests/TestSuite_metrics.py b/tests/TestSuite_metrics.py
index 148365c..da192b9 100644
--- a/tests/TestSuite_metrics.py
+++ b/tests/TestSuite_metrics.py
@@ -187,7 +187,7 @@ class TestMetrics(TestCase):
         self.is_pmd_on = False
 
     def init_proc_info_tool(self):
-        option = ' -v -- --metrics'
+        option = f' -v -- --metrics {self.prefix}'
         self.dpdk_proc = os.path.join(
             self.target_dir, self.target, "app", "dpdk-procinfo" + option)
         self.metrics_stat = []
@@ -785,6 +785,7 @@ class TestMetrics(TestCase):
     def set_up_all(self):
         self.dut_ports = self.dut.get_ports(self.nic)
         self.verify(len(self.dut_ports) >= 2, "Not enough ports")
+        self.prefix = "dpdk_" + self.dut.prefix_subfix
         # prepare testing environment
         self.preset_test_environment()
 
-- 
2.21.0


^ permalink raw reply	[flat|nested] 5+ messages in thread

* Re: [dts] [PATCH V1 0/1] metrics: add prefix for new frame work
  2020-03-04  2:53 [dts] [PATCH V1 0/1] metrics: add prefix for new frame work yufengmx
  2020-03-04  2:53 ` [dts] [PATCH V1 1/1] " yufengmx
@ 2020-03-04  4:49 ` Mo, YufengX
  1 sibling, 0 replies; 5+ messages in thread
From: Mo, YufengX @ 2020-03-04  4:49 UTC (permalink / raw)
  To: dts; +Cc: Xie, WeiX, Wang, Yinan

Ignore this version.



> -----Original Message-----
> From: Mo, YufengX
> Sent: Wednesday, March 4, 2020 10:53 AM
> To: dts@dpdk.org; Xie, WeiX <weix.xie@intel.com>; Wang, Yinan <yinan.wang@intel.com>
> Cc: Mo, YufengX <yufengx.mo@intel.com>
> Subject: [dts][PATCH V1 0/1] metrics: add prefix for new frame work
> 
>  add prefix for new frame work.
> 
> yufengmx (1):
>   metrics: add prefix for new frame work.
> 
>  tests/TestSuite_metrics.py | 3 ++-
>  1 file changed, 2 insertions(+), 1 deletion(-)
> 
> --
> 2.21.0


^ permalink raw reply	[flat|nested] 5+ messages in thread

* Re: [dts] [PATCH V1 1/1] metrics: add prefix for new frame work.
  2020-03-04  2:53 ` [dts] [PATCH V1 1/1] " yufengmx
@ 2020-03-11  4:34   ` Tu, Lijuan
  2020-03-11  4:37     ` Tu, Lijuan
  0 siblings, 1 reply; 5+ messages in thread
From: Tu, Lijuan @ 2020-03-11  4:34 UTC (permalink / raw)
  To: Mo, YufengX, dts, Xie, WeiX, Wang, Yinan; +Cc: Mo, YufengX

Applied, thanks

> -----Original Message-----
> From: dts [mailto:dts-bounces@dpdk.org] On Behalf Of yufengmx
> Sent: Wednesday, March 4, 2020 10:53 AM
> To: dts@dpdk.org; Xie, WeiX <weix.xie@intel.com>; Wang, Yinan
> <yinan.wang@intel.com>
> Cc: Mo, YufengX <yufengx.mo@intel.com>
> Subject: [dts] [PATCH V1 1/1] metrics: add prefix for new frame work.
> 
> 
> add prefix for new frame work.
> 
> Signed-off-by: yufengmx <yufengx.mo@intel.com>
> ---
>  tests/TestSuite_metrics.py | 3 ++-
>  1 file changed, 2 insertions(+), 1 deletion(-)
> 
> diff --git a/tests/TestSuite_metrics.py b/tests/TestSuite_metrics.py index
> 148365c..da192b9 100644
> --- a/tests/TestSuite_metrics.py
> +++ b/tests/TestSuite_metrics.py
> @@ -187,7 +187,7 @@ class TestMetrics(TestCase):
>          self.is_pmd_on = False
> 
>      def init_proc_info_tool(self):
> -        option = ' -v -- --metrics'
> +        option = f' -v -- --metrics {self.prefix}'
>          self.dpdk_proc = os.path.join(
>              self.target_dir, self.target, "app", "dpdk-procinfo" + option)
>          self.metrics_stat = []
> @@ -785,6 +785,7 @@ class TestMetrics(TestCase):
>      def set_up_all(self):
>          self.dut_ports = self.dut.get_ports(self.nic)
>          self.verify(len(self.dut_ports) >= 2, "Not enough ports")
> +        self.prefix = "dpdk_" + self.dut.prefix_subfix
>          # prepare testing environment
>          self.preset_test_environment()
> 
> --
> 2.21.0


^ permalink raw reply	[flat|nested] 5+ messages in thread

* Re: [dts] [PATCH V1 1/1] metrics: add prefix for new frame work.
  2020-03-11  4:34   ` Tu, Lijuan
@ 2020-03-11  4:37     ` Tu, Lijuan
  0 siblings, 0 replies; 5+ messages in thread
From: Tu, Lijuan @ 2020-03-11  4:37 UTC (permalink / raw)
  To: Tu, Lijuan, Mo, YufengX, dts, Xie, WeiX, Wang, Yinan; +Cc: Mo, YufengX

Sorry, applied V3 not v1.

> -----Original Message-----
> From: dts [mailto:dts-bounces@dpdk.org] On Behalf Of Tu, Lijuan
> Sent: Wednesday, March 11, 2020 12:35 PM
> To: Mo, YufengX <yufengx.mo@intel.com>; dts@dpdk.org; Xie, WeiX
> <weix.xie@intel.com>; Wang, Yinan <yinan.wang@intel.com>
> Cc: Mo, YufengX <yufengx.mo@intel.com>
> Subject: Re: [dts] [PATCH V1 1/1] metrics: add prefix for new frame work.
> 
> Applied, thanks
> 
> > -----Original Message-----
> > From: dts [mailto:dts-bounces@dpdk.org] On Behalf Of yufengmx
> > Sent: Wednesday, March 4, 2020 10:53 AM
> > To: dts@dpdk.org; Xie, WeiX <weix.xie@intel.com>; Wang, Yinan
> > <yinan.wang@intel.com>
> > Cc: Mo, YufengX <yufengx.mo@intel.com>
> > Subject: [dts] [PATCH V1 1/1] metrics: add prefix for new frame work.
> >
> >
> > add prefix for new frame work.
> >
> > Signed-off-by: yufengmx <yufengx.mo@intel.com>
> > ---
> >  tests/TestSuite_metrics.py | 3 ++-
> >  1 file changed, 2 insertions(+), 1 deletion(-)
> >
> > diff --git a/tests/TestSuite_metrics.py b/tests/TestSuite_metrics.py
> > index
> > 148365c..da192b9 100644
> > --- a/tests/TestSuite_metrics.py
> > +++ b/tests/TestSuite_metrics.py
> > @@ -187,7 +187,7 @@ class TestMetrics(TestCase):
> >          self.is_pmd_on = False
> >
> >      def init_proc_info_tool(self):
> > -        option = ' -v -- --metrics'
> > +        option = f' -v -- --metrics {self.prefix}'
> >          self.dpdk_proc = os.path.join(
> >              self.target_dir, self.target, "app", "dpdk-procinfo" + option)
> >          self.metrics_stat = []
> > @@ -785,6 +785,7 @@ class TestMetrics(TestCase):
> >      def set_up_all(self):
> >          self.dut_ports = self.dut.get_ports(self.nic)
> >          self.verify(len(self.dut_ports) >= 2, "Not enough ports")
> > +        self.prefix = "dpdk_" + self.dut.prefix_subfix
> >          # prepare testing environment
> >          self.preset_test_environment()
> >
> > --
> > 2.21.0


^ permalink raw reply	[flat|nested] 5+ messages in thread

end of thread, other threads:[~2020-03-11  4:37 UTC | newest]

Thread overview: 5+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-03-04  2:53 [dts] [PATCH V1 0/1] metrics: add prefix for new frame work yufengmx
2020-03-04  2:53 ` [dts] [PATCH V1 1/1] " yufengmx
2020-03-11  4:34   ` Tu, Lijuan
2020-03-11  4:37     ` Tu, Lijuan
2020-03-04  4:49 ` [dts] [PATCH V1 0/1] " Mo, YufengX

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).