test suite reviews and discussions
 help / color / Atom feed
* [dts] [PATCH V1 0/1] tests/kni: resolve ping command compatibility
@ 2020-04-30  8:55 yufengmx
  2020-04-30  8:55 ` [dts] [PATCH V1 1/1] " yufengmx
  2020-05-06  1:42 ` [dts] [PATCH V1 0/1] " Mo, YufengX
  0 siblings, 2 replies; 6+ messages in thread
From: yufengmx @ 2020-04-30  8:55 UTC (permalink / raw)
  To: dts, lihongx.ma; +Cc: yufengmx

 resolve ping/ping6 command compatibility in low version linux os and high version linux os. 

yufengmx (1):
  tests/kni: resolve ping command compatibility

 tests/TestSuite_kni.py | 21 +++++++++++++--------
 1 file changed, 13 insertions(+), 8 deletions(-)

-- 
2.21.0


^ permalink raw reply	[flat|nested] 6+ messages in thread

* [dts] [PATCH V1 1/1] tests/kni: resolve ping command compatibility
  2020-04-30  8:55 [dts] [PATCH V1 0/1] tests/kni: resolve ping command compatibility yufengmx
@ 2020-04-30  8:55 ` " yufengmx
  2020-05-06  5:47   ` Tu, Lijuan
  2020-05-06  1:42 ` [dts] [PATCH V1 0/1] " Mo, YufengX
  1 sibling, 1 reply; 6+ messages in thread
From: yufengmx @ 2020-04-30  8:55 UTC (permalink / raw)
  To: dts, lihongx.ma; +Cc: yufengmx


resolve ping/ping6 command compatibility in low version linux os and high version linux os.

 -I interface can be either an address, or an interface name.

Signed-off-by: yufengmx <yufengx.mo@intel.com>
---
 tests/TestSuite_kni.py | 21 +++++++++++++--------
 1 file changed, 13 insertions(+), 8 deletions(-)

diff --git a/tests/TestSuite_kni.py b/tests/TestSuite_kni.py
index 3cbd457..41d8fbe 100644
--- a/tests/TestSuite_kni.py
+++ b/tests/TestSuite_kni.py
@@ -559,6 +559,7 @@ class TestKni(TestCase):
         # Setup IP address on virtual interfaces and tester ports
         self.dut.kill_all()
         self.start_kni()
+        ports_ips = {}
         for port in self.config['ports']:
             virtual_interface = self.virtual_interface_name(port)
 
@@ -567,14 +568,18 @@ class TestKni(TestCase):
             out = self.dut.send_expect(
                 "ifconfig %s up" % virtual_interface, "# ")
             time.sleep(5)
+            v_intf_ip = f"192.168.{port}.1"
+            tx_intf_ip = f"192.168.{port}.2"
             self.dut.send_expect(
-                 "ifconfig %s 192.168.%d.1 netmask 255.255.255.192" % (virtual_interface, port), "# ")
+                 "ifconfig %s %s netmask 255.255.255.192" % (v_intf_ip, port), "# ")
             self.tester.send_expect(
-                 "ifconfig %s 192.168.%d.2 netmask 255.255.255.192" % (tx_interface, port), "# ")
+                 "ifconfig %s %s netmask 255.255.255.192" % (tx_intf_ip, port), "# ")
+            ports_ips[port] = [tx_intf_ip, v_intf_ip]
             self.tester.enable_ipv6(tx_interface)
             time.sleep(5)
         # Send ping requests and check for answers
         for port in self.config['ports']:
+            tx_intf_ip, v_intf_ip = ports_ips[port]
 
             tx_port = self.tester.get_local_port(port)
             tx_interface = self.tester.get_interface(tx_port)
@@ -582,17 +587,17 @@ class TestKni(TestCase):
             virtual_interface = self.virtual_interface_name(port)
 
             out = self.dut.send_expect(
-                "ping -w 2 -I %s 192.168.%d.2" % (virtual_interface, port), "# ", 10)
+                "ping -w 2 -I %s 192.168.%d.2" % (v_intf_ip, port), "# ", 10)
             self.verify("64 bytes from 192.168.%d.2:" %
                         port in out, "ping not supported")
 
             out = self.tester.send_expect(
-                "ping -w 1 -I %s 192.168.%d.1" % (tx_interface, port), "# ", 10)
+                "ping -w 1 -I %s 192.168.%d.1" % (tx_intf_ip, port), "# ", 10)
             self.verify("64 bytes from 192.168.%d.1:" %
                         port in out, "kni cannot reply ping packet")
 
             out = self.dut.send_expect(
-                "ping -w 1 -I %s 192.168.%d.123" % (virtual_interface, port), "# ", 10)
+                "ping -w 1 -I %s 192.168.%d.123" % (v_intf_ip, port), "# ", 10)
             self.verify(
                 "0 received, 100% packet loss" in out, "ping not supported")
 
@@ -601,14 +606,14 @@ class TestKni(TestCase):
             ipv6_address = out.split('\r\n')[0]
 
             out = self.dut.send_expect("ping6 -w 1 -I %s %s" %
-                                       (virtual_interface, str(ipv6_address)), "# ", 10)
+                                       (v_intf_ip, str(ipv6_address)), "# ", 10)
             # FC25 ping6 output info is "64 bytes from ipv6_address%v: icmp_seq=1 ttl=64"
             # other os ping6 output is "64 bytes from ipv6_address: icmp_seq=1 ttl=64"
             self.verify("64 bytes from %s" %
                         ipv6_address in out, "ping6 not supported")
 
             out = self.tester.send_expect(
-                "ping6 -w 1 -I %s %s" % (tx_interface, str(ipv6_address)), "# ", 10)
+                "ping6 -w 1 -I %s %s" % (tx_intf_ip, str(ipv6_address)), "# ", 10)
             self.verify("64 bytes from %s" %
                         ipv6_address in out, "kni cannot reply ping6 packet")
 
@@ -621,7 +626,7 @@ class TestKni(TestCase):
                     break
 
             out = self.dut.send_expect("ping6 -w 1 -I %s %s" %
-                                       (virtual_interface, ''.join(ipv6list)), "# ", 10)
+                                       (v_intf_ip, ''.join(ipv6list)), "# ", 10)
             self.verify(
                 "0 received, 100% packet loss" in out, "ping6 not supported")
             # remove ip from tester
-- 
2.21.0


^ permalink raw reply	[flat|nested] 6+ messages in thread

* Re: [dts] [PATCH V1 0/1] tests/kni: resolve ping command compatibility
  2020-04-30  8:55 [dts] [PATCH V1 0/1] tests/kni: resolve ping command compatibility yufengmx
  2020-04-30  8:55 ` [dts] [PATCH V1 1/1] " yufengmx
@ 2020-05-06  1:42 ` " Mo, YufengX
  1 sibling, 0 replies; 6+ messages in thread
From: Mo, YufengX @ 2020-05-06  1:42 UTC (permalink / raw)
  To: dts, Ma, LihongX; +Cc: Mo, YufengX

Tested by Mo, YufengX <yufengx.mo@intel.com>



> -----Original Message-----
> From: Mo, YufengX
> Sent: Thursday, April 30, 2020 4:56 PM
> To: dts@dpdk.org; Ma, LihongX <lihongx.ma@intel.com>
> Cc: Mo, YufengX <yufengx.mo@intel.com>
> Subject: [dts][PATCH V1 0/1] tests/kni: resolve ping command compatibility
> 
>  resolve ping/ping6 command compatibility in low version linux os and high version linux os.
> 
> yufengmx (1):
>   tests/kni: resolve ping command compatibility
> 
>  tests/TestSuite_kni.py | 21 +++++++++++++--------
>  1 file changed, 13 insertions(+), 8 deletions(-)
> 
> --
> 2.21.0


^ permalink raw reply	[flat|nested] 6+ messages in thread

* Re: [dts] [PATCH V1 1/1] tests/kni: resolve ping command compatibility
  2020-04-30  8:55 ` [dts] [PATCH V1 1/1] " yufengmx
@ 2020-05-06  5:47   ` Tu, Lijuan
  0 siblings, 0 replies; 6+ messages in thread
From: Tu, Lijuan @ 2020-05-06  5:47 UTC (permalink / raw)
  To: Mo, YufengX, dts, Ma,  LihongX; +Cc: Mo, YufengX

Applied, thanks

> -----Original Message-----
> From: dts [mailto:dts-bounces@dpdk.org] On Behalf Of yufengmx
> Sent: Thursday, April 30, 2020 4:56 PM
> To: dts@dpdk.org; Ma, LihongX <lihongx.ma@intel.com>
> Cc: Mo, YufengX <yufengx.mo@intel.com>
> Subject: [dts] [PATCH V1 1/1] tests/kni: resolve ping command compatibility
> 
> 
> resolve ping/ping6 command compatibility in low version linux os and high
> version linux os.
> 
>  -I interface can be either an address, or an interface name.
> 
> Signed-off-by: yufengmx <yufengx.mo@intel.com>
> ---
>  tests/TestSuite_kni.py | 21 +++++++++++++--------
>  1 file changed, 13 insertions(+), 8 deletions(-)
> 
> diff --git a/tests/TestSuite_kni.py b/tests/TestSuite_kni.py index
> 3cbd457..41d8fbe 100644
> --- a/tests/TestSuite_kni.py
> +++ b/tests/TestSuite_kni.py
> @@ -559,6 +559,7 @@ class TestKni(TestCase):
>          # Setup IP address on virtual interfaces and tester ports
>          self.dut.kill_all()
>          self.start_kni()
> +        ports_ips = {}
>          for port in self.config['ports']:
>              virtual_interface = self.virtual_interface_name(port)
> 
> @@ -567,14 +568,18 @@ class TestKni(TestCase):
>              out = self.dut.send_expect(
>                  "ifconfig %s up" % virtual_interface, "# ")
>              time.sleep(5)
> +            v_intf_ip = f"192.168.{port}.1"
> +            tx_intf_ip = f"192.168.{port}.2"
>              self.dut.send_expect(
> -                 "ifconfig %s 192.168.%d.1 netmask 255.255.255.192" %
> (virtual_interface, port), "# ")
> +                 "ifconfig %s %s netmask 255.255.255.192" % (v_intf_ip,
> + port), "# ")
>              self.tester.send_expect(
> -                 "ifconfig %s 192.168.%d.2 netmask 255.255.255.192" %
> (tx_interface, port), "# ")
> +                 "ifconfig %s %s netmask 255.255.255.192" % (tx_intf_ip, port), "# ")
> +            ports_ips[port] = [tx_intf_ip, v_intf_ip]
>              self.tester.enable_ipv6(tx_interface)
>              time.sleep(5)
>          # Send ping requests and check for answers
>          for port in self.config['ports']:
> +            tx_intf_ip, v_intf_ip = ports_ips[port]
> 
>              tx_port = self.tester.get_local_port(port)
>              tx_interface = self.tester.get_interface(tx_port)
> @@ -582,17 +587,17 @@ class TestKni(TestCase):
>              virtual_interface = self.virtual_interface_name(port)
> 
>              out = self.dut.send_expect(
> -                "ping -w 2 -I %s 192.168.%d.2" % (virtual_interface, port), "# ", 10)
> +                "ping -w 2 -I %s 192.168.%d.2" % (v_intf_ip, port), "#
> + ", 10)
>              self.verify("64 bytes from 192.168.%d.2:" %
>                          port in out, "ping not supported")
> 
>              out = self.tester.send_expect(
> -                "ping -w 1 -I %s 192.168.%d.1" % (tx_interface, port), "# ", 10)
> +                "ping -w 1 -I %s 192.168.%d.1" % (tx_intf_ip, port), "#
> + ", 10)
>              self.verify("64 bytes from 192.168.%d.1:" %
>                          port in out, "kni cannot reply ping packet")
> 
>              out = self.dut.send_expect(
> -                "ping -w 1 -I %s 192.168.%d.123" % (virtual_interface, port), "# ", 10)
> +                "ping -w 1 -I %s 192.168.%d.123" % (v_intf_ip, port),
> + "# ", 10)
>              self.verify(
>                  "0 received, 100% packet loss" in out, "ping not supported")
> 
> @@ -601,14 +606,14 @@ class TestKni(TestCase):
>              ipv6_address = out.split('\r\n')[0]
> 
>              out = self.dut.send_expect("ping6 -w 1 -I %s %s" %
> -                                       (virtual_interface, str(ipv6_address)), "# ", 10)
> +                                       (v_intf_ip, str(ipv6_address)),
> + "# ", 10)
>              # FC25 ping6 output info is "64 bytes from ipv6_address%v:
> icmp_seq=1 ttl=64"
>              # other os ping6 output is "64 bytes from ipv6_address: icmp_seq=1
> ttl=64"
>              self.verify("64 bytes from %s" %
>                          ipv6_address in out, "ping6 not supported")
> 
>              out = self.tester.send_expect(
> -                "ping6 -w 1 -I %s %s" % (tx_interface, str(ipv6_address)), "# ", 10)
> +                "ping6 -w 1 -I %s %s" % (tx_intf_ip,
> + str(ipv6_address)), "# ", 10)
>              self.verify("64 bytes from %s" %
>                          ipv6_address in out, "kni cannot reply ping6 packet")
> 
> @@ -621,7 +626,7 @@ class TestKni(TestCase):
>                      break
> 
>              out = self.dut.send_expect("ping6 -w 1 -I %s %s" %
> -                                       (virtual_interface, ''.join(ipv6list)), "# ", 10)
> +                                       (v_intf_ip, ''.join(ipv6list)),
> + "# ", 10)
>              self.verify(
>                  "0 received, 100% packet loss" in out, "ping6 not supported")
>              # remove ip from tester
> --
> 2.21.0


^ permalink raw reply	[flat|nested] 6+ messages in thread

* Re: [dts] [PATCH V1 0/1] tests/kni: resolve ping command compatibility
  2020-05-11  2:29 yufengmx
@ 2020-05-11  2:34 ` Zhang, XiX
  0 siblings, 0 replies; 6+ messages in thread
From: Zhang, XiX @ 2020-05-11  2:34 UTC (permalink / raw)
  To: Mo, YufengX, dts, Ma,  LihongX

Tested-by:xix.zhang@intel.com

-----Original Message-----
From: Mo, YufengX 
Sent: Monday, May 11, 2020 10:30 AM
To: dts@dpdk.org; Ma, LihongX <lihongx.ma@intel.com>; Zhang, XiX <xix.zhang@intel.com>
Cc: Mo, YufengX <yufengx.mo@intel.com>
Subject: [dts][PATCH V1 0/1] tests/kni: resolve ping command compatibility 

 fix previous version missing merged code. 
 add more redundant processing. 

yufengmx (1):
  tests/kni: resolve ping command compatibility

 tests/TestSuite_kni.py | 53 ++++++++++++++++++++++++++----------------
 1 file changed, 33 insertions(+), 20 deletions(-)

-- 
2.21.0


^ permalink raw reply	[flat|nested] 6+ messages in thread

* [dts] [PATCH V1 0/1] tests/kni: resolve ping command compatibility
@ 2020-05-11  2:29 yufengmx
  2020-05-11  2:34 ` Zhang, XiX
  0 siblings, 1 reply; 6+ messages in thread
From: yufengmx @ 2020-05-11  2:29 UTC (permalink / raw)
  To: dts, lihongx.ma, xix.zhang; +Cc: yufengmx

 fix previous version missing merged code. 
 add more redundant processing. 

yufengmx (1):
  tests/kni: resolve ping command compatibility

 tests/TestSuite_kni.py | 53 ++++++++++++++++++++++++++----------------
 1 file changed, 33 insertions(+), 20 deletions(-)

-- 
2.21.0


^ permalink raw reply	[flat|nested] 6+ messages in thread

end of thread, back to index

Thread overview: 6+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-04-30  8:55 [dts] [PATCH V1 0/1] tests/kni: resolve ping command compatibility yufengmx
2020-04-30  8:55 ` [dts] [PATCH V1 1/1] " yufengmx
2020-05-06  5:47   ` Tu, Lijuan
2020-05-06  1:42 ` [dts] [PATCH V1 0/1] " Mo, YufengX
2020-05-11  2:29 yufengmx
2020-05-11  2:34 ` Zhang, XiX

test suite reviews and discussions

Archives are clonable:
	git clone --mirror http://inbox.dpdk.org/dts/0 dts/git/0.git

	# If you have public-inbox 1.1+ installed, you may
	# initialize and index your mirror using the following commands:
	public-inbox-init -V2 dts dts/ http://inbox.dpdk.org/dts \
		dts@dpdk.org
	public-inbox-index dts


Newsgroup available over NNTP:
	nntp://inbox.dpdk.org/inbox.dpdk.dts


AGPL code for this site: git clone https://public-inbox.org/ public-inbox