[-- Attachment #1: Type: text/plain, Size: 550 bytes --] Tested-by: Chen, LingliX <linglix.chen@intel.com> Regards, Chen, LingliX > -----Original Message----- > From: Chen Linglix [mailto:linglix.chen@intel.com] > Sent: Tuesday, November 3, 2020 11:24 PM > To: dts@dpdk.org > Cc: Chen, LingliX <linglix.chen@intel.com> > Subject: [dts][PATCH V1 > 0/2]tests/TestSuite_shutdown_api:change_thresholds:not support rx > > fix this issues: > 1. CVL and FVL not support tx and rx > 2.Ixgbe not support rx, only support tx > 3.foxville, powerville and springville not support txfree and txrs [-- Attachment #2: TestShutdownApi-foxville-powerville.log --] [-- Type: application/octet-stream, Size: 61140 bytes --] [-- Attachment #3: TestShutdownApi-NA.log --] [-- Type: application/octet-stream, Size: 1668 bytes --] 03/11/2020 20:07:39 dts: TEST SUITE : TestShutdownApi 03/11/2020 20:07:39 dts: NIC : fortville_eagle 03/11/2020 20:07:40 dut.10.240.183.134: 03/11/2020 20:07:40 tester: 03/11/2020 20:07:40 dut.10.240.183.134: NUMA not supported 03/11/2020 20:07:40 TestShutdownApi: set_up_all failed: Traceback (most recent call last): File "/home/autoregression/1102/dts/framework/test_case.py", line 258, in execute_setup_all self.set_up_all() File "tests/TestSuite_shutdown_api.py", line 78, in set_up_all self.tester.get_interface(self.tester.get_local_port(port)), 5000), "# ") File "/home/autoregression/1102/dts/framework/tester.py", line 271, in get_interface raise ParameterInvalidException("local port should not be -1") exception.ParameterInvalidException: local port should not be -1 03/11/2020 20:07:40 dts: TEST SUITE ENDED: TestShutdownApi 03/11/2020 20:13:18 dts: TEST SUITE : TestShutdownApi 03/11/2020 20:13:18 dts: NIC : fortville_eagle 03/11/2020 20:13:18 dut.10.240.183.134: 03/11/2020 20:13:19 tester: 03/11/2020 20:13:19 dut.10.240.183.134: NUMA not supported 03/11/2020 20:13:19 tester: ifconfig ens9 mtu 5000 03/11/2020 20:13:19 tester: 03/11/2020 20:13:19 TestShutdownApi: Test Case test_change_thresholds Result SKIPPED: 03/11/2020 20:13:19 dts: TEST SUITE ENDED: TestShutdownApi [-- Attachment #4: TestShutdownApi-NNT.log --] [-- Type: application/octet-stream, Size: 15912 bytes --]
fix this issues: 1. CVL and FVL not support tx and rx 2.Ixgbe not support rx, only support tx 3.foxville, powerville and springville not support txfree and txrs Chen Linglix (2): conf/test_case_checklist:change_thresholds:CVL and FVL not support this case(DPDK-24129) tests/TestSuite_shutdown_api:change_thresholds:Ixgbe not support rx, only support tx conf/test_case_checklist.json | 22 ++++++++++++++++++++++ tests/TestSuite_shutdown_api.py | 30 ++++++++++++++++++------------ 2 files changed, 40 insertions(+), 12 deletions(-) -- 2.25.1
change_thresholds:CVL and FVL not support this case(DPDK-24129) Signed-off-by: Chen Linglix <linglix.chen@intel.com> --- conf/test_case_checklist.json | 22 ++++++++++++++++++++++ 1 file changed, 22 insertions(+) diff --git a/conf/test_case_checklist.json b/conf/test_case_checklist.json index 74dade7a..79100e2a 100644 --- a/conf/test_case_checklist.json +++ b/conf/test_case_checklist.json @@ -3515,5 +3515,27 @@ "Bug ID": "", "Comments": "the nic not support this case" } + ], + "change_thresholds": [ + { + "OS": [ + "ALL" + ], + "NIC": [ + "columbiaville_100g", + "columbiaville_25g", + "fortville_eagle", + "fortville_spirit", + "fortpark_TLV", + "fortpark_BASE-T", + "fortville_25g", + "carlsville" + ], + "Target": [ + "ALL" + ], + "Bug ID": "DPDK-24129", + "Comments": "CVL and FVL not support this case" + } ] } -- 2.25.1
DPDK-24129:1.Ixgbe not support rx, only support tx. 2.foxville, powerville and springville not support txfree and txrs 3.foxville--eth_igc_tx_queue_setup(): To improve 2.5G driver performance, consider setting the TX WTHRESH value to 4, 8, or 16. Signed-off-by: Chen Linglix <linglix.chen@intel.com> --- tests/TestSuite_shutdown_api.py | 30 ++++++++++++++++++------------ 1 file changed, 18 insertions(+), 12 deletions(-) diff --git a/tests/TestSuite_shutdown_api.py b/tests/TestSuite_shutdown_api.py index edd1dcfa..1e98c640 100644 --- a/tests/TestSuite_shutdown_api.py +++ b/tests/TestSuite_shutdown_api.py @@ -706,34 +706,40 @@ class TestShutdownApi(TestCase): def test_change_thresholds(self): """ Change RX/TX thresholds + DPDK-24129:1.CVL and FVL not support tx and rx + 2.Ixgbe not support rx, only support tx. + 3.foxville, powerville and springville not support txfree and txrs """ self.pmdout.start_testpmd("Default", "--portmask=%s --port-topology=loop" % utils.create_mask(self.ports), socket=self.ports_socket) self.dut.send_expect("set promisc all off", "testpmd>") self.dut.send_expect("port stop all", "testpmd> ", 100) - self.dut.send_expect("port config all txfreet 32", "testpmd> ") - self.dut.send_expect("port config all txrst 32", "testpmd> ") + if self.nic in ["sagepond","sageville","twinpond","niantic"]: + self.dut.send_expect("port config all txfreet 32", "testpmd> ") + self.dut.send_expect("port config all txrst 32", "testpmd> ") self.dut.send_expect("port config all rxfreet 32", "testpmd> ") self.dut.send_expect("port config all txpt 64", "testpmd> ") self.dut.send_expect("port config all txht 64", "testpmd> ") - self.dut.send_expect("port config all txwt 0", "testpmd> ") - self.dut.send_expect("port config all rxpt 64", "testpmd> ") - self.dut.send_expect("port config all rxht 64", "testpmd> ") - self.dut.send_expect("port config all rxwt 64", "testpmd> ") + if self.nic in ["foxville"]: + self.dut.send_expect("port config all txwt 16", "testpmd> ") + else: + self.dut.send_expect("port config all txwt 0", "testpmd> ") + self.dut.send_expect("port start all", "testpmd> ", 100) out = self.dut.send_expect("show config rxtx", "testpmd> ") self.verify("RX free threshold=32" in out, "RX descriptor not reconfigured properly") - self.verify("TX free threshold=32" in out, + if self.nic in ["sagepond","sageville","twinpond","niantic"]: + self.verify("TX free threshold=32" in out, "TX descriptor not reconfigured properly") - self.verify("TX RS bit threshold=32" in out, + self.verify("TX RS bit threshold=32" in out, "TX descriptor not reconfigured properly") self.verify("pthresh=64" in out, "TX descriptor not reconfigured properly") self.verify("hthresh=64" in out, "TX descriptor not reconfigured properly") - self.verify("wthresh=64" in out, "TX descriptor not reconfigured properly") - self.verify("pthresh=64" in out, "TX descriptor not reconfigured properly") - self.verify("hthresh=64" in out, "TX descriptor not reconfigured properly") - self.verify("wthresh=64" in out, "TX descriptor not reconfigured properly") + if self.nic in ["foxville"]: + self.verify("wthresh=16" in out, "TX descriptor not reconfigured properly") + else: + self.verify("wthresh=0" in out, "TX descriptor not reconfigured properly") self.dut.send_expect("set fwd mac", "testpmd>") self.dut.send_expect("start", "testpmd> ") self.check_forwarding() -- 2.25.1
> fix this issues:
> 1. CVL and FVL not support tx and rx
> 2.Ixgbe not support rx, only support tx
> 3.foxville, powerville and springville not support txfree and txrs
>
> Chen Linglix (2):
> conf/test_case_checklist:change_thresholds:CVL and FVL not support
> this case(DPDK-24129)
> tests/TestSuite_shutdown_api:change_thresholds:Ixgbe not support rx,
> only support tx
Applied with commit message changed. Removed Intel internal info, e.g. dpdk-xxx