test suite reviews and discussions
 help / color / mirror / Atom feed
From: Haiyang Zhao <haiyangx.zhao@intel.com>
To: dts@dpdk.org, lijuan.tu@intel.com
Cc: Haiyang Zhao <haiyangx.zhao@intel.com>
Subject: [dts] [PATCH V1 1/2] framework/project_dpdk: drop the detailed errors when complie failed
Date: Fri, 13 Nov 2020 18:06:04 +0800	[thread overview]
Message-ID: <20201113100605.20669-2-haiyangx.zhao@intel.com> (raw)
In-Reply-To: <20201113100605.20669-1-haiyangx.zhao@intel.com>

the detailed compiled info is too long and will be saved
into log file, so there's no need to throw it in assert exception.

Signed-off-by: Haiyang Zhao <haiyangx.zhao@intel.com>
---
 framework/project_dpdk.py | 6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)

diff --git a/framework/project_dpdk.py b/framework/project_dpdk.py
index a41b3df..fbbc78d 100644
--- a/framework/project_dpdk.py
+++ b/framework/project_dpdk.py
@@ -314,7 +314,7 @@ class DPDKdut(Dut):
         assert ("FAILED" not in out), "meson setup failed ..."
 
         out = self.send_expect("ninja -C %s -j %d" % (target, self.number_of_cores), "# ", build_time)
-        assert ("FAILED" not in out), "ninja complie failed ...\r\n %s" % out
+        assert ("FAILED" not in out), "ninja complie failed ..."
 
         # copy kmod file to the folder same as make
         out = self.send_expect("find ./%s/kernel/ -name *.ko" % target, "# ", verify=True)
@@ -555,9 +555,9 @@ class DPDKdut(Dut):
         else:
             example = '/'.join(folder_info[folder_info.index('examples')+1:])
         out = self.send_expect("meson configure -Dexamples=%s %s" % (example, self.target), "# ")
-        assert ("FAILED" not in out), "Compilation error... \r\n %s" % out
+        assert ("FAILED" not in out), "Compilation error..."
         out = self.send_expect("ninja -C %s" % self.target, "# ", timeout)
-        assert ("FAILED" not in out), "Compilation error... \r\n %s" % out
+        assert ("FAILED" not in out), "Compilation error..."
 
         # verify the app build in the config path
         if example != 'all':
-- 
2.17.1


  reply	other threads:[~2020-11-13 10:11 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-11-13 10:06 [dts] [PATCH V1 0/2] framework: fix error msg too long cause saving result failed Haiyang Zhao
2020-11-13 10:06 ` Haiyang Zhao [this message]
2020-11-13 10:06 ` [dts] [PATCH V1 2/2] framework/excel_reporter: fix issue of msg exceed xlwt maximum cell length Haiyang Zhao
2020-11-13 10:18 ` [dts] [PATCH V1 0/2] framework: fix error msg too long cause saving result failed Zhao, HaiyangX
2020-11-18  3:26 ` Tu, Lijuan

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20201113100605.20669-2-haiyangx.zhao@intel.com \
    --to=haiyangx.zhao@intel.com \
    --cc=dts@dpdk.org \
    --cc=lijuan.tu@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).