From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 4FB73A04E7; Wed, 18 Nov 2020 07:07:08 +0100 (CET) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 3BFBDC8B0; Wed, 18 Nov 2020 07:07:07 +0100 (CET) Received: from mga12.intel.com (mga12.intel.com [192.55.52.136]) by dpdk.org (Postfix) with ESMTP id E2D875946 for ; Wed, 18 Nov 2020 07:07:04 +0100 (CET) IronPort-SDR: e3Mh1NPO5INmzKmOKCK3KozYBVVdLviJs2yaQZqIeX+1fdLNTjSmqu579tN2yHsQraOGYwhZrS 7o4JC147CP4w== X-IronPort-AV: E=McAfee;i="6000,8403,9808"; a="150340402" X-IronPort-AV: E=Sophos;i="5.77,486,1596524400"; d="scan'208";a="150340402" X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from orsmga004.jf.intel.com ([10.7.209.38]) by fmsmga106.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 17 Nov 2020 22:07:02 -0800 IronPort-SDR: 4YaO5t8wGe5txcJ33QjblLeINXyAai2qUnHSWW9lDLovyEsnkf3rhwbiUJVz7UiHVeHDiwq6Q2 eU7ZhyKd9Qfw== X-IronPort-AV: E=Sophos;i="5.77,486,1596524400"; d="scan'208";a="476192224" Received: from unknown (HELO localhost.localdomain) ([10.240.183.57]) by orsmga004-auth.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 17 Nov 2020 22:07:01 -0800 From: Haiyang Zhao To: dts@dpdk.org, lijuan.tu@intel.com Cc: Haiyang Zhao Date: Wed, 18 Nov 2020 14:01:14 +0800 Message-Id: <20201118060114.14553-3-haiyangx.zhao@intel.com> X-Mailer: git-send-email 2.17.1 In-Reply-To: <20201118060114.14553-1-haiyangx.zhao@intel.com> References: <20201118060114.14553-1-haiyangx.zhao@intel.com> Subject: [dts] [PATCH V1 2/2] framework/dut: optmize code when setting eal param for rx mode X-BeenThere: dts@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: test suite reviews and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dts-bounces@dpdk.org Sender: "dts" Dynamically adding rx mode eal parameter is only supported with meson build, so add a jugement to fix the potential bug. Signed-off-by: Haiyang Zhao --- framework/dut.py | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/framework/dut.py b/framework/dut.py index d6862e8..2863848 100644 --- a/framework/dut.py +++ b/framework/dut.py @@ -230,7 +230,9 @@ class Dut(Crb): if use_shared_lib == 'true' and shared_lib_path and 'Virt' not in str(self): eal_str = eal_str + ' -d {} '.format(shared_lib_path) rx_mode = settings.load_global_setting(settings.DPDK_RXMODE_SETTING) - if 'other_eal_param' not in config or 'force-max-simd-bitwidth' not in config['other_eal_param']: + build_type = settings.load_global_setting(settings.HOST_BUILD_TYPE_SETTING) + if build_type == 'meson' and ('other_eal_param' not in config or + 'force-max-simd-bitwidth' not in config['other_eal_param']): if rx_mode == 'novector': eal_str = eal_str + ' --force-max-simd-bitwidth=64 ' elif rx_mode == 'sse': -- 2.17.1