test suite reviews and discussions
 help / color / mirror / Atom feed
From: Zhou Jun <junx.w.zhou@intel.com>
To: dts@dpdk.org
Cc: Zhou Jun <junx.w.zhou@intel.com>
Subject: [dts] [dts 11/28] tests/TestSuite_l3fwdacl:Modify the hard coded app parameter to call the platform interface
Date: Tue,  8 Dec 2020 18:06:10 +0800	[thread overview]
Message-ID: <20201208100627.9792-12-junx.w.zhou@intel.com> (raw)
In-Reply-To: <20201208100627.9792-1-junx.w.zhou@intel.com>

Signed-off-by: Zhou Jun <junx.w.zhou@intel.com>
---
 tests/TestSuite_l3fwdacl.py | 21 +++++++++++----------
 1 file changed, 11 insertions(+), 10 deletions(-)

diff --git a/tests/TestSuite_l3fwdacl.py b/tests/TestSuite_l3fwdacl.py
index cc87e172..7e0ad989 100644
--- a/tests/TestSuite_l3fwdacl.py
+++ b/tests/TestSuite_l3fwdacl.py
@@ -172,8 +172,8 @@ class TestL3fwdacl(TestCase):
         if scalar:
             extra_args = '--alg="scalar"'
 
-        cmdline = '%s -c %s -n %d -- -p %s --config="(%d,0,2),(%d,0,3)" --rule_ipv4="%s" --rule_ipv6="%s" %s' % \
-                  (self.app_l3fwd_acl_path, self.core_mask, self.dut.get_memory_channels(),
+        cmdline = '%s %s -- -p %s --config="(%d,0,2),(%d,0,3)" --rule_ipv4="%s" --rule_ipv6="%s" %s' % \
+                  (self.app_l3fwd_acl_path, self.eal_para,
                    self.port_mask, self.dut_ports[0], self.dut_ports[1],
                    TestL3fwdacl.acl_ipv4_db,
                    TestL3fwdacl.acl_ipv6_db,
@@ -591,8 +591,8 @@ class TestL3fwdacl(TestCase):
         rule_list.append(TestL3fwdacl.default_rule)
         self.create_acl_ipv4_db(rule_list)
 
-        cmdline = '%s -c %s -n %d -- -p %s --config="(%d,0,2),(%d,0,3)" --rule_ipv4="%s" --rule_ipv6="%s"' % \
-                  (self.app_l3fwd_acl_path, self.core_mask, self.dut.get_memory_channels(),
+        cmdline = '%s %s -- -p %s --config="(%d,0,2),(%d,0,3)" --rule_ipv4="%s" --rule_ipv6="%s"' % \
+                  (self.app_l3fwd_acl_path, self.eal_para,
                    self.port_mask, self.dut_ports[0], self.dut_ports[1],
                    TestL3fwdacl.acl_ipv4_db, TestL3fwdacl.acl_ipv6_db)
 
@@ -610,8 +610,8 @@ class TestL3fwdacl(TestCase):
         rule_list.append(TestL3fwdacl.default_rule)
         self.create_acl_ipv6_db(rule_list)
 
-        cmdline = '%s -c %s -n %d -- -p %s --config="(%d,0,2),(%d,0,3)" --rule_ipv4="%s" --rule_ipv6="%s"' % \
-                  (self.app_l3fwd_acl_path, self.core_mask, self.dut.get_memory_channels(),
+        cmdline = '%s %s -- -p %s --config="(%d,0,2),(%d,0,3)" --rule_ipv4="%s" --rule_ipv6="%s"' % \
+                  (self.app_l3fwd_acl_path, self.eal_para,
                    self.port_mask, self.dut_ports[0], self.dut_ports[1],
                    TestL3fwdacl.acl_ipv4_db, TestL3fwdacl.acl_ipv6_db)
 
@@ -636,6 +636,7 @@ class TestL3fwdacl(TestCase):
         cores = self.get_core_list()
         self.verify(cores is not None, "Insufficient cores for speed testing")
 
+        self.eal_para = self.dut.create_eal_parameters(cores=self.get_core_list())
         self.core_mask = utils.create_mask(cores)
         print("Core mask: %s" % self.core_mask)
 
@@ -840,8 +841,8 @@ class TestL3fwdacl(TestCase):
         rule_list_ipv4.append(TestL3fwdacl.invalid_port_rule_ipv4)
         self.create_acl_ipv4_db(rule_list_ipv4)
 
-        cmdline = '%s -c %s -n %d -- -p %s --config="(%d,0,2),(%d,0,3)" --rule_ipv4="%s" --rule_ipv6="%s" --alg="scalar"' % \
-                  (self.app_l3fwd_acl_path, self.core_mask, self.dut.get_memory_channels(),
+        cmdline = '%s %s -- -p %s --config="(%d,0,2),(%d,0,3)" --rule_ipv4="%s" --rule_ipv6="%s" --alg="scalar"' % \
+                  (self.app_l3fwd_acl_path, self.eal_para,
                    self.port_mask, self.dut_ports[0], self.dut_ports[1],
                    TestL3fwdacl.acl_ipv4_db, TestL3fwdacl.acl_ipv6_db)
 
@@ -852,8 +853,8 @@ class TestL3fwdacl(TestCase):
         rule_list_ipv6.append(TestL3fwdacl.invalid_port_rule_ipv6)
         self.create_acl_ipv6_db(rule_list_ipv6)
 
-        cmdline = '%s -c %s -n %d -- -p %s --config="(%d,0,2),(%d,0,3)" --rule_ipv4="%s" --rule_ipv6="%s" --alg="scalar"' % \
-                  (self.app_l3fwd_acl_path, self.core_mask, self.dut.get_memory_channels(),
+        cmdline = '%s %s -- -p %s --config="(%d,0,2),(%d,0,3)" --rule_ipv4="%s" --rule_ipv6="%s" --alg="scalar"' % \
+                  (self.app_l3fwd_acl_path, self.eal_para,
                    self.port_mask, self.dut_ports[0], self.dut_ports[1],
                    TestL3fwdacl.acl_ipv4_db, TestL3fwdacl.acl_ipv6_db)
 
-- 
2.17.1


  parent reply	other threads:[~2020-12-08 10:04 UTC|newest]

Thread overview: 31+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-12-08 10:05 [dts] [PATCH V1 00/28] Modify " Zhou Jun
2020-12-08 10:06 ` [dts] [dts 01/28] tests/TestSuite_hello_world:Modify " Zhou Jun
2020-12-08 10:06 ` [dts] [dts 02/28] tests/TestSuite_hotplug:Modify " Zhou Jun
2020-12-08 10:06 ` [dts] [dts 03/28] tests/TestSuite_inline_ipsec:Modify " Zhou Jun
2020-12-08 10:06 ` [dts] [dts 04/28] tests/TestSuite_interrupt_pmd:Modify " Zhou Jun
2020-12-08 10:06 ` [dts] [dts 05/28] tests/TestSuite_ip_pipeline:Modify " Zhou Jun
2020-12-08 10:06 ` [dts] [dts 06/28] tests/TestSuite_ipfrag:Modify " Zhou Jun
2020-12-08 10:06 ` [dts] [dts 07/28] tests/TestSuite_ipv4_reassembly:Modify " Zhou Jun
2020-12-08 10:06 ` [dts] [dts 08/28] tests/TestSuite_keep_alive:Modify " Zhou Jun
2020-12-08 10:06 ` [dts] [dts 09/28] tests/TestSuite_kni:Modify " Zhou Jun
2020-12-08 10:06 ` [dts] [dts 10/28] tests/TestSuite_l2fwd_jobstats:Modify " Zhou Jun
2020-12-08 10:06 ` Zhou Jun [this message]
2020-12-08 10:06 ` [dts] [dts 12/28] tests/TestSuite_link_status_interrupt:Modify " Zhou Jun
2020-12-08 10:06 ` [dts] [dts 13/28] tests/TestSuite_metering_and_policing:Modify " Zhou Jun
2020-12-08 10:06 ` [dts] [dts 14/28] tests/TestSuite_multicast:Modify " Zhou Jun
2020-12-08 10:06 ` [dts] [dts 15/28] tests/TestSuite_multiprocess:Modify " Zhou Jun
2020-12-08 10:06 ` [dts] [dts 16/28] tests/TestSuite_packet_ordering:Modify " Zhou Jun
2020-12-08 10:06 ` [dts] [dts 17/28] tests/TestSuite_pmdpcap:Modify " Zhou Jun
2020-12-08 10:06 ` [dts] [dts 18/28] tests/TestSuite_pmdrss_hash:Modify " Zhou Jun
2020-12-08 10:06 ` [dts] [dts 19/28] tests/TestSuite_pmdrssreta:Modify " Zhou Jun
2020-12-08 10:06 ` [dts] [dts 20/28] tests/TestSuite_ptpclient:Modify " Zhou Jun
2020-12-08 10:06 ` [dts] [dts 21/28] tests/TestSuite_queue_start_stop:Modify " Zhou Jun
2020-12-08 10:06 ` [dts] [dts 22/28] tests/TestSuite_rxtx_callbacks:Modify " Zhou Jun
2020-12-08 10:06 ` [dts] [dts 23/28] tests/TestSuite_short_live:Modify " Zhou Jun
2020-12-08 10:06 ` [dts] [dts 24/28] tests/TestSuite_skeleton:Modify " Zhou Jun
2020-12-08 10:06 ` [dts] [dts 25/28] tests/TestSuite_softnic:Modify " Zhou Jun
2020-12-08 10:06 ` [dts] [dts 26/28] tests/TestSuite_timer:Modify " Zhou Jun
2020-12-08 10:06 ` [dts] [dts 27/28] tests/TestSuite_tso:Modify " Zhou Jun
2020-12-08 10:06 ` [dts] [dts 28/28] tests/TestSuite_userspace_ethtool:Modify " Zhou Jun
2020-12-09  1:53 ` [dts] [PATCH V1 00/28] Modify " Zhao, HaiyangX
2020-12-10  8:43 ` Tu, Lijuan

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20201208100627.9792-12-junx.w.zhou@intel.com \
    --to=junx.w.zhou@intel.com \
    --cc=dts@dpdk.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).