test suite reviews and discussions
 help / color / mirror / Atom feed
From: Haiyang Zhao <haiyangx.zhao@intel.com>
To: lijuan.tu@intel.com, dts@dpdk.org
Cc: Haiyang Zhao <haiyangx.zhao@intel.com>
Subject: [dts] [PATCH V1 2/2] framework/dut: replace "-w" with "-a"
Date: Wed, 23 Dec 2020 16:24:22 +0800
Message-ID: <20201223082422.7153-3-haiyangx.zhao@intel.com> (raw)
In-Reply-To: <20201223082422.7153-1-haiyangx.zhao@intel.com>

replace "-w" with "-a" when config is empty.

Signed-off-by: Haiyang Zhao <haiyangx.zhao@intel.com>
---
 framework/dut.py | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/framework/dut.py b/framework/dut.py
index db0d7df6..c4301df3 100644
--- a/framework/dut.py
+++ b/framework/dut.py
@@ -208,11 +208,12 @@ class Dut(Crb):
                           + blank + no_pci \
                           + blank + vdev
         else:
+            allow_option = '-a' if self.dpdk_version > '20.11.0-rc3' or self.dpdk_version == '20.11.0' else '-w'
             # get pci from ports_info
             pci_list = []
             if len(self.ports_info) != 0:
                 for port_info in self.ports_info:
-                    pci_list.append('-w %s' % port_info['pci'])
+                    pci_list.append('%s %s' % (allow_option, port_info['pci']))
             self.logger.info(pci_list)
             pci_str = ' '.join(pci_list)
             # default cores '1S/2C/1T'
-- 
2.17.1


  parent reply	other threads:[~2020-12-23  8:31 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-12-23  8:24 [dts] [PATCH V1 0/2] framework: fix a bug in start_testpmd Haiyang Zhao
2020-12-23  8:24 ` [dts] [PATCH V1 1/2] framework/pmd_output: " Haiyang Zhao
2020-12-23  8:24 ` Haiyang Zhao [this message]
2020-12-23  8:35 ` [dts] [PATCH V1 0/2] framework: " Zhao, HaiyangX
2020-12-24  3:03 ` Tu, Lijuan

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20201223082422.7153-3-haiyangx.zhao@intel.com \
    --to=haiyangx.zhao@intel.com \
    --cc=dts@dpdk.org \
    --cc=lijuan.tu@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

test suite reviews and discussions

This inbox may be cloned and mirrored by anyone:

	git clone --mirror http://inbox.dpdk.org/dts/0 dts/git/0.git

	# If you have public-inbox 1.1+ installed, you may
	# initialize and index your mirror using the following commands:
	public-inbox-init -V2 dts dts/ http://inbox.dpdk.org/dts \
		dts@dpdk.org
	public-inbox-index dts

Example config snippet for mirrors.
Newsgroup available over NNTP:
	nntp://inbox.dpdk.org/inbox.dpdk.dts


AGPL code for this site: git clone https://public-inbox.org/public-inbox.git