test suite reviews and discussions
 help / color / mirror / Atom feed
From: Ling Wei <weix.ling@intel.com>
To: dts@dpdk.org
Cc: Ling Wei <weix.ling@intel.com>
Subject: [dts] [PATCH V1 2/2] tests/dpdk_gso_lib: delete unbind ports of ports.cfg step
Date: Tue, 30 Mar 2021 16:50:50 +0800	[thread overview]
Message-ID: <20210330085050.322927-1-weix.ling@intel.com> (raw)

Delete unbind ports of ports.cfg step in set_up_all and
tear_down_all to avoid impact other test suites.

Signed-off-by: Ling Wei <weix.ling@intel.com>
---
 tests/TestSuite_dpdk_gso_lib.py | 8 +-------
 1 file changed, 1 insertion(+), 7 deletions(-)

diff --git a/tests/TestSuite_dpdk_gso_lib.py b/tests/TestSuite_dpdk_gso_lib.py
index 8cb13a8f..41c71c1f 100644
--- a/tests/TestSuite_dpdk_gso_lib.py
+++ b/tests/TestSuite_dpdk_gso_lib.py
@@ -52,12 +52,9 @@ class TestDPDKGsoLib(TestCase):
         # it will use the port config in vhost_gro.cfg
         # And it need two interface reconnet in DUT
 
-        # unbind the port which config in ports.cfg
+        # get dut ports and default driver
         self.dut_ports = self.dut.get_ports()
         self.def_driver = self.dut.ports_info[self.dut_ports[0]]['port'].get_nic_driver()
-        for i in self.dut_ports:
-            port = self.dut.ports_info[i]['port']
-            port.bind_driver()
 
         # get and bind the port in conf file
         self.pci = peer.get_pci_info()
@@ -459,9 +456,6 @@ class TestDPDKGsoLib(TestCase):
         """
         Run after each test suite.
         """
-        for i in self.dut_ports:
-            port = self.dut.ports_info[i]['port']
-            port.bind_driver(self.def_driver)
         self.unprepare_dpdk()
         self.dut.send_expect("ip netns del ns1", "#", 30)
         self.dut.send_expect("./usertools/dpdk-devbind.py -u %s" % (self.pci), '# ', 30)
-- 
2.25.1


                 reply	other threads:[~2021-03-30  8:52 UTC|newest]

Thread overview: [no followups] expand[flat|nested]  mbox.gz  Atom feed

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20210330085050.322927-1-weix.ling@intel.com \
    --to=weix.ling@intel.com \
    --cc=dts@dpdk.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).