test suite reviews and discussions
 help / color / mirror / Atom feed
From: Lijuan Tu <lijuan.tu@intel.com>
To: dliu@iol.unh.edu, ohilyard@iol.unh.edu, alialnu@nvidia.com
Cc: dts@dpdk.org, Lijuan Tu <lijuan.tu@intel.com>
Subject: [dts] [v2 3/6] tests/nic_single_core_perf: revise rst table
Date: Wed, 31 Mar 2021 09:34:07 +0000	[thread overview]
Message-ID: <20210331093410.505773-4-lijuan.tu@intel.com> (raw)
In-Reply-To: <20210331093410.505773-1-lijuan.tu@intel.com>

add more info in rst table, and rename headers to reduce width.

before:
  +----------+------------+---------+------------+--------+---------------------+-----------------------+
  | Fwd_core | Frame Size | TXD/RXD | Throughput |  Rate  | Expected Throughput | Throughput Difference |
  +==========+============+=========+============+========+=====================+=======================+
  | 1C/1T    | 64         | 512     | 9.842 Mpps | 3.307% | 0.000 Mpps          | 9.842 Mpps            |
  +----------+------------+---------+------------+--------+---------------------+-----------------------+
after:
  +----------+------------+---------+-----------+--------+---------------+-----------------+--------+
  | Fwd_core | Frame Size | TXD/RXD | Real-Mpps |  Rate  | Expected-Mpps | Real - Expected | Status |
  +==========+============+=========+===========+========+===============+=================+========+
  | 1C/1T    | 64         | 512     | 9.864     | 3.314% | 0             | 9.864           | PASS   |
  +----------+------------+---------+-----------+--------+---------------+-----------------+--------+

Signed-off-by: Lijuan Tu <lijuan.tu@intel.com>
---
 tests/TestSuite_nic_single_core_perf.py | 28 +++++++++++++------------
 1 file changed, 15 insertions(+), 13 deletions(-)

diff --git a/tests/TestSuite_nic_single_core_perf.py b/tests/TestSuite_nic_single_core_perf.py
index a0a257dd..095b508a 100644
--- a/tests/TestSuite_nic_single_core_perf.py
+++ b/tests/TestSuite_nic_single_core_perf.py
@@ -120,8 +120,8 @@ class TestNicSingleCorePerf(TestCase):
         self.gap = self.get_suite_cfg()['accepted_tolerance']
 
         # header to print test result table
-        self.table_header = ['Fwd_core', 'Frame Size', 'TXD/RXD', 'Throughput', 'Rate',
-                             'Expected Throughput', 'Throughput Difference']
+        self.table_header = ['Fwd_core', 'Frame Size', 'TXD/RXD', 'Real-Mpps', 'Rate',
+                             'Expected-Mpps', 'Real - Expected', 'Status']
         self.test_result = {}
 
     def flows(self):
@@ -327,15 +327,17 @@ class TestNicSingleCorePerf(TestCase):
                     ret_data[header[0]] = fwd_config
                     ret_data[header[1]] = frame_size
                     ret_data[header[2]] = nb_desc
-                    ret_data[header[3]] = "{:.3f} Mpps".format(
-                        self.throughput[fwd_config][frame_size][nb_desc])
-                    ret_data[header[4]] = "{:.3f}%".format(
-                        self.throughput[fwd_config][frame_size][nb_desc] * 100 / wirespeed)
-                    ret_data[header[5]] = "{:.3f} Mpps".format(
-                        self.expected_throughput[fwd_config][frame_size][nb_desc])
-                    ret_data[header[6]] = "{:.3f} Mpps".format(
-                        self.throughput[fwd_config][frame_size][nb_desc] -
-                            self.expected_throughput[fwd_config][frame_size][nb_desc])
+                    _real = self.throughput[fwd_config][frame_size][nb_desc]
+                    _exp = self.expected_throughput[fwd_config][frame_size][nb_desc]
+                    ret_data[header[3]] = "{:.3f}".format(_real)
+                    ret_data[header[4]] = "{:.3f}%".format(_real * 100 / wirespeed)
+                    ret_data[header[5]] = "{:.3f}".format(_exp)
+                    delta = _real - _exp
+                    ret_data[header[6]] = "{:.3f}".format(delta)
+                    if delta > -self.gap:
+                        ret_data[header[7]] = 'PASS'
+                    else:
+                        ret_data[header[7]] = 'FAIL'
 
                     ret_datas[frame_size][nb_desc] = deepcopy(ret_data)
                 self.test_result[fwd_config] = deepcopy(ret_datas)
@@ -374,8 +376,8 @@ class TestNicSingleCorePerf(TestCase):
                     row_dict0 = dict()
                     row_dict0['performance'] = list()
                     row_dict0['parameters'] = list()
-                    result_throughput = float(row_in['Throughput'].split()[0])
-                    expected_throughput = float(row_in['Expected Throughput'].split()[0])
+                    result_throughput = float(row_in['Real-Mpps'])
+                    expected_throughput = float(row_in['Expected-Mpps'])
                     # delta value and accepted tolerance in percentage
                     delta = result_throughput - expected_throughput
                     if delta > -self.gap:
-- 
2.25.1


  parent reply	other threads:[~2021-03-31  1:35 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-03-31  9:34 [dts] [v2 0/6] revise tests/nic_signle_core_perf Lijuan Tu
2021-03-31  9:34 ` [dts] [v2 1/6] tests/nic_single_core_perf: beauty JSON string Lijuan Tu
2021-03-31  9:34 ` [dts] [v2 2/6] tests/nic_single_core_perf: get better throughput stats Lijuan Tu
2021-03-31  9:34 ` Lijuan Tu [this message]
2021-03-31  9:34 ` [dts] [v2 4/6] tests/nic_single_core_perf: revise delta to ratio Lijuan Tu
2021-03-31  9:34 ` [dts] [v2 5/6] tests/nic_single_core_perf: add expected mpps into JSON Lijuan Tu
2021-03-31  9:34 ` [dts] [v2 6/6] tests/nic_single_core_perf: revise rx desc size Lijuan Tu
2021-06-25  5:21 ` [dts] [v2 0/6] revise tests/nic_signle_core_perf Tu, Lijuan

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20210331093410.505773-4-lijuan.tu@intel.com \
    --to=lijuan.tu@intel.com \
    --cc=alialnu@nvidia.com \
    --cc=dliu@iol.unh.edu \
    --cc=dts@dpdk.org \
    --cc=ohilyard@iol.unh.edu \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).