Re: [dts] [PATCH V1 0/2] modify igb and igc nic pktsize

Re: [dts] [PATCH V1 0/2] modify igb and igc nic pktsize

[Chen, LingliX]

[-- Attachment #1: Type: text/plain, Size: 303 bytes --]


> -----Original Message-----
> From: Chen, LingliX <linglix.chen@intel.com>
> Sent: Friday, April 30, 2021 11:48 PM
> To: dts@dpdk.org
> Cc: Chen, LingliX <linglix.chen@intel.com>
> Subject: [dts][PATCH V1 0/2] modify igb and igc nic pktsize
> 
Tested-by: Lingli Chen <linglix.chen@intel.com>

[-- Attachment #2: TestMtuUpdate-foxville.log --]
[-- Type: application/octet-stream, Size: 93719 bytes --]

[-- Attachment #3: TestMtuUpdate-powerville.log --]
[-- Type: application/octet-stream, Size: 103360 bytes --]

[-- Attachment #4: TestShutdownApi.log --]
[-- Type: application/octet-stream, Size: 97933 bytes --]

[dts] [PATCH V1 0/2] modify igb and igc nic pktsize

[Lingli Chen]

1.According to dpdk commit ddbc8c16a97f ("net/e1000: fix max Rx packet size"): modify shutdown_api/enable_disablejumbo igb pktSize.
2.According to dpdk-26436:If LPE is 1b,the maximum packet size that Foxville can receive is defined in the RLPML.RLPML register.The RLPML.RLPML register was set to MTU + 14 + 4 bytes (must consider at lease 1 VLAN tag since VLAN tag is not included in MTU).
modify tests/mtu_update igb and igc critical values.

Lingli Chen (2):
  tests/mtu_update: modify igb and igc critical values
  tests/shutdown_api: modify igb pktSize

 tests/TestSuite_mtu_update.py   | 19 +++++++++++++------
 tests/TestSuite_shutdown_api.py |  4 ++--
 2 files changed, 15 insertions(+), 8 deletions(-)

-- 
2.17.1

[dts] [PATCH V1 1/2] tests/mtu_update: modify igb and igc critical values

[Lingli Chen]

According to dpdk-26436:If LPE is 1b,the maximum packet size that Foxville can receive is defined in the RLPML.RLPML register.The RLPML.RLPML register was set to MTU + 14 + 4 bytes (must consider at lease 1 VLAN tag since VLAN tag is not included in MTU).

Signed-off-by: Lingli Chen <linglix.chen@intel.com>
---
 tests/TestSuite_mtu_update.py | 19 +++++++++++++------
 1 file changed, 13 insertions(+), 6 deletions(-)

diff --git a/tests/TestSuite_mtu_update.py b/tests/TestSuite_mtu_update.py
index 5fa17c97..f1da8660 100644
--- a/tests/TestSuite_mtu_update.py
+++ b/tests/TestSuite_mtu_update.py
@@ -108,7 +108,7 @@ class TestMtuUpdate(TestCase):
         # The packet total size include ethernet header, ip header, and payload.
         # ethernet header length is 18 bytes, ip standard header length is 20 bytes.
         # pktlen = pktsize - ETHER_HEADER_LEN
-        if self.kdriver == "ixgbe":
+        if self.kdriver in ["igb", "igc", "ixgbe"]:
             max_pktlen = pktsize + ETHER_HEADER_LEN + VLAN
             padding = max_pktlen - IP_HEADER_LEN - ETHER_HEADER_LEN-VLAN
         else:
@@ -172,7 +172,7 @@ class TestMtuUpdate(TestCase):
         self.port_mask = utils.create_mask([self.rx_port, self.tx_port])
 
         self.pmdout = PmdOutput(self.dut)
-        self.set_mtu(ETHER_JUMBO_FRAME_MTU + 600)
+        self.set_mtu(ETHER_JUMBO_FRAME_MTU + 200)
 
     def set_up(self):
         """
@@ -240,10 +240,17 @@ class TestMtuUpdate(TestCase):
         self.exec("port start all")
         self.exec("set fwd mac")
         self.exec("start")
-
-        self.send_packet_of_size_to_tx_port(packet_size - 1, received=True)
-        self.send_packet_of_size_to_tx_port(packet_size, received=True)
-        self.send_packet_of_size_to_tx_port(packet_size + 1, received=False)
+        """
+        On 1G NICs, when the jubmo frame MTU set > 1500, the software adjust it to MTU+4.
+        """
+        if self.nic in ["powerville", "springville", "foxville"] and packet_size > 1500:
+            self.send_packet_of_size_to_tx_port(packet_size + 4 - 1, received=True)
+            self.send_packet_of_size_to_tx_port(packet_size + 4, received=True)
+            self.send_packet_of_size_to_tx_port(packet_size + 4 + 1, received=False)
+        else:
+            self.send_packet_of_size_to_tx_port(packet_size - 1, received=True)
+            self.send_packet_of_size_to_tx_port(packet_size, received=True)
+            self.send_packet_of_size_to_tx_port(packet_size + 1, received=False)
 
         self.exec("stop")
         self.pmdout.quit()
-- 
2.17.1

[dts] [PATCH V1 2/2] tests/shutdown_api: modify igb pktSize

[Lingli Chen]

According to dpdk commit ddbc8c16a97f ("net/e1000: fix max Rx packet size"). modify igb pktSize.

Signed-off-by: Lingli Chen <linglix.chen@intel.com>
---
 tests/TestSuite_shutdown_api.py | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/tests/TestSuite_shutdown_api.py b/tests/TestSuite_shutdown_api.py
index 79d0bdd7..03eb89ab 100644
--- a/tests/TestSuite_shutdown_api.py
+++ b/tests/TestSuite_shutdown_api.py
@@ -616,7 +616,7 @@ class TestShutdownApi(TestCase):
             self.dut.send_expect("port start all", "testpmd> ", 100)
             self.dut.send_expect("start", "testpmd> ")
 
-            if self.nic in ['magnolia_park', 'niantic', 'twinpond', 'kawela_4', 'ironpond', 'springfountain', 'springville', 'powerville', 'sageville', 'sagepond']:
+            if self.nic in ['magnolia_park', 'niantic', 'twinpond', 'kawela_4', 'ironpond', 'springfountain', 'sageville', 'sagepond']:
                 # nantic vlan length will not be calculated
                 vlan_jumbo_size = jumbo_size + 4
             else:
@@ -639,7 +639,7 @@ class TestShutdownApi(TestCase):
         """
         On 1G NICs, when the jubmo frame MTU set as X, the software adjust it to (X + 4).
         """
-        if self.nic in ["powerville", "springville", "kawela_4"]:
+        if self.nic in ["kawela_4"]:
             jumbo_size += 4
         self.check_forwarding(pktSize=jumbo_size - 1)
         self.check_forwarding(pktSize=jumbo_size)
-- 
2.17.1

Re: [dts] [PATCH V1 0/2] modify igb and igc nic pktsize

[Tu, Lijuan]

> -----Original Message-----
> From: dts <dts-bounces@dpdk.org> On Behalf Of Lingli Chen
> Sent: 2021年4月30日 23:48
> To: dts@dpdk.org
> Cc: Chen, LingliX <linglix.chen@intel.com>
> Subject: [dts] [PATCH V1 0/2] modify igb and igc nic pktsize
> 
> 1.According to dpdk commit ddbc8c16a97f ("net/e1000: fix max Rx packet size"):
> modify shutdown_api/enable_disablejumbo igb pktSize.
> 2.According to dpdk-26436:If LPE is 1b,the maximum packet size that Foxville
> can receive is defined in the RLPML.RLPML register.The RLPML.RLPML register
> was set to MTU + 14 + 4 bytes (must consider at lease 1 VLAN tag since VLAN
> tag is not included in MTU).
> modify tests/mtu_update igb and igc critical values.
> 
> Lingli Chen (2):
>   tests/mtu_update: modify igb and igc critical values
>   tests/shutdown_api: modify igb pktSize
> 
>  tests/TestSuite_mtu_update.py   | 19 +++++++++++++------
>  tests/TestSuite_shutdown_api.py |  4 ++--
>  2 files changed, 15 insertions(+), 8 deletions(-)
> 
> --
> 2.17.1

Applied, please mind your length of commit message, it should be less than 74.