Re: [dts] [PATCH V1] tests/iavf_fdir: reload driver to reduce the interaction between cases

Re: [dts] [PATCH V1] tests/iavf_fdir: reload driver to reduce the interaction between cases

[Sun, QinX]

[-- Attachment #1: Type: text/plain, Size: 314 bytes --]

> -----Original Message-----
> From: Sun, QinX <qinx.sun@intel.com>
> Sent: Wednesday, June 2, 2021 6:42 PM
> To: dts@dpdk.org
> Cc: Sun, QinX <qinx.sun@intel.com>
> Subject: [dts] [PATCH V1] tests/iavf_fdir: reload driver to reduce the interaction between cases

Tested-by: Qin Sun <qinx.sun@intel.com>


[-- Attachment #2: TestIAVFFdir.log --]
[-- Type: application/octet-stream, Size: 1957668 bytes --]

[dts] [PATCH V1] tests/iavf_fdir: reload driver to reduce the interaction between cases

[Qin Sun]

some cases need to reload the driver to clear the packet count received by the network card,
so as to avoid the verification failure caused by other cases

Signed-off-by: Qin Sun <qinx.sun@intel.com>
---
 tests/TestSuite_iavf_fdir.py | 6 ++++++
 1 file changed, 6 insertions(+)

diff --git a/tests/TestSuite_iavf_fdir.py b/tests/TestSuite_iavf_fdir.py
index 27f92f8..e1f7c28 100644
--- a/tests/TestSuite_iavf_fdir.py
+++ b/tests/TestSuite_iavf_fdir.py
@@ -2986,6 +2986,9 @@ class TestIAVFFdir(TestCase):
         create same rules on pf and vf, no conflict
         """
         self.dut.kill_all()
+        self.dut.send_expect("rmmod ice", "# ", 15)
+        self.dut.send_expect("modprobe ice", "# ", 15)
+        self.setup_2pf_4vf_env()
         self.session_secondary = self.dut.new_session()
         self.session_third = self.dut.new_session()
 
@@ -3137,6 +3140,9 @@ class TestIAVFFdir(TestCase):
         create same input set but different action rules on pf and vf, no conflict.
         """
         self.dut.kill_all()
+        self.dut.send_expect("rmmod ice", "# ", 15)
+        self.dut.send_expect("modprobe ice", "# ", 15)
+        self.setup_2pf_4vf_env()
         self.session_secondary = self.dut.new_session()
         self.session_third = self.dut.new_session()
 
-- 
2.17.1

Re: [dts] [PATCH V1] tests/iavf_fdir: reload driver to reduce the interaction between cases

[Tu, Lijuan]

Reload driver is not a good idea, it will impact other devices which are not under test.

I think 'clear port stats' could help.

> -----Original Message-----
> From: dts <dts-bounces@dpdk.org> On Behalf Of Qin Sun
> Sent: 2021年6月2日 18:42
> To: dts@dpdk.org
> Cc: Sun, QinX <qinx.sun@intel.com>
> Subject: [dts] [PATCH V1] tests/iavf_fdir: reload driver to reduce the interaction
> between cases
> 
> some cases need to reload the driver to clear the packet count received by the
> network card, so as to avoid the verification failure caused by other cases
> 
> Signed-off-by: Qin Sun <qinx.sun@intel.com>
> ---
>  tests/TestSuite_iavf_fdir.py | 6 ++++++
>  1 file changed, 6 insertions(+)
> 
> diff --git a/tests/TestSuite_iavf_fdir.py b/tests/TestSuite_iavf_fdir.py index
> 27f92f8..e1f7c28 100644
> --- a/tests/TestSuite_iavf_fdir.py
> +++ b/tests/TestSuite_iavf_fdir.py
> @@ -2986,6 +2986,9 @@ class TestIAVFFdir(TestCase):
>          create same rules on pf and vf, no conflict
>          """
>          self.dut.kill_all()
> +        self.dut.send_expect("rmmod ice", "# ", 15)
> +        self.dut.send_expect("modprobe ice", "# ", 15)
> +        self.setup_2pf_4vf_env()
>          self.session_secondary = self.dut.new_session()
>          self.session_third = self.dut.new_session()
> 
> @@ -3137,6 +3140,9 @@ class TestIAVFFdir(TestCase):
>          create same input set but different action rules on pf and vf, no conflict.
>          """
>          self.dut.kill_all()
> +        self.dut.send_expect("rmmod ice", "# ", 15)
> +        self.dut.send_expect("modprobe ice", "# ", 15)
> +        self.setup_2pf_4vf_env()
>          self.session_secondary = self.dut.new_session()
>          self.session_third = self.dut.new_session()
> 
> --
> 2.17.1