test suite reviews and discussions
 help / color / mirror / Atom feed
* [dts] [PATCH] tests/acl: fix acl suite impacted by Strip prompt in send_expect
@ 2021-06-28 15:20 Konstantin Ananyev
  2021-07-01  8:36 ` Tu, Lijuan
  0 siblings, 1 reply; 2+ messages in thread
From: Konstantin Ananyev @ 2021-06-28 15:20 UTC (permalink / raw)
  To: dts; +Cc: zbigniewx.sikora, Konstantin Ananyev

Without that fix TestSuite_acl.py fails to run all tests.

Fixes: f7d4c0c12fc9 ("Strip prompt by default in send_expect")

Suggested-by: Zbigniew Sikora <zbigniewx.sikora@intel.com>
Signed-off-by: Konstantin Ananyev <konstantin.ananyev@intel.com>
---
 tests/TestSuite_acl.py | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/tests/TestSuite_acl.py b/tests/TestSuite_acl.py
index 5f403085..963f3fb5 100644
--- a/tests/TestSuite_acl.py
+++ b/tests/TestSuite_acl.py
@@ -100,7 +100,7 @@ class TestACL(TestCase):
         # 	grep FAILED test-acl.*.out
         for burst_size in ('15', '16', '17', '18', '23', '24', '25', '31', '32', '33', '34', '35', '47', '48', '51', '255', '256', '257'):
             acl_test_cmd = f'/bin/bash -x {self.test_acl_sh} {self.test_acl_bin} {self.acl_rules_dir} {alg} {burst_size}'
-            out = self.dut.send_expect(acl_test_cmd,  '# ', 1200)
+            out = self.dut.send_expect(acl_test_cmd,  '# ', 1200, trim_whitespace=False)
             self.verify('FAILED' not in out, f'for details see TestACL.log')
         self.logger.info('All tests have ended successfully')
 
-- 
2.26.3


^ permalink raw reply	[flat|nested] 2+ messages in thread

* Re: [dts] [PATCH] tests/acl: fix acl suite impacted by Strip prompt in send_expect
  2021-06-28 15:20 [dts] [PATCH] tests/acl: fix acl suite impacted by Strip prompt in send_expect Konstantin Ananyev
@ 2021-07-01  8:36 ` Tu, Lijuan
  0 siblings, 0 replies; 2+ messages in thread
From: Tu, Lijuan @ 2021-07-01  8:36 UTC (permalink / raw)
  To: Ananyev, Konstantin, dts; +Cc: Sikora, ZbigniewX, Ananyev, Konstantin


> -----Original Message-----
> From: dts <dts-bounces@dpdk.org> On Behalf Of Konstantin Ananyev
> Sent: 2021年6月28日 23:20
> To: dts@dpdk.org
> Cc: Sikora, ZbigniewX <zbigniewx.sikora@intel.com>; Ananyev, Konstantin
> <konstantin.ananyev@intel.com>
> Subject: [dts] [PATCH] tests/acl: fix acl suite impacted by Strip prompt in
> send_expect
> 
> Without that fix TestSuite_acl.py fails to run all tests.
> 
> Fixes: f7d4c0c12fc9 ("Strip prompt by default in send_expect")
> 
> Suggested-by: Zbigniew Sikora <zbigniewx.sikora@intel.com>
> Signed-off-by: Konstantin Ananyev <konstantin.ananyev@intel.com>

Applied, thanks

^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2021-07-01  8:36 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-06-28 15:20 [dts] [PATCH] tests/acl: fix acl suite impacted by Strip prompt in send_expect Konstantin Ananyev
2021-07-01  8:36 ` Tu, Lijuan

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).