[dts] [PATCH] framework/settings: Add broadcom nics to dts

[dts] [PATCH] framework/settings: Add broadcom nics to dts

[ohilyard]

From: Owen Hilyard <ohilyard@iol.unh.edu>

brcm_57414 and brcm_P2100G are not currently in the settings files for
DTS. This causes errors when DTS is run with these nics. The community
lab was running a patched version of DTS, but we are making an effort to
more closely align to upstream. Since these nics are used in CI for
DPDK, they are well tested with DTS and shouldn't cause any issues.

Signed-off-by: Owen Hilyard <ohilyard@iol.unh.edu>
---
 conf/nic_single_core_perf.cfg | 8 +++++++-
 framework/settings.py         | 8 ++++++--
 2 files changed, 13 insertions(+), 3 deletions(-)

diff --git a/conf/nic_single_core_perf.cfg b/conf/nic_single_core_perf.cfg
index 7970995e..4a1073f5 100644
--- a/conf/nic_single_core_perf.cfg
+++ b/conf/nic_single_core_perf.cfg
@@ -72,4 +72,10 @@ expected_throughput = {
                              '1C/2T': {64: {128: 0.00, 256: 0.00, 512: 0.00, 2048: 0.00}}}},
     'ConnectX5_MT4121': {
         '1C/1T': {64: {128: 0.00, 256: 0.00, 512: 0.00, 2048: 0.00}},
-        '1C/2T': {64: {128: 0.00, 256: 0.00, 512: 0.00, 2048: 0.00}}}}
+        '1C/2T': {64: {128: 0.00, 256: 0.00, 512: 0.00, 2048: 0.00}}},
+    'brcm_57414': {
+            '1C/1T': {64: {128: 0.00, 256: 0.00, 512: 0.00, 2048: 0.00}},
+            '1C/2T': {64: {128: 0.00, 256: 0.00, 512: 0.00, 2048: 0.00}}},
+    'brcm_P2100G': {
+            '1C/1T': {64: {128: 0.00, 256: 0.00, 512: 0.00, 2048: 0.00}},
+            '1C/2T': {64: {128: 0.00, 256: 0.00, 512: 0.00, 2048: 0.00}}}}
\ No newline at end of file
diff --git a/framework/settings.py b/framework/settings.py
index 9ceffe2e..fe7c01b5 100644
--- a/framework/settings.py
+++ b/framework/settings.py
@@ -110,7 +110,9 @@ NICS = {
     'fastlinq_ql41000_vf': '1077:8090',
     'carlsville': '8086:15ff',
     'hi1822': '19e5:1822',
-    'foxville': '8086:15f2'
+    'foxville': '8086:15f2',
+    'brcm_57414': '14e4:16d7',
+    'brcm_P2100G': '14e4:1750'
 }
 
 DRIVERS = {
@@ -174,7 +176,9 @@ DRIVERS = {
     'fastlinq_ql41000_vf': 'qede',
     'carlsville': 'i40e',
     'hi1822': 'hinic',
-    'foxville':'igc'
+    'foxville':'igc',
+    'brcm_57414': 'bnxt_en',
+    'brcm_P2100G': 'bnxt_en'
 }
 
 """
-- 
2.30.2

Re: [dts] [PATCH] framework/settings: Add broadcom nics to dts

[Owen Hilyard]

[-- Attachment #1: Type: text/plain, Size: 2554 bytes --]

Hello Lijuan,

I just wanted to follow up and ask about the status of this patch. I would
like to minimize the time the community lab is running patches that are not
in mainline DTS.

Owen

On Wed, Jul 14, 2021 at 12:22 PM <ohilyard@iol.unh.edu> wrote:

> From: Owen Hilyard <ohilyard@iol.unh.edu>
>
> brcm_57414 and brcm_P2100G are not currently in the settings files for
> DTS. This causes errors when DTS is run with these nics. The community
> lab was running a patched version of DTS, but we are making an effort to
> more closely align to upstream. Since these nics are used in CI for
> DPDK, they are well tested with DTS and shouldn't cause any issues.
>
> Signed-off-by: Owen Hilyard <ohilyard@iol.unh.edu>
> ---
>  conf/nic_single_core_perf.cfg | 8 +++++++-
>  framework/settings.py         | 8 ++++++--
>  2 files changed, 13 insertions(+), 3 deletions(-)
>
> diff --git a/conf/nic_single_core_perf.cfg b/conf/nic_single_core_perf.cfg
> index 7970995e..4a1073f5 100644
> --- a/conf/nic_single_core_perf.cfg
> +++ b/conf/nic_single_core_perf.cfg
> @@ -72,4 +72,10 @@ expected_throughput = {
>                               '1C/2T': {64: {128: 0.00, 256: 0.00, 512:
> 0.00, 2048: 0.00}}}},
>      'ConnectX5_MT4121': {
>          '1C/1T': {64: {128: 0.00, 256: 0.00, 512: 0.00, 2048: 0.00}},
> -        '1C/2T': {64: {128: 0.00, 256: 0.00, 512: 0.00, 2048: 0.00}}}}
> +        '1C/2T': {64: {128: 0.00, 256: 0.00, 512: 0.00, 2048: 0.00}}},
> +    'brcm_57414': {
> +            '1C/1T': {64: {128: 0.00, 256: 0.00, 512: 0.00, 2048: 0.00}},
> +            '1C/2T': {64: {128: 0.00, 256: 0.00, 512: 0.00, 2048: 0.00}}},
> +    'brcm_P2100G': {
> +            '1C/1T': {64: {128: 0.00, 256: 0.00, 512: 0.00, 2048: 0.00}},
> +            '1C/2T': {64: {128: 0.00, 256: 0.00, 512: 0.00, 2048: 0.00}}}}
> \ No newline at end of file
> diff --git a/framework/settings.py b/framework/settings.py
> index 9ceffe2e..fe7c01b5 100644
> --- a/framework/settings.py
> +++ b/framework/settings.py
> @@ -110,7 +110,9 @@ NICS = {
>      'fastlinq_ql41000_vf': '1077:8090',
>      'carlsville': '8086:15ff',
>      'hi1822': '19e5:1822',
> -    'foxville': '8086:15f2'
> +    'foxville': '8086:15f2',
> +    'brcm_57414': '14e4:16d7',
> +    'brcm_P2100G': '14e4:1750'
>  }
>
>  DRIVERS = {
> @@ -174,7 +176,9 @@ DRIVERS = {
>      'fastlinq_ql41000_vf': 'qede',
>      'carlsville': 'i40e',
>      'hi1822': 'hinic',
> -    'foxville':'igc'
> +    'foxville':'igc',
> +    'brcm_57414': 'bnxt_en',
> +    'brcm_P2100G': 'bnxt_en'
>  }
>
>  """
> --
> 2.30.2
>
>

[-- Attachment #2: Type: text/html, Size: 3613 bytes --]

Re: [dts] [PATCH] framework/settings: Add broadcom nics to dts

[Tu, Lijuan]

> -----Original Message-----
> From: ohilyard@iol.unh.edu <ohilyard@iol.unh.edu>
> Sent: 2021年7月15日 0:22
> To: dts@dpdk.org
> Cc: Tu, Lijuan <lijuan.tu@intel.com>; Owen Hilyard <ohilyard@iol.unh.edu>
> Subject: [PATCH] framework/settings: Add broadcom nics to dts
> 
> From: Owen Hilyard <ohilyard@iol.unh.edu>
> 
> brcm_57414 and brcm_P2100G are not currently in the settings files for DTS.
> This causes errors when DTS is run with these nics. The community lab was
> running a patched version of DTS, but we are making an effort to more closely
> align to upstream. Since these nics are used in CI for DPDK, they are well tested
> with DTS and shouldn't cause any issues.
> 
> Signed-off-by: Owen Hilyard <ohilyard@iol.unh.edu>

Applied, thanks