test suite reviews and discussions
 help / color / mirror / Atom feed
From: Zhimin Huang <zhiminx.huang@intel.com>
To: dts@dpdk.org
Cc: Zhimin Huang <zhiminx.huang@intel.com>
Subject: [dts] [PATCH V1] tests/rte_flow_common:fix no fdir matchedid issue
Date: Wed, 28 Jul 2021 23:15:32 +0800	[thread overview]
Message-ID: <20210728151532.31188-1-zhiminx.huang@intel.com> (raw)

*.when expect markid is 0 and testpmd not have fdir matchid,
it should be failed for this issue, so add empty set judgement.

Signed-off-by: Zhimin Huang <zhiminx.huang@intel.com>
---
 tests/rte_flow_common.py | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/tests/rte_flow_common.py b/tests/rte_flow_common.py
index 42afbfd1..591aa5a1 100644
--- a/tests/rte_flow_common.py
+++ b/tests/rte_flow_common.py
@@ -400,7 +400,7 @@ def check_mark(out, pkt_num, check_param, stats=True):
                 raise Exception("got wrong output, not match pattern %s" % p.pattern)
             if mark_id is not None:
                 mark_list = set(int(i, CVL_TXQ_RXQ_NUMBER) for i in fdir_scanner.findall(out))
-                verify(all([i == check_param["mark_id"] for i in mark_list]),
+                verify(all([i == check_param["mark_id"] for i in mark_list]) and mark_list,
                        "failed: some packet mark id of %s not match" % mark_list)
             else:
                 verify(not fdir_flag, "output should not include mark id")
-- 
2.17.1


             reply	other threads:[~2021-07-28  6:44 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-07-28 15:15 Zhimin Huang [this message]
2021-08-03  5:09 ` Tu, Lijuan

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20210728151532.31188-1-zhiminx.huang@intel.com \
    --to=zhiminx.huang@intel.com \
    --cc=dts@dpdk.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).