test suite reviews and discussions
 help / color / mirror / Atom feed
From: Zhimin Huang <zhiminx.huang@intel.com>
To: dts@dpdk.org
Cc: Zhimin Huang <zhiminx.huang@intel.com>
Subject: [dts] [PATCH V2] tests/cvl_advanced_rss_pppoe:remove destroy rule test steps
Date: Fri,  6 Aug 2021 02:23:14 +0800	[thread overview]
Message-ID: <20210805182314.18713-1-zhiminx.huang@intel.com> (raw)

*.dpdk cannot guarantee the operation after destroy the rule,
so remove destroy rule test steps.

Signed-off-by: Zhimin Huang <zhiminx.huang@intel.com>
---
v2:fix typo issue

 .../cvl_advanced_rss_pppoe_test_plan.rst      | 16 ---------------
 tests/TestSuite_cvl_advanced_rss_pppoe.py     | 20 -------------------
 2 files changed, 36 deletions(-)

diff --git a/test_plans/cvl_advanced_rss_pppoe_test_plan.rst b/test_plans/cvl_advanced_rss_pppoe_test_plan.rst
index a8cb7171..e209e0d4 100644
--- a/test_plans/cvl_advanced_rss_pppoe_test_plan.rst
+++ b/test_plans/cvl_advanced_rss_pppoe_test_plan.rst
@@ -4278,14 +4278,6 @@ Test case: MAC_PPPOE_IPV4_UDP_PAY_symmetric
 
      check the hash values of the two packets are different.
 
-6. destroy the rule::
-
-     testpmd> flow destroy 0 rule 0
-     testpmd> flow list 0
-
-   check the rule not exists in the list.
-   repeat step 4, swap the values of [Source IP] and [Dest IP], [Source Port] and [Dest Port],
-   check the hash value is changed.
 
 Test case: MAC_PPPOE_IPV4_TCP_PAY_symmetric
 ===========================================
@@ -4540,14 +4532,6 @@ Test case: MAC_PPPOE_IPV6_UDP_PAY_symmetric
 
      check the hash values of the two packets are different.
 
-6. destroy the rule::
-
-     testpmd> flow destroy 0 rule 0
-     testpmd> flow list 0
-
-   check the rule not exists in the list.
-   repeat step 3, swap the values of [Source IP] and [Dest IP], [Source Port] and [Dest Port],
-   check the hash values are changed.
 
 Test case: MAC_PPPOE_IPV6_TCP_PAY_symmetric
 ===========================================
diff --git a/tests/TestSuite_cvl_advanced_rss_pppoe.py b/tests/TestSuite_cvl_advanced_rss_pppoe.py
index 2d3e226e..3952bbf0 100644
--- a/tests/TestSuite_cvl_advanced_rss_pppoe.py
+++ b/tests/TestSuite_cvl_advanced_rss_pppoe.py
@@ -3780,16 +3780,6 @@ mac_pppoe_ipv6_udp_pay_symmetric = {
             'action': {'check_hash_different': 'mac_ipv6_udp_pay_mismatch'},
         },
     ],
-    'post-test': [
-        {
-            'send_packet': mac_pppoe_ipv6_udp_pay_symmetric_packets['match']['mac_pppoe_ipv6_udp_pay'][0],
-            'action': {'save_hash': 'mac_pppoe_ipv6_udp_pay_match_post'},
-        },
-        {
-            'send_packet': mac_pppoe_ipv6_udp_pay_symmetric_packets['match']['mac_pppoe_ipv6_udp_pay'][1:],
-            'action': {'check_hash_different': 'mac_pppoe_ipv6_udp_pay_match_post'},
-        },
-    ],
 }
 
 mac_pppoe_ipv6_pay_symmetric_packets = {
@@ -4063,16 +4053,6 @@ mac_pppoe_ipv4_udp_pay_symmetric = {
             'action': {'check_hash_different': 'mac_ipv4_udp_pay_mismatch'},
         },
     ],
-    'post-test': [
-        {
-            'send_packet': mac_pppoe_ipv4_udp_pay_symmetric_packets['match']['mac_pppoe_ipv4_udp_pay'][0],
-            'action': {'save_hash': 'mac_ipv4_udp_pay_match_post'},
-        },
-        {
-            'send_packet': mac_pppoe_ipv4_udp_pay_symmetric_packets['match']['mac_pppoe_ipv4_udp_pay'][1:],
-            'action': {'check_hash_different': 'mac_ipv4_udp_pay_match_post'},
-        },
-    ],
 }
 
 mac_pppoe_ipv4_tcp_pay_symmetric_packets = {
-- 
2.17.1


             reply	other threads:[~2021-08-05  9:53 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-08-05 18:23 Zhimin Huang [this message]
2021-08-05  9:55 ` Huang, ZhiminX
2021-09-29  6:53   ` Tu, Lijuan
2021-08-10  5:55 ` Tu, Lijuan

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20210805182314.18713-1-zhiminx.huang@intel.com \
    --to=zhiminx.huang@intel.com \
    --cc=dts@dpdk.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).