test suite reviews and discussions
 help / color / mirror / Atom feed
* [dts] [PATCH V1 0/2] *** modify vf_vlan_strip because it is wrong for the original case verifying ***
@ 2021-09-17 18:09 Yan Xia
  2021-09-17 18:09 ` [dts] [PATCH V1 1/2] test_plans/kernelpf_iavf_test_plan: modify vf_vlan_strip because it is wrong for the original case verifying Yan Xia
  2021-09-17 18:09 ` [dts] [PATCH V1 2/2] tests/kernelpf_iavf: " Yan Xia
  0 siblings, 2 replies; 3+ messages in thread
From: Yan Xia @ 2021-09-17 18:09 UTC (permalink / raw)
  To: dts; +Cc: Yan Xia

*** modify vf_vlan_strip because it is wrong for the original case verifying ***

Yan Xia (2):
  test_plans/kernelpf_iavf_test_plan: modify vf_vlan_strip because it is
    wrong for the original case verifying
  tests/kernelpf_iavf: modify vf_vlan_strip because it is wrong for the
    original case verifying

 test_plans/kernelpf_iavf_test_plan.rst |  3 +++
 tests/TestSuite_kernelpf_iavf.py       | 12 ++++++------
 2 files changed, 9 insertions(+), 6 deletions(-)

-- 
2.32.0


^ permalink raw reply	[flat|nested] 3+ messages in thread

* [dts] [PATCH V1 1/2] test_plans/kernelpf_iavf_test_plan: modify vf_vlan_strip because it is wrong for the original case verifying
  2021-09-17 18:09 [dts] [PATCH V1 0/2] *** modify vf_vlan_strip because it is wrong for the original case verifying *** Yan Xia
@ 2021-09-17 18:09 ` Yan Xia
  2021-09-17 18:09 ` [dts] [PATCH V1 2/2] tests/kernelpf_iavf: " Yan Xia
  1 sibling, 0 replies; 3+ messages in thread
From: Yan Xia @ 2021-09-17 18:09 UTC (permalink / raw)
  To: dts; +Cc: Yan Xia

modify vf_vlan_strip because it is wrong for the original case verifying

Signed-off-by: Yan Xia <yanx.xia@intel.com>
---
 test_plans/kernelpf_iavf_test_plan.rst | 3 +++
 1 file changed, 3 insertions(+)

diff --git a/test_plans/kernelpf_iavf_test_plan.rst b/test_plans/kernelpf_iavf_test_plan.rst
index 4351f791..72223c77 100644
--- a/test_plans/kernelpf_iavf_test_plan.rst
+++ b/test_plans/kernelpf_iavf_test_plan.rst
@@ -312,8 +312,11 @@ Test case: VF vlan strip
 
 Enable VF vlan strip::
 
+    testpmd> vlan set filter on 0
+    testpmd> rx_vlan add 20 0
     testpmd> vlan set strip on 0
     testpmd> set fwd mac
+    testpmd> set verbose 1
     testpmd> start
 
 Send packets with vlan tag::
-- 
2.32.0


^ permalink raw reply	[flat|nested] 3+ messages in thread

* [dts] [PATCH V1 2/2] tests/kernelpf_iavf: modify vf_vlan_strip because it is wrong for the original case verifying
  2021-09-17 18:09 [dts] [PATCH V1 0/2] *** modify vf_vlan_strip because it is wrong for the original case verifying *** Yan Xia
  2021-09-17 18:09 ` [dts] [PATCH V1 1/2] test_plans/kernelpf_iavf_test_plan: modify vf_vlan_strip because it is wrong for the original case verifying Yan Xia
@ 2021-09-17 18:09 ` Yan Xia
  1 sibling, 0 replies; 3+ messages in thread
From: Yan Xia @ 2021-09-17 18:09 UTC (permalink / raw)
  To: dts; +Cc: Yan Xia

modify vf_vlan_strip because it is wrong for the original case verifying

Signed-off-by: Yan Xia <yanx.xia@intel.com>
---
 tests/TestSuite_kernelpf_iavf.py | 12 ++++++------
 1 file changed, 6 insertions(+), 6 deletions(-)

diff --git a/tests/TestSuite_kernelpf_iavf.py b/tests/TestSuite_kernelpf_iavf.py
index 6a858fc5..328e44b2 100644
--- a/tests/TestSuite_kernelpf_iavf.py
+++ b/tests/TestSuite_kernelpf_iavf.py
@@ -529,13 +529,16 @@ class TestKernelpfIavf(TestCase):
         random_vlan = random.randint(1, MAX_VLAN)
         self.vm_testpmd.start_testpmd("all")
         self.vm_testpmd.execute_cmd("port stop all")
-        self.vm_testpmd.execute_cmd("vlan set filter off 0")
+        self.vm_testpmd.execute_cmd("vlan set filter on 0")
+        self.vm_testpmd.execute_cmd("rx_vlan add %s 0" % random_vlan)
         self.vm_testpmd.execute_cmd("vlan set strip off 0")
-        self.vm_testpmd.execute_cmd("vlan set strip on 0")
         self.vm_testpmd.execute_cmd("port start all")
         self.vm_testpmd.execute_cmd("set fwd mac")
         self.vm_testpmd.execute_cmd("set verbose 1")
         self.vm_testpmd.execute_cmd("start")
+
+        #enable strip
+        self.vm_testpmd.execute_cmd("vlan set strip on 0")
         self.start_tcpdump(self.tester_intf)
         self.send_and_getout(vlan=random_vlan, pkt_type="VLAN_UDP")
         tcpdump_out = self.get_tcpdump_package()
@@ -548,10 +551,7 @@ class TestKernelpfIavf(TestCase):
         self.send_and_getout(vlan=random_vlan, pkt_type="VLAN_UDP")
         tcpdump_out = self.get_tcpdump_package()
         receive_pkt = re.findall('vlan %s' % random_vlan, tcpdump_out)
-        if self.driver_version < "2.13.10" or self.kdriver == 'ice':
-            self.verify(len(receive_pkt) == 2, 'Failed to not received vlan packet!!!')
-        else:
-            self.verify(len(receive_pkt) == 1, 'Failed to not received vlan packet!!!')
+        self.verify(len(receive_pkt) == 2, 'Failed to not received vlan packet!!!')
 
     def test_vf_vlan_filter(self):
         random_vlan = random.randint(2, MAX_VLAN)
-- 
2.32.0


^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, other threads:[~2021-09-17 10:07 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-09-17 18:09 [dts] [PATCH V1 0/2] *** modify vf_vlan_strip because it is wrong for the original case verifying *** Yan Xia
2021-09-17 18:09 ` [dts] [PATCH V1 1/2] test_plans/kernelpf_iavf_test_plan: modify vf_vlan_strip because it is wrong for the original case verifying Yan Xia
2021-09-17 18:09 ` [dts] [PATCH V1 2/2] tests/kernelpf_iavf: " Yan Xia

test suite reviews and discussions

This inbox may be cloned and mirrored by anyone:

	git clone --mirror http://inbox.dpdk.org/dts/0 dts/git/0.git

	# If you have public-inbox 1.1+ installed, you may
	# initialize and index your mirror using the following commands:
	public-inbox-init -V2 dts dts/ http://inbox.dpdk.org/dts \
		dts@dpdk.org
	public-inbox-index dts

Example config snippet for mirrors.
Newsgroup available over NNTP:
	nntp://inbox.dpdk.org/inbox.dpdk.dts


AGPL code for this site: git clone https://public-inbox.org/public-inbox.git