test suite reviews and discussions
 help / color / mirror / Atom feed
* Re: [dts] [PATCH V2 1/2] test_plans/vf_daemon: delete test_mac_antispoof
  2021-10-26 13:28 ` [dts] [PATCH V2 1/2] test_plans/vf_daemon: delete test_mac_antispoof Yan Xia
@ 2021-10-26  6:48   ` Lin, Xueqin
  0 siblings, 0 replies; 6+ messages in thread
From: Lin, Xueqin @ 2021-10-26  6:48 UTC (permalink / raw)
  To: Xia, YanX, dts; +Cc: Xia, YanX

> -----Original Message-----
> From: dts <dts-bounces@dpdk.org> On Behalf Of Yan Xia
> Sent: Tuesday, October 26, 2021 9:28 PM
> To: dts@dpdk.org
> Cc: Xia, YanX <yanx.xia@intel.com>
> Subject: [dts] [PATCH V2 1/2] test_plans/vf_daemon: delete
> test_mac_antispoof
> 
> comfirm with Tu,Lijuan and Lin,Xueqin, delete the case
> 
> Signed-off-by: Yan Xia <yanx.xia@intel.com>
Acked-by: Xueqin Lin <Xueqin.lin@intel.com>
> ---
>  test_plans/vf_daemon_test_plan.rst | 39 ------------------------------
>  1 file changed, 39 deletions(-)
> 
> diff --git a/test_plans/vf_daemon_test_plan.rst
> b/test_plans/vf_daemon_test_plan.rst
> index 2c131f58..07543c9d 100644
> --- a/test_plans/vf_daemon_test_plan.rst
> +++ b/test_plans/vf_daemon_test_plan.rst
> @@ -182,45 +182,6 @@ Test Case 3: Set VLAN antispoof for VF from PF
>      packet with matching vlan id
> 
> 
> -Test Case 4: Set mac antispoof for VF from PF -
> ===============================================
> -1. Add fake mac and use fake mac instead of transmitted mac in the
> -   macswap mode, so default is non-matching SA::
> -
> -      .addr_bytes = {0x00, 0x11, 0x22, 0x33, 0x44, 0x55}
> -
> -      On VF0, add below two line code in file app/test-pmd/macswap_sse.h:
> -      struct rte_ether_addr fake_mac = {.addr_bytes = {0x00, 0x11, 0x22, 0x33,
> 0x44, 0x55},};
> -      rte_ether_addr_copy(&fake_mac, &eth_hdr[0]->s_addr);
> -
> -2. Disable VF0 mac antispoof from PF::
> -
> -      testpmd> set vf mac antispoof 0 0 off
> -
> -3. Start testpmd on VF0, set it in macswap forwarding mode and enable
> -   verbose output::
> -
> -      testpmd> set fwd macswap
> -
> -4. Send packet from tester to VF0 with correct SA, but code has changed
> -   to use fake SA
> -
> -5. Stop VF0 testpmd and check VF0 can receive then transmit packet
> -
> -6. Enable VF0 mac antispoof from PF::
> -
> -      testpmd> set vf mac antispoof 0 0 on
> -
> -7. Start VF0 testpmd
> -
> -8. Send packet from tester to VF0 with correct SA, but code has changed
> -   to use fake SA
> -
> -9. Stop VF0 testpmd and check VF0 can receive packet but can't transmit
> packet
> -
> -10. Recover original code
> -
> -
>  Test Case 5: Set the MAC address for VF from PF
> ===============================================
> 
> --
> 2.33.1


^ permalink raw reply	[flat|nested] 6+ messages in thread

* Re: [dts] [PATCH V2 2/2] tests/vf_daemon: delete test_mac_antispoof
  2021-10-26 13:28 ` [dts] [PATCH V2 2/2] tests/vf_daemon: " Yan Xia
@ 2021-10-26  6:48   ` Lin, Xueqin
  2021-10-26  7:51     ` Tu, Lijuan
  0 siblings, 1 reply; 6+ messages in thread
From: Lin, Xueqin @ 2021-10-26  6:48 UTC (permalink / raw)
  To: Xia, YanX, dts; +Cc: Xia, YanX

> -----Original Message-----
> From: dts <dts-bounces@dpdk.org> On Behalf Of Yan Xia
> Sent: Tuesday, October 26, 2021 9:28 PM
> To: dts@dpdk.org
> Cc: Xia, YanX <yanx.xia@intel.com>
> Subject: [dts] [PATCH V2 2/2] tests/vf_daemon: delete test_mac_antispoof
> 
> comfirm with Tu,Lijuan and Lin,Xueqin, delete the case
> 
> Signed-off-by: Yan Xia <yanx.xia@intel.com>
Acked-by: Xueqin Lin <Xueqin.lin@intel.com>
> ---
>  tests/TestSuite_vf_daemon.py | 53 ------------------------------------
>  1 file changed, 53 deletions(-)
> 
> diff --git a/tests/TestSuite_vf_daemon.py b/tests/TestSuite_vf_daemon.py
> index 4d6ae58f..62996ade 100644
> --- a/tests/TestSuite_vf_daemon.py
> +++ b/tests/TestSuite_vf_daemon.py
> @@ -517,59 +517,6 @@ class TestVfDaemon(TestCase):
>          out = self.vm0_testpmd.execute_cmd('show port stats 0')
>          self.verify("RX-packets: 40" in out,
>              "Failed to enable all queues drop!!!")
> -
> -
> -    def test_mac_antispoof(self):
> -        """
> -        Enable/disable mac anti-spoof for a VF from PF
> -        """
> -        fake_mac = '00:11:22:33:44:55'
> -        time.sleep(5)
> -        self.vm0_dut.send_expect("sed -i -e '/int r;/a " +\
> -            "\        struct rte_ether_addr fake_mac = {.addr_bytes = {0x00, 0x11,
> 0x22, 0x33, 0x44, 0x55},};'" +\
> -            " app/test-pmd/macswap_sse.h", "# ", 30)
> -        line_num = self.vm0_dut.send_expect("sed -n '/_mm_storeu_si128/='
> app/test-pmd/macswap_sse.h |sed -n 5p", "# ",30)
> -        self.vm0_dut.send_expect("sed -i -e
> '%sa\\rte_ether_addr_copy(&fake_mac, &eth_hdr[0]->s_addr);'" %
> str(line_num)+\
> -                    " app/test-pmd/macswap_sse.h", "# ", 30)
> -        time.sleep(3)
> -
> -        self.vm0_dut.build_install_dpdk(self.target)
> -        time.sleep(5)
> -
> -        self.check_vf_link_status()
> -        self.vf0_mac = self.vm0_testpmd.get_port_mac(0)
> -
> -        self.vm0_testpmd.execute_cmd('set fwd macswap')
> -        self.dut_testpmd.execute_cmd('set vf mac antispoof 0 0 off')
> -        self.vm0_testpmd.execute_cmd('start')
> -        time.sleep(5)
> -
> -        dumpout = self.send_and_macstrip(self.vf0_mac)
> -        out = self.vm0_testpmd.execute_cmd('stop')
> -
> -        self.verify(fake_mac in dumpout,
> -            "Failed to disable vf mac anspoof!!!")
> -        self.verify("RX-packets: 1" in out, "Failed to receive packet!!!")
> -        self.verify("TX-packets: 1" in out,
> -            "Failed to disable mac antispoof!!!")
> -
> -        self.dut_testpmd.execute_cmd('set vf mac antispoof 0 0 on')
> -        self.vm0_testpmd.execute_cmd('start')
> -        time.sleep(3)
> -        dumpout = self.send_and_macstrip(self.vf0_mac)
> -        out = self.vm0_testpmd.execute_cmd('stop')
> -        self.verify(fake_mac not in dumpout, "Failed to enable vf mac anspoof!!!")
> -        self.verify("RX-packets: 1" in out, "Failed to receive packet!!!")
> -        self.verify("TX-packets: 0" in out, "Failed to enable mac antispoof!!!")
> -
> -        self.vm0_testpmd.quit()
> -        self.dut_testpmd.quit()
> -        self.vm0_dut.send_expect("sed -i '/struct rte_ether_addr fake_mac =
> {.addr_bytes = " +\
> -            "{0x00, 0x11, 0x22, 0x33, 0x44, 0x55},};/d' app/test-
> pmd/macswap_sse.h", "# ", 30)
> -        self.vm0_dut.send_expect("sed -i '%sd'" % line_num +\
> -            " app/test-pmd/macswap_sse.h", "# ", 30)
> -        self.vm0_dut.build_install_dpdk(self.target)
> -
> 
>      def test_vf_mac_set(self):
>          """
> --
> 2.33.1


^ permalink raw reply	[flat|nested] 6+ messages in thread

* Re: [dts] [PATCH V2 2/2] tests/vf_daemon: delete test_mac_antispoof
  2021-10-26  6:48   ` Lin, Xueqin
@ 2021-10-26  7:51     ` Tu, Lijuan
  0 siblings, 0 replies; 6+ messages in thread
From: Tu, Lijuan @ 2021-10-26  7:51 UTC (permalink / raw)
  To: Lin, Xueqin, Xia, YanX, dts; +Cc: Xia, YanX

> -----Original Message-----
> From: dts <dts-bounces@dpdk.org> On Behalf Of Lin, Xueqin
> Sent: 2021年10月26日 14:49
> To: Xia, YanX <yanx.xia@intel.com>; dts@dpdk.org
> Cc: Xia, YanX <yanx.xia@intel.com>
> Subject: Re: [dts] [PATCH V2 2/2] tests/vf_daemon: delete test_mac_antispoof
> 
> > -----Original Message-----
> > From: dts <dts-bounces@dpdk.org> On Behalf Of Yan Xia
> > Sent: Tuesday, October 26, 2021 9:28 PM
> > To: dts@dpdk.org
> > Cc: Xia, YanX <yanx.xia@intel.com>
> > Subject: [dts] [PATCH V2 2/2] tests/vf_daemon: delete
> > test_mac_antispoof
> >
> > comfirm with Tu,Lijuan and Lin,Xueqin, delete the case
> >
> > Signed-off-by: Yan Xia <yanx.xia@intel.com>
> Acked-by: Xueqin Lin <Xueqin.lin@intel.com>

Applied

^ permalink raw reply	[flat|nested] 6+ messages in thread

* [dts] [PATCH V2 0/2] *** delete test_mac_antispoof ***
@ 2021-10-26 13:27 Yan Xia
  2021-10-26 13:28 ` [dts] [PATCH V2 1/2] test_plans/vf_daemon: delete test_mac_antispoof Yan Xia
  2021-10-26 13:28 ` [dts] [PATCH V2 2/2] tests/vf_daemon: " Yan Xia
  0 siblings, 2 replies; 6+ messages in thread
From: Yan Xia @ 2021-10-26 13:27 UTC (permalink / raw)
  To: dts; +Cc: Yan Xia

*** delete the case after confirm with Tu,Lijuan and Lin,Xueqin***

Yan Xia (2):
  test_plans/vf_daemon: delete test_mac_antispoof
  tests/vf_daemon: delete test_mac_antispoof

 test_plans/vf_daemon_test_plan.rst | 39 ----------------------
 tests/TestSuite_vf_daemon.py       | 53 ------------------------------
 2 files changed, 92 deletions(-)

-- 
2.33.1


^ permalink raw reply	[flat|nested] 6+ messages in thread

* [dts] [PATCH V2 1/2] test_plans/vf_daemon: delete test_mac_antispoof
  2021-10-26 13:27 [dts] [PATCH V2 0/2] *** delete test_mac_antispoof *** Yan Xia
@ 2021-10-26 13:28 ` Yan Xia
  2021-10-26  6:48   ` Lin, Xueqin
  2021-10-26 13:28 ` [dts] [PATCH V2 2/2] tests/vf_daemon: " Yan Xia
  1 sibling, 1 reply; 6+ messages in thread
From: Yan Xia @ 2021-10-26 13:28 UTC (permalink / raw)
  To: dts; +Cc: Yan Xia

comfirm with Tu,Lijuan and Lin,Xueqin, delete the case

Signed-off-by: Yan Xia <yanx.xia@intel.com>
---
 test_plans/vf_daemon_test_plan.rst | 39 ------------------------------
 1 file changed, 39 deletions(-)

diff --git a/test_plans/vf_daemon_test_plan.rst b/test_plans/vf_daemon_test_plan.rst
index 2c131f58..07543c9d 100644
--- a/test_plans/vf_daemon_test_plan.rst
+++ b/test_plans/vf_daemon_test_plan.rst
@@ -182,45 +182,6 @@ Test Case 3: Set VLAN antispoof for VF from PF
     packet with matching vlan id
 
 
-Test Case 4: Set mac antispoof for VF from PF
-===============================================
-1. Add fake mac and use fake mac instead of transmitted mac in the
-   macswap mode, so default is non-matching SA::
-
-      .addr_bytes = {0x00, 0x11, 0x22, 0x33, 0x44, 0x55}
-
-      On VF0, add below two line code in file app/test-pmd/macswap_sse.h:
-      struct rte_ether_addr fake_mac = {.addr_bytes = {0x00, 0x11, 0x22, 0x33, 0x44, 0x55},};
-      rte_ether_addr_copy(&fake_mac, &eth_hdr[0]->s_addr);
-
-2. Disable VF0 mac antispoof from PF::
-
-      testpmd> set vf mac antispoof 0 0 off
-
-3. Start testpmd on VF0, set it in macswap forwarding mode and enable
-   verbose output::
-
-      testpmd> set fwd macswap
-
-4. Send packet from tester to VF0 with correct SA, but code has changed
-   to use fake SA
-
-5. Stop VF0 testpmd and check VF0 can receive then transmit packet
-
-6. Enable VF0 mac antispoof from PF::
-
-      testpmd> set vf mac antispoof 0 0 on
-
-7. Start VF0 testpmd
-
-8. Send packet from tester to VF0 with correct SA, but code has changed
-   to use fake SA
-
-9. Stop VF0 testpmd and check VF0 can receive packet but can't transmit packet
-
-10. Recover original code
-
-
 Test Case 5: Set the MAC address for VF from PF
 ===============================================
 
-- 
2.33.1


^ permalink raw reply	[flat|nested] 6+ messages in thread

* [dts] [PATCH V2 2/2] tests/vf_daemon: delete test_mac_antispoof
  2021-10-26 13:27 [dts] [PATCH V2 0/2] *** delete test_mac_antispoof *** Yan Xia
  2021-10-26 13:28 ` [dts] [PATCH V2 1/2] test_plans/vf_daemon: delete test_mac_antispoof Yan Xia
@ 2021-10-26 13:28 ` Yan Xia
  2021-10-26  6:48   ` Lin, Xueqin
  1 sibling, 1 reply; 6+ messages in thread
From: Yan Xia @ 2021-10-26 13:28 UTC (permalink / raw)
  To: dts; +Cc: Yan Xia

comfirm with Tu,Lijuan and Lin,Xueqin, delete the case

Signed-off-by: Yan Xia <yanx.xia@intel.com>
---
 tests/TestSuite_vf_daemon.py | 53 ------------------------------------
 1 file changed, 53 deletions(-)

diff --git a/tests/TestSuite_vf_daemon.py b/tests/TestSuite_vf_daemon.py
index 4d6ae58f..62996ade 100644
--- a/tests/TestSuite_vf_daemon.py
+++ b/tests/TestSuite_vf_daemon.py
@@ -517,59 +517,6 @@ class TestVfDaemon(TestCase):
         out = self.vm0_testpmd.execute_cmd('show port stats 0')
         self.verify("RX-packets: 40" in out, 
             "Failed to enable all queues drop!!!")
-    
-
-    def test_mac_antispoof(self):
-        """
-        Enable/disable mac anti-spoof for a VF from PF
-        """
-        fake_mac = '00:11:22:33:44:55'
-        time.sleep(5)
-        self.vm0_dut.send_expect("sed -i -e '/int r;/a " +\
-            "\        struct rte_ether_addr fake_mac = {.addr_bytes = {0x00, 0x11, 0x22, 0x33, 0x44, 0x55},};'" +\
-            " app/test-pmd/macswap_sse.h", "# ", 30)
-        line_num = self.vm0_dut.send_expect("sed -n '/_mm_storeu_si128/=' app/test-pmd/macswap_sse.h |sed -n 5p", "# ",30)
-        self.vm0_dut.send_expect("sed -i -e '%sa\\rte_ether_addr_copy(&fake_mac, &eth_hdr[0]->s_addr);'" % str(line_num)+\
-                    " app/test-pmd/macswap_sse.h", "# ", 30)
-        time.sleep(3)
-
-        self.vm0_dut.build_install_dpdk(self.target) 
-        time.sleep(5)
-
-        self.check_vf_link_status()
-        self.vf0_mac = self.vm0_testpmd.get_port_mac(0)
-
-        self.vm0_testpmd.execute_cmd('set fwd macswap')
-        self.dut_testpmd.execute_cmd('set vf mac antispoof 0 0 off')
-        self.vm0_testpmd.execute_cmd('start')
-        time.sleep(5)
-
-        dumpout = self.send_and_macstrip(self.vf0_mac)
-        out = self.vm0_testpmd.execute_cmd('stop')
-
-        self.verify(fake_mac in dumpout, 
-            "Failed to disable vf mac anspoof!!!")
-        self.verify("RX-packets: 1" in out, "Failed to receive packet!!!")
-        self.verify("TX-packets: 1" in out, 
-            "Failed to disable mac antispoof!!!")
-
-        self.dut_testpmd.execute_cmd('set vf mac antispoof 0 0 on')
-        self.vm0_testpmd.execute_cmd('start')
-        time.sleep(3)
-        dumpout = self.send_and_macstrip(self.vf0_mac)
-        out = self.vm0_testpmd.execute_cmd('stop')
-        self.verify(fake_mac not in dumpout, "Failed to enable vf mac anspoof!!!")
-        self.verify("RX-packets: 1" in out, "Failed to receive packet!!!")
-        self.verify("TX-packets: 0" in out, "Failed to enable mac antispoof!!!")
-
-        self.vm0_testpmd.quit()
-        self.dut_testpmd.quit()
-        self.vm0_dut.send_expect("sed -i '/struct rte_ether_addr fake_mac = {.addr_bytes = " +\
-            "{0x00, 0x11, 0x22, 0x33, 0x44, 0x55},};/d' app/test-pmd/macswap_sse.h", "# ", 30)
-        self.vm0_dut.send_expect("sed -i '%sd'" % line_num +\
-            " app/test-pmd/macswap_sse.h", "# ", 30)
-        self.vm0_dut.build_install_dpdk(self.target)
-
 
     def test_vf_mac_set(self):
         """
-- 
2.33.1


^ permalink raw reply	[flat|nested] 6+ messages in thread

end of thread, other threads:[~2021-10-26  7:51 UTC | newest]

Thread overview: 6+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-10-26 13:27 [dts] [PATCH V2 0/2] *** delete test_mac_antispoof *** Yan Xia
2021-10-26 13:28 ` [dts] [PATCH V2 1/2] test_plans/vf_daemon: delete test_mac_antispoof Yan Xia
2021-10-26  6:48   ` Lin, Xueqin
2021-10-26 13:28 ` [dts] [PATCH V2 2/2] tests/vf_daemon: " Yan Xia
2021-10-26  6:48   ` Lin, Xueqin
2021-10-26  7:51     ` Tu, Lijuan

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).