test suite reviews and discussions
 help / color / mirror / Atom feed
* [PATCH v2] framework: Advise against using root passwords
@ 2021-11-17 16:26 ohilyard
  0 siblings, 0 replies; 4+ messages in thread
From: ohilyard @ 2021-11-17 16:26 UTC (permalink / raw)
  To: dts; +Cc: lijuan.tu, Owen Hilyard

From: Owen Hilyard <ohilyard@iol.unh.edu>

Added messages to notify the user that a blank password field will use
ssh keys, and that using root passwords is insecure.

Signed-off-by: Owen Hilyard <ohilyard@iol.unh.edu>
---
 conf/crbs.cfg  | 4 ++--
 tools/setup.py | 4 ++--
 2 files changed, 4 insertions(+), 4 deletions(-)

diff --git a/conf/crbs.cfg b/conf/crbs.cfg
index b6c0a9af..a12e60a4 100644
--- a/conf/crbs.cfg
+++ b/conf/crbs.cfg
@@ -2,10 +2,10 @@
 #[DUT IP]
 #  dut_ip: DUT ip address
 #  dut_user: Login DUT username
-#  dut_passwd: Login DUT password
+#  dut_passwd: [INSECURE] Login DUT password, leaving this blank will force using SSH keys
 #  os: operation system type linux or freebsd
 #  tester_ip: Tester ip address
-#  tester_passwd: Tester password
+#  tester_passwd: [INSECURE] Tester password, leaving this blank will force using SSH keys
 #  pktgen_group: packet generator group name: ixia/trex/ixia_network
 #  channels: Board channel number
 #  bypass_core0: Whether by pass core0
diff --git a/tools/setup.py b/tools/setup.py
index 3873a884..c70730c7 100755
--- a/tools/setup.py
+++ b/tools/setup.py
@@ -105,7 +105,7 @@ def config_crbs():
 
     passwd_option = {'prompt': 'DUT root password',
                      'type': 'string',
-                     'help': 'Please input password of DUT crb',
+                     'help': '[INSECURE] Please input password of DUT crb (leave blank to use preconfigured SSH keys)',
                      'default': ''}
     opt = Option(**passwd_option)
     dut_pass = opt.parse_input()
@@ -120,7 +120,7 @@ def config_crbs():
 
     passwd_option = {'prompt': 'Tester root password',
                      'type': 'string',
-                     'help': 'Please input password of Tester crb',
+                     'help': '[INSECURE] Please input password of Tester crb (leave blank to use preconfigured SSH keys)',
                      'default': ''}
     opt = Option(**passwd_option)
     tester_pass = opt.parse_input()
-- 
2.30.2


^ permalink raw reply	[flat|nested] 4+ messages in thread
* [PATCH] framework: Advise against using root passwords
@ 2021-11-17 16:23 ohilyard
  2021-11-17 17:01 ` [PATCH v2] " ohilyard
  0 siblings, 1 reply; 4+ messages in thread
From: ohilyard @ 2021-11-17 16:23 UTC (permalink / raw)
  To: dts; +Cc: lijuan.tu, Owen Hilyard

From: Owen Hilyard <ohilyard@iol.unh.edu>

Added messages to notify the user that a blank password field will use
ssh keys, and that using root passwords is insecure.
---
 conf/crbs.cfg  | 4 ++--
 tools/setup.py | 4 ++--
 2 files changed, 4 insertions(+), 4 deletions(-)

diff --git a/conf/crbs.cfg b/conf/crbs.cfg
index b6c0a9af..a12e60a4 100644
--- a/conf/crbs.cfg
+++ b/conf/crbs.cfg
@@ -2,10 +2,10 @@
 #[DUT IP]
 #  dut_ip: DUT ip address
 #  dut_user: Login DUT username
-#  dut_passwd: Login DUT password
+#  dut_passwd: [INSECURE] Login DUT password, leaving this blank will force using SSH keys
 #  os: operation system type linux or freebsd
 #  tester_ip: Tester ip address
-#  tester_passwd: Tester password
+#  tester_passwd: [INSECURE] Tester password, leaving this blank will force using SSH keys
 #  pktgen_group: packet generator group name: ixia/trex/ixia_network
 #  channels: Board channel number
 #  bypass_core0: Whether by pass core0
diff --git a/tools/setup.py b/tools/setup.py
index 3873a884..c70730c7 100755
--- a/tools/setup.py
+++ b/tools/setup.py
@@ -105,7 +105,7 @@ def config_crbs():
 
     passwd_option = {'prompt': 'DUT root password',
                      'type': 'string',
-                     'help': 'Please input password of DUT crb',
+                     'help': '[INSECURE] Please input password of DUT crb (leave blank to use preconfigured SSH keys)',
                      'default': ''}
     opt = Option(**passwd_option)
     dut_pass = opt.parse_input()
@@ -120,7 +120,7 @@ def config_crbs():
 
     passwd_option = {'prompt': 'Tester root password',
                      'type': 'string',
-                     'help': 'Please input password of Tester crb',
+                     'help': '[INSECURE] Please input password of Tester crb (leave blank to use preconfigured SSH keys)',
                      'default': ''}
     opt = Option(**passwd_option)
     tester_pass = opt.parse_input()
-- 
2.30.2


^ permalink raw reply	[flat|nested] 4+ messages in thread
end of thread, other threads:[~2021-11-23 14:28 UTC | newest]

Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-11-17 16:26 [PATCH v2] framework: Advise against using root passwords ohilyard
  -- strict thread matches above, loose matches on Subject: below --
2021-11-17 16:23 [PATCH] " ohilyard
2021-11-17 17:01 ` [PATCH v2] " ohilyard
2021-11-18 10:16   ` Juraj Linkeš
2021-11-23 14:28     ` Tu, Lijuan

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).