test suite reviews and discussions
 help / color / mirror / Atom feed
* RE: [dts][PATCH V2 4/4] tests/vxlan_gpe_support_in_i40e: delete tunnel_filter_vxlan_gpe
  2021-11-18 10:35 ` [dts][PATCH V2 4/4] tests/vxlan_gpe_support_in_i40e: " Yan Xia
@ 2021-11-18  2:40   ` Peng, Yuan
  2021-11-22 14:43   ` Tu, Lijuan
  1 sibling, 0 replies; 7+ messages in thread
From: Peng, Yuan @ 2021-11-18  2:40 UTC (permalink / raw)
  To: Xia, YanX, dts; +Cc: Xia, YanX

Acked-by Peng, Yuan <yuan.peng@intel.com>

-----Original Message-----
From: Yan Xia <yanx.xia@intel.com> 
Sent: Thursday, November 18, 2021 6:36 PM
To: dts@dpdk.org
Cc: Xia, YanX <yanx.xia@intel.com>
Subject: [dts][PATCH V2 4/4] tests/vxlan_gpe_support_in_i40e: delete tunnel_filter_vxlan_gpe

delete test case that legcay command not be supported and not new command to replace dpdk commit-id:251baec36  ethdev: remove legacy tunnel filter type support 

Signed-off-by: Yan Xia <yanx.xia@intel.com>
---
 tests/TestSuite_vxlan_gpe_support_in_i40e.py | 33 --------------------
 1 file changed, 33 deletions(-)

diff --git a/tests/TestSuite_vxlan_gpe_support_in_i40e.py b/tests/TestSuite_vxlan_gpe_support_in_i40e.py
index 555f7a0f..a2002247 100644
--- a/tests/TestSuite_vxlan_gpe_support_in_i40e.py
+++ b/tests/TestSuite_vxlan_gpe_support_in_i40e.py
@@ -254,39 +254,6 @@ class TestVxlanGpeSupportInI40e(TestCase):
         self.pmdout.execute_cmd('quit', '#')
         self.verify('L3_IPV4_EXT_UNKNOWN' in out and '%s' % VXLAN_GPE_PORT not in out, 'no detect vxlan-gpe packet')
 
-    def test_tunnel_filter_vxlan_gpe(self):
-        """
-        verify tunnel filter feature
-        """
-        pmd_temp = "./%(TARGET)s -c %(COREMASK)s -n " + \
-            "%(CHANNEL)d -- -i --disable-rss --rxq=4 --txq=4" + \
-            " --nb-cores=4 --portmask=%(PORT)s"
-        path = self.dut.apps_name['test-pmd']
-        pmd_cmd = pmd_temp % {'TARGET': path,
-                              'COREMASK': self.coremask,
-                              'CHANNEL': self.dut.get_memory_channels(),
-                              'PORT': self.portMask}
-        self.dut.send_expect(pmd_cmd, "testpmd>", 30)
-
-        self.dut.send_expect("set fwd rxonly", "testpmd>", 10)
-        self.dut.send_expect("set verbose 1", "testpmd>", 10)
-        self.enable_vxlan(self.dut_port)
-
-        # check inner mac + inner vlan filter can work
-        self.filter_and_check(filter_type="imac-ivlan", vlan=1)
-        # check inner mac + inner vlan + tunnel id filter can work
-        self.filter_and_check(filter_type="imac-ivlan-tenid", vlan=1)
-        # check inner mac + tunnel id filter can work
-        self.filter_and_check(filter_type="imac-tenid")
-        # check inner mac filter can work
-        self.filter_and_check(filter_type="imac")
-        # check outer mac + inner mac + tunnel id filter can work
-        self.filter_and_check(filter_type="omac-imac-tenid")
-        # iip not supported by now
-        self.filter_and_check(filter_type="iip")
-
-        self.dut.send_expect("quit", "#", 10)
-
     def enable_vxlan(self, port):
         self.dut.send_expect("rx_vxlan_port add %d %d"
                              % (VXLAN_GPE_PORT, port),
--
2.33.1


^ permalink raw reply	[flat|nested] 7+ messages in thread

* [dts][PATCH V2 0/4] *** delete test case ***
@ 2021-11-18 10:35 Yan Xia
  2021-11-18 10:35 ` [dts][PATCH V2 1/4] test_plans/ipgre_test_plan: delete GRE_packet_filter Yan Xia
                   ` (3 more replies)
  0 siblings, 4 replies; 7+ messages in thread
From: Yan Xia @ 2021-11-18 10:35 UTC (permalink / raw)
  To: dts; +Cc: Yan Xia

*** delete test case that legcay command not be supported and not new
command to replace
dpdk commit-id:251baec36  ethdev: remove legacy tunnel filter type support  ***

Yan Xia (4):
  test_plans/ipgre_test_plan: delete GRE_packet_filter
  tests/ipgre: delete GRE_packet_filter
  test_plans/vxlan_gpe_support_in_i40e: delete tunnel_filter_vxlan_gpe
  tests/vxlan_gpe_support_in_i40e: delete tunnel_filter_vxlan_gpe

 test_plans/ipgre_test_plan.rst                | 37 -------------
 .../vxlan_gpe_support_in_i40e_test_plan.rst   | 34 ------------
 tests/TestSuite_ipgre.py                      | 55 -------------------
 tests/TestSuite_vxlan_gpe_support_in_i40e.py  | 33 -----------
 4 files changed, 159 deletions(-)

-- 
2.33.1


^ permalink raw reply	[flat|nested] 7+ messages in thread

* [dts][PATCH V2 1/4] test_plans/ipgre_test_plan: delete GRE_packet_filter
  2021-11-18 10:35 [dts][PATCH V2 0/4] *** delete test case *** Yan Xia
@ 2021-11-18 10:35 ` Yan Xia
  2021-11-18 10:35 ` [dts][PATCH V2 2/4] tests/ipgre: " Yan Xia
                   ` (2 subsequent siblings)
  3 siblings, 0 replies; 7+ messages in thread
From: Yan Xia @ 2021-11-18 10:35 UTC (permalink / raw)
  To: dts; +Cc: Yan Xia

delete test case that legcay command not be supported and not new
command to replace
dpdk commit-id:251baec36  ethdev: remove legacy tunnel filter type support 

Signed-off-by: Yan Xia <yanx.xia@intel.com>
---
 test_plans/ipgre_test_plan.rst | 37 ----------------------------------
 1 file changed, 37 deletions(-)

diff --git a/test_plans/ipgre_test_plan.rst b/test_plans/ipgre_test_plan.rst
index c7ab602b..3a466b75 100644
--- a/test_plans/ipgre_test_plan.rst
+++ b/test_plans/ipgre_test_plan.rst
@@ -119,43 +119,6 @@ Send packet as table listed and packet type match each layer::
 | Yes        | Ipv6     | GRE       | Ipv6     | Sctp      |
 +------------+----------+-----------+----------+-----------+
 
-Test Case 3: GRE packet filter
-==============================
-
-Start testpmd with multi queues::
-
-    testpmd -c ff -n 3 -- -i  --rxq=4 --txq=4
-    testpmd> set fwd rxonly
-    testpmd> set nbcore 4
-    testpmd> set verbose 1
-    testpmd> start
-
-Add GRE filter that forward inner ip address 0.0.0.0 to queue 3::
-
-    testpmd> tunnel_filter add 0 XX:XX:XX:XX:XX:XX YY:YY:YY:YY:YY:YY \
-             0.0.0.0 1 ipingre iip 0 3
-
-Send packet inner ip address matched and check packet received by queue 3::
-
-    p = Ether()/IP()/GRE()/IP(dst="0.0.0.0")/UDP()
-
-Remove tunnel filter and check same packet received by queue 0::
-
-    testpmd> tunnel_filter rm 0 XX:XX:XX:XX:XX:XX YY:YY:YY:YY:YY:YY \
-             0.0.0.0 1 ipingre iip 0 3
-
-Add GRE filter that forward outer ip address 0.0.0.0 to queue 3::
-
-    testpmd> tunnel_filter add 0 XX:XX:XX:XX:XX:XX YY:YY:YY:YY:YY:YY \
-             0.0.0.0 1 ipingre oip 0 3
-
-Send packet outer ip address matched and check packet received by queue 3.
-
-Remove tunnel filter and check same packet received by queue 0::
-
-    testpmd> tunnel_filter rm 0 XX:XX:XX:XX:XX:XX YY:YY:YY:YY:YY:YY \
-             0.0.0.0 1 ipingre oip 0 3
-
 Test Case 4: GRE packet chksum offload
 ======================================
 
-- 
2.33.1


^ permalink raw reply	[flat|nested] 7+ messages in thread

* [dts][PATCH V2 2/4] tests/ipgre: delete GRE_packet_filter
  2021-11-18 10:35 [dts][PATCH V2 0/4] *** delete test case *** Yan Xia
  2021-11-18 10:35 ` [dts][PATCH V2 1/4] test_plans/ipgre_test_plan: delete GRE_packet_filter Yan Xia
@ 2021-11-18 10:35 ` Yan Xia
  2021-11-18 10:35 ` [dts][PATCH V2 3/4] test_plans/vxlan_gpe_support_in_i40e: delete tunnel_filter_vxlan_gpe Yan Xia
  2021-11-18 10:35 ` [dts][PATCH V2 4/4] tests/vxlan_gpe_support_in_i40e: " Yan Xia
  3 siblings, 0 replies; 7+ messages in thread
From: Yan Xia @ 2021-11-18 10:35 UTC (permalink / raw)
  To: dts; +Cc: Yan Xia

delete test case that legcay command not be supported and not new
command to replace
dpdk commit-id:251baec36  ethdev: remove legacy tunnel filter type support 

Signed-off-by: Yan Xia <yanx.xia@intel.com>
---
 tests/TestSuite_ipgre.py | 55 ----------------------------------------
 1 file changed, 55 deletions(-)

diff --git a/tests/TestSuite_ipgre.py b/tests/TestSuite_ipgre.py
index 2a15e07a..da5b7025 100644
--- a/tests/TestSuite_ipgre.py
+++ b/tests/TestSuite_ipgre.py
@@ -300,61 +300,6 @@ class TestIpgre(TestCase):
         self.check_packet_transmission(pkt_types_ipv6_ipv6_SCTP, config_layers)
         self.dut.send_expect("quit", "#")
 
-    def test_GRE_packet_filter(self):
-        """
-        Start testpmd with multi queues, add GRE filter that forward
-        inner/outer ip address 0.0.0.0 to queue 3, Send packet inner
-        ip address matched and check packet received by queue 3
-        """
-        outer_mac = self.tester_iface_mac
-        inner_mac = "10:00:00:00:00:00"
-
-        # Start testpmd with multi queues
-        #testpmd_cmd = "./%s/app/testpmd -c ff -n 3 -- -i  --rxq=4 --txq=4" % self.target
-        self.pmdout.start_testpmd("Default", "--portmask=%s " %
-                                  (self.portMask) + " --enable-rx-cksum --rxq=4 --txq=4 "
-                                  , socket=self.ports_socket)
-        self.dut.send_expect("set fwd rxonly", "testpmd>")
-        self.dut.send_expect("set nbcore 4", "testpmd>")
-        self.dut.send_expect("set verbose 1", "testpmd>")
-        self.dut.send_expect("start", "testpmd>")
-
-        # Add GRE filter that forward inner ip address 0.0.0.0 to queue 3
-        cmd = "tunnel_filter add 0 %s %s 0.0.0.0 1 ipingre iip 0 3"%(outer_mac, inner_mac)
-        self.dut.send_expect( cmd, "testpmd>")
-
-        # Send packet inner ip address matched and check packet received by queue 3
-        pkt_types = {"MAC_IP_GRE_IPv4-TUNNEL_UDP_PKT":  ["TUNNEL_GRENAT",  "INNER_L4_UDP"]}
-        config_layers = {'ether': {'src': self.outer_mac_src},
-                         'ipv4': {'proto': 'gre',
-                                  'src': self.outer_ip_src,
-                                  'dst': self.outer_ip_dst},
-                         'inner_ipv4':{'dst': "0.0.0.0"}}
-        self.check_packet_transmission(pkt_types, config_layers, "3", 1)
-
-        # Remove tunnel filter and check same packet received by queue 0
-        cmd = "tunnel_filter rm 0 %s %s 0.0.0.0 1 ipingre iip 0 3"%(outer_mac, inner_mac)
-        self.dut.send_expect( cmd, "testpmd>")
-        self.check_packet_transmission(pkt_types, config_layers, "3")
-
-        # Add GRE filter that forward outer ip address 0.0.0.0 to queue 3
-        cmd = "tunnel_filter add 0 %s %s 0.0.0.0 1 ipingre oip 0 3"%(outer_mac, inner_mac)
-        self.dut.send_expect( cmd, "testpmd>")
-
-        # Send packet outer ip address matched and check packet received by queue 3.
-        pkt_types = {"MAC_IP_GRE_IPv4-TUNNEL_UDP_PKT": ["TUNNEL_GRENAT", "INNER_L4_UDP"]}
-        config_layers = {'ether': {'src': self.outer_mac_src},
-                         'ipv4': {'dst': "0.0.0.0", 'proto': 'gre'}}
-        self.check_packet_transmission(pkt_types, config_layers, "3", 1)
-
-        # Add GRE filter that forward outer ip address 0.0.0.0 to queue 3
-        cmd = "tunnel_filter rm 0 %s %s 0.0.0.0 1 ipingre oip 0 3"%(outer_mac, inner_mac)
-        self.dut.send_expect( cmd, "testpmd>")
-        self.check_packet_transmission(pkt_types, config_layers, "3")
-
-        time.sleep(2)
-        self.dut.send_expect("quit", "#")
-
     def test_GRE_packet_chksum_offload(self):
         """
         Start testpmd with hardware checksum offload enabled,
-- 
2.33.1


^ permalink raw reply	[flat|nested] 7+ messages in thread

* [dts][PATCH V2 3/4] test_plans/vxlan_gpe_support_in_i40e: delete tunnel_filter_vxlan_gpe
  2021-11-18 10:35 [dts][PATCH V2 0/4] *** delete test case *** Yan Xia
  2021-11-18 10:35 ` [dts][PATCH V2 1/4] test_plans/ipgre_test_plan: delete GRE_packet_filter Yan Xia
  2021-11-18 10:35 ` [dts][PATCH V2 2/4] tests/ipgre: " Yan Xia
@ 2021-11-18 10:35 ` Yan Xia
  2021-11-18 10:35 ` [dts][PATCH V2 4/4] tests/vxlan_gpe_support_in_i40e: " Yan Xia
  3 siblings, 0 replies; 7+ messages in thread
From: Yan Xia @ 2021-11-18 10:35 UTC (permalink / raw)
  To: dts; +Cc: Yan Xia

delete test case that legcay command not be supported and not new
command to replace
dpdk commit-id:251baec36  ethdev: remove legacy tunnel filter type support 

Signed-off-by: Yan Xia <yanx.xia@intel.com>
---
 .../vxlan_gpe_support_in_i40e_test_plan.rst   | 34 -------------------
 1 file changed, 34 deletions(-)

diff --git a/test_plans/vxlan_gpe_support_in_i40e_test_plan.rst b/test_plans/vxlan_gpe_support_in_i40e_test_plan.rst
index 905bd886..e2f809b9 100644
--- a/test_plans/vxlan_gpe_support_in_i40e_test_plan.rst
+++ b/test_plans/vxlan_gpe_support_in_i40e_test_plan.rst
@@ -84,37 +84,3 @@ Test Case 2: VXLAN-GPE tunnel remove test
 3. Expected result::
 
     testpmd should treat the packet as a normal UDP packet
-
-Test Case 3: Tunnel filter VXLAN-GPE support
-============================================
-1. Start testpmd with tunneling packet type to vxlan and disable receive side
-   scale for hardware limitation::
-
-    # testpmd -c ffff -n 4 -- -i --disable-rss --rxq=4 --txq=4 --nb-cores=8 --nb-ports=2 --tx-offloads=0x8fff
-
-2. Set rxonly packet forwarding mode and enable verbose log::
-
-    testpmd> set fwd rxonly
-    testpmd> set verbose 1
-
-3. Add one new Cloud filter as table listed first::
-
-    testpmd> tunnel_filter add 0 11:22:33:44:55:66 00:00:20:00:00:01 192.168.2.2 1 vxlan-gpe imac-ivlan 1 3
-
-4. Then send one packet and check packet was forwarded into right queue.
-
-+------------+------------+------------+----------+----------+--------+-------+
-| Outer Mac  | Inner Mac  | Inner Vlan | Outer Ip | Inner Ip | Vni ID | Queue |
-+------------+------------+------------+----------+----------+--------+-------+
-| No         | Yes        | Yes        | No       | No       | No     | 1     |
-+------------+------------+------------+----------+----------+--------+-------+
-| No         | Yes        | Yes        | No       | No       | Yes    | 1     |
-+------------+------------+------------+----------+----------+--------+-------+
-| No         | Yes        | No         | No       | No       | Yes    | 1     |
-+------------+------------+------------+----------+----------+--------+-------+
-| No         | Yes        | No         | No       | No       | No     | 1     |
-+------------+------------+------------+----------+----------+--------+-------+
-| Yes        | Yes        | No         | No       | Yes      | Yes    | 1     |
-+------------+------------+------------+----------+----------+--------+-------+
-| No         | No         | No         | No       | Yes      | No     | 1     |
-+------------+------------+------------+----------+----------+--------+-------+
-- 
2.33.1


^ permalink raw reply	[flat|nested] 7+ messages in thread

* [dts][PATCH V2 4/4] tests/vxlan_gpe_support_in_i40e: delete tunnel_filter_vxlan_gpe
  2021-11-18 10:35 [dts][PATCH V2 0/4] *** delete test case *** Yan Xia
                   ` (2 preceding siblings ...)
  2021-11-18 10:35 ` [dts][PATCH V2 3/4] test_plans/vxlan_gpe_support_in_i40e: delete tunnel_filter_vxlan_gpe Yan Xia
@ 2021-11-18 10:35 ` Yan Xia
  2021-11-18  2:40   ` Peng, Yuan
  2021-11-22 14:43   ` Tu, Lijuan
  3 siblings, 2 replies; 7+ messages in thread
From: Yan Xia @ 2021-11-18 10:35 UTC (permalink / raw)
  To: dts; +Cc: Yan Xia

delete test case that legcay command not be supported and not new
command to replace
dpdk commit-id:251baec36  ethdev: remove legacy tunnel filter type support 

Signed-off-by: Yan Xia <yanx.xia@intel.com>
---
 tests/TestSuite_vxlan_gpe_support_in_i40e.py | 33 --------------------
 1 file changed, 33 deletions(-)

diff --git a/tests/TestSuite_vxlan_gpe_support_in_i40e.py b/tests/TestSuite_vxlan_gpe_support_in_i40e.py
index 555f7a0f..a2002247 100644
--- a/tests/TestSuite_vxlan_gpe_support_in_i40e.py
+++ b/tests/TestSuite_vxlan_gpe_support_in_i40e.py
@@ -254,39 +254,6 @@ class TestVxlanGpeSupportInI40e(TestCase):
         self.pmdout.execute_cmd('quit', '#')
         self.verify('L3_IPV4_EXT_UNKNOWN' in out and '%s' % VXLAN_GPE_PORT not in out, 'no detect vxlan-gpe packet')
 
-    def test_tunnel_filter_vxlan_gpe(self):
-        """
-        verify tunnel filter feature
-        """
-        pmd_temp = "./%(TARGET)s -c %(COREMASK)s -n " + \
-            "%(CHANNEL)d -- -i --disable-rss --rxq=4 --txq=4" + \
-            " --nb-cores=4 --portmask=%(PORT)s"
-        path = self.dut.apps_name['test-pmd']
-        pmd_cmd = pmd_temp % {'TARGET': path,
-                              'COREMASK': self.coremask,
-                              'CHANNEL': self.dut.get_memory_channels(),
-                              'PORT': self.portMask}
-        self.dut.send_expect(pmd_cmd, "testpmd>", 30)
-
-        self.dut.send_expect("set fwd rxonly", "testpmd>", 10)
-        self.dut.send_expect("set verbose 1", "testpmd>", 10)
-        self.enable_vxlan(self.dut_port)
-
-        # check inner mac + inner vlan filter can work
-        self.filter_and_check(filter_type="imac-ivlan", vlan=1)
-        # check inner mac + inner vlan + tunnel id filter can work
-        self.filter_and_check(filter_type="imac-ivlan-tenid", vlan=1)
-        # check inner mac + tunnel id filter can work
-        self.filter_and_check(filter_type="imac-tenid")
-        # check inner mac filter can work
-        self.filter_and_check(filter_type="imac")
-        # check outer mac + inner mac + tunnel id filter can work
-        self.filter_and_check(filter_type="omac-imac-tenid")
-        # iip not supported by now
-        self.filter_and_check(filter_type="iip")
-
-        self.dut.send_expect("quit", "#", 10)
-
     def enable_vxlan(self, port):
         self.dut.send_expect("rx_vxlan_port add %d %d"
                              % (VXLAN_GPE_PORT, port),
-- 
2.33.1


^ permalink raw reply	[flat|nested] 7+ messages in thread

* RE: [dts][PATCH V2 4/4] tests/vxlan_gpe_support_in_i40e: delete tunnel_filter_vxlan_gpe
  2021-11-18 10:35 ` [dts][PATCH V2 4/4] tests/vxlan_gpe_support_in_i40e: " Yan Xia
  2021-11-18  2:40   ` Peng, Yuan
@ 2021-11-22 14:43   ` Tu, Lijuan
  1 sibling, 0 replies; 7+ messages in thread
From: Tu, Lijuan @ 2021-11-22 14:43 UTC (permalink / raw)
  To: Xia, YanX, dts; +Cc: Xia, YanX

> -----Original Message-----
> From: Yan Xia <yanx.xia@intel.com>
> Sent: 2021年11月18日 18:36
> To: dts@dpdk.org
> Cc: Xia, YanX <yanx.xia@intel.com>
> Subject: [dts][PATCH V2 4/4] tests/vxlan_gpe_support_in_i40e: delete
> tunnel_filter_vxlan_gpe
> 
> delete test case that legcay command not be supported and not new command
> to replace dpdk commit-id:251baec36  ethdev: remove legacy tunnel filter type
> support
> 
> Signed-off-by: Yan Xia <yanx.xia@intel.com>

Acked-by Peng, Yuan <yuan.peng@intel.com>

Series applied

^ permalink raw reply	[flat|nested] 7+ messages in thread

end of thread, other threads:[~2021-11-22 14:44 UTC | newest]

Thread overview: 7+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-11-18 10:35 [dts][PATCH V2 0/4] *** delete test case *** Yan Xia
2021-11-18 10:35 ` [dts][PATCH V2 1/4] test_plans/ipgre_test_plan: delete GRE_packet_filter Yan Xia
2021-11-18 10:35 ` [dts][PATCH V2 2/4] tests/ipgre: " Yan Xia
2021-11-18 10:35 ` [dts][PATCH V2 3/4] test_plans/vxlan_gpe_support_in_i40e: delete tunnel_filter_vxlan_gpe Yan Xia
2021-11-18 10:35 ` [dts][PATCH V2 4/4] tests/vxlan_gpe_support_in_i40e: " Yan Xia
2021-11-18  2:40   ` Peng, Yuan
2021-11-22 14:43   ` Tu, Lijuan

test suite reviews and discussions

This inbox may be cloned and mirrored by anyone:

	git clone --mirror http://inbox.dpdk.org/dts/0 dts/git/0.git

	# If you have public-inbox 1.1+ installed, you may
	# initialize and index your mirror using the following commands:
	public-inbox-init -V2 dts dts/ http://inbox.dpdk.org/dts \
		dts@dpdk.org
	public-inbox-index dts

Example config snippet for mirrors.
Newsgroup available over NNTP:
	nntp://inbox.dpdk.org/inbox.dpdk.dts


AGPL code for this site: git clone https://public-inbox.org/public-inbox.git