test suite reviews and discussions
 help / color / mirror / Atom feed
* [dts][PATCH V1] tests/mtu_update:igc can receive packets 8 larger than MTU
@ 2021-11-24 17:23 Lewei Yang
  2021-11-30  2:53 ` Tu, Lijuan
  2021-12-01  6:03 ` Tu, Lijuan
  0 siblings, 2 replies; 3+ messages in thread
From: Lewei Yang @ 2021-11-24 17:23 UTC (permalink / raw)
  To: dts; +Cc: Lewei Yang

According to dpdk commit 1bb4a528c41f("ethdev: fix max Rx packet length"),
there is a miss accuracy in the MTU configuration in DPDK, packets bigger (up to 8 bytes) than requested MTU can be received.

Signed-off-by: Lewei Yang <leweix.yang@intel.com>
---
 tests/TestSuite_mtu_update.py | 6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)

diff --git a/tests/TestSuite_mtu_update.py b/tests/TestSuite_mtu_update.py
index ad13a8ab..be114759 100644
--- a/tests/TestSuite_mtu_update.py
+++ b/tests/TestSuite_mtu_update.py
@@ -239,9 +239,9 @@ class TestMtuUpdate(TestCase):
         On 1G NICs, when the jubmo frame MTU set > 1500, the software adjust it to MTU+4.
         """
         if self.nic in ["powerville", "springville", "foxville"] and packet_size > 1500:
-            self.send_packet_of_size_to_tx_port(packet_size + 4 - 1, received=True)
-            self.send_packet_of_size_to_tx_port(packet_size + 4, received=True)
-            self.send_packet_of_size_to_tx_port(packet_size + 4 + 1, received=False)
+            self.send_packet_of_size_to_tx_port(packet_size + 8 - 1, received=True)
+            self.send_packet_of_size_to_tx_port(packet_size + 8, received=True)
+            self.send_packet_of_size_to_tx_port(packet_size + 8 + 1, received=False)
         else:
             self.send_packet_of_size_to_tx_port(packet_size - 1, received=True)
             self.send_packet_of_size_to_tx_port(packet_size, received=True)
-- 
2.33.1


^ permalink raw reply	[flat|nested] 3+ messages in thread

* RE: [dts][PATCH V1] tests/mtu_update:igc can receive packets 8 larger than MTU
  2021-11-24 17:23 [dts][PATCH V1] tests/mtu_update:igc can receive packets 8 larger than MTU Lewei Yang
@ 2021-11-30  2:53 ` Tu, Lijuan
  2021-12-01  6:03 ` Tu, Lijuan
  1 sibling, 0 replies; 3+ messages in thread
From: Tu, Lijuan @ 2021-11-30  2:53 UTC (permalink / raw)
  To: Yang, LeweiX, dts; +Cc: Yang, LeweiX

> -----Original Message-----
> From: Lewei Yang <leweix.yang@intel.com>
> Sent: 2021年11月25日 1:24
> To: dts@dpdk.org
> Cc: Yang, LeweiX <leweix.yang@intel.com>
> Subject: [dts][PATCH V1] tests/mtu_update:igc can receive packets 8 larger than
> MTU
> 
> According to dpdk commit 1bb4a528c41f("ethdev: fix max Rx packet length"),
> there is a miss accuracy in the MTU configuration in DPDK, packets bigger (up to
> 8 bytes) than requested MTU can be received.
> 
> Signed-off-by: Lewei Yang <leweix.yang@intel.com>

Could you please go through all MTU and jumbo frame related cases?

^ permalink raw reply	[flat|nested] 3+ messages in thread

* RE: [dts][PATCH V1] tests/mtu_update:igc can receive packets 8 larger than MTU
  2021-11-24 17:23 [dts][PATCH V1] tests/mtu_update:igc can receive packets 8 larger than MTU Lewei Yang
  2021-11-30  2:53 ` Tu, Lijuan
@ 2021-12-01  6:03 ` Tu, Lijuan
  1 sibling, 0 replies; 3+ messages in thread
From: Tu, Lijuan @ 2021-12-01  6:03 UTC (permalink / raw)
  To: Yang, LeweiX, dts; +Cc: Yang, LeweiX

> -----Original Message-----
> From: Lewei Yang <leweix.yang@intel.com>
> Sent: 2021年11月25日 1:24
> To: dts@dpdk.org
> Cc: Yang, LeweiX <leweix.yang@intel.com>
> Subject: [dts][PATCH V1] tests/mtu_update:igc can receive packets 8 larger than
> MTU
> 
> According to dpdk commit 1bb4a528c41f("ethdev: fix max Rx packet length"),
> there is a miss accuracy in the MTU configuration in DPDK, packets bigger (up to
> 8 bytes) than requested MTU can be received.
> 
> Signed-off-by: Lewei Yang <leweix.yang@intel.com>

Applied, thanks

^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, other threads:[~2021-12-01  6:03 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-11-24 17:23 [dts][PATCH V1] tests/mtu_update:igc can receive packets 8 larger than MTU Lewei Yang
2021-11-30  2:53 ` Tu, Lijuan
2021-12-01  6:03 ` Tu, Lijuan

test suite reviews and discussions

This inbox may be cloned and mirrored by anyone:

	git clone --mirror http://inbox.dpdk.org/dts/0 dts/git/0.git

	# If you have public-inbox 1.1+ installed, you may
	# initialize and index your mirror using the following commands:
	public-inbox-init -V2 dts dts/ http://inbox.dpdk.org/dts \
		dts@dpdk.org
	public-inbox-index dts

Example config snippet for mirrors.
Newsgroup available over NNTP:
	nntp://inbox.dpdk.org/inbox.dpdk.dts


AGPL code for this site: git clone https://public-inbox.org/public-inbox.git