From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 840BDA034D; Thu, 10 Feb 2022 09:33:07 +0100 (CET) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 7251B41176; Thu, 10 Feb 2022 09:33:07 +0100 (CET) Received: from mga06.intel.com (mga06.intel.com [134.134.136.31]) by mails.dpdk.org (Postfix) with ESMTP id 7CB1240041 for ; Thu, 10 Feb 2022 09:33:05 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1644481985; x=1676017985; h=from:to:cc:subject:date:message-id:in-reply-to: references:mime-version:content-transfer-encoding; bh=jDCqSjNixJMZQyOYJX/o7NLmuKv1qV4RGhA30cmFfeM=; b=RJi8n616sY8fWPgoy56J/Kj8RgTrrh5CIoRpXPbKx0cQMrMBU9daHCWO ilFz85aXuqsPe1jiOcxNZOHU6iJaw4S8c3rSDoJ8Kv9sBN/XkL9XCCPt6 tFGsFJIAn+DBoaxCk8J4ypyIi44SRr8fhdQwA/jEhby1kmBMwiwdHfPmN fVlarRd5ZSeRkGSNt3xs7YLUKM3UmntUPqTRpVzOfmBtNSVZ3Y8tZXZTJ n+xUQmeBJTvN43JfEQ05kenhtvg8DuQZnkaaKpjzOtD1obLCdn44XhtCq LWJ3xPuVeszdVcjKXtoJyMSEFTkHXs/Z0YZba523QEnaaMJ1UUoLX+NcD A==; X-IronPort-AV: E=McAfee;i="6200,9189,10253"; a="310180670" X-IronPort-AV: E=Sophos;i="5.88,358,1635231600"; d="scan'208";a="310180670" Received: from orsmga008.jf.intel.com ([10.7.209.65]) by orsmga104.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 10 Feb 2022 00:33:05 -0800 X-IronPort-AV: E=Sophos;i="5.88,358,1635231600"; d="scan'208";a="541515201" Received: from unknown (HELO localhost.localdomain) ([10.239.251.226]) by orsmga008-auth.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 10 Feb 2022 00:33:03 -0800 From: Yu Jiang To: lijuan.tu@intel.com, dts@dpdk.org Cc: Yu Jiang Subject: [dts][PATCH V1 1/2] tests/kni: wait for interface up Date: Thu, 10 Feb 2022 16:32:25 +0000 Message-Id: <20220210163226.2442488-2-yux.jiang@intel.com> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20220210163226.2442488-1-yux.jiang@intel.com> References: <20220210163226.2442488-1-yux.jiang@intel.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-BeenThere: dts@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: test suite reviews and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dts-bounces@dpdk.org use new method: is_interface_up/down to to ensure iface's link status. Signed-off-by: Yu Jiang --- tests/TestSuite_kni.py | 14 +++++++++----- 1 file changed, 9 insertions(+), 5 deletions(-) diff --git a/tests/TestSuite_kni.py b/tests/TestSuite_kni.py index c2b05bad..c2036625 100644 --- a/tests/TestSuite_kni.py +++ b/tests/TestSuite_kni.py @@ -687,7 +687,8 @@ class TestKni(TestCase): tx_interface = self.tester.get_interface(tx_port) self.dut.send_expect("ifconfig %s up" % virtual_interface, "# ") - time.sleep(5) + # ensure virtual_interface link up + self.verify(self.dut.is_interface_up(intf=virtual_interface), "Wrong link status, should be up") # Start tcpdump with filters for src and dst MAC address, this avoids # unwanted broadcast, ICPM6... packets out = self.dut.send_expect( @@ -733,7 +734,8 @@ class TestKni(TestCase): out = self.dut.send_expect( "ifconfig %s up" % virtual_interface, "# ") - time.sleep(5) + # ensure virtual_interface up + self.verify(self.dut.is_interface_up(intf=virtual_interface), "virtual_interface should be up") out = self.dut.send_expect("ifconfig %s" % virtual_interface, "# ") m = re.search(rx_match, out) previous_rx_packets = int(m.group(1)) @@ -751,6 +753,8 @@ class TestKni(TestCase): pkt = packet.Packet() pkt.update_pkt(scapy_str) + # ensure tester's interface up + self.verify(self.tester.is_interface_up(intf=tx_interface), "Tester's interface should be up") pkt.send_pkt(self.tester, tx_port=tx_interface, count=200) out = self.dut.send_expect("ifconfig %s" % virtual_interface, "# ") @@ -909,7 +913,6 @@ class TestKni(TestCase): self.verify("ERROR" not in out, "Device not found") self.dut.send_expect("ifconfig br_kni up", "# ") - time.sleep(3) tx_port = self.tester.get_local_port(self.config['ports'][0]) rx_port = self.tester.get_local_port(self.config['ports'][1]) @@ -919,7 +922,7 @@ class TestKni(TestCase): if step['flows'] == 2: tgenInput.append((rx_port, tx_port, pcap)) - time.sleep(1) + self.verify(self.dut.is_interface_up(intf="br_kni"), "br_kni should be up") # clear streams before add new streams self.tester.pktgen.clear_streams() @@ -975,7 +978,7 @@ class TestKni(TestCase): self.dut.send_expect("brctl addif br1 %s" % port_virtual_interaces[1], "# ") self.dut.send_expect("ifconfig br1 up", "# ") - time.sleep(3) + self.verify(self.dut.is_interface_up(intf='br1'), "Wrong link status, should be up") tx_port = self.tester.get_local_port(dut_ports[0]) rx_port = self.tester.get_local_port(dut_ports[1]) @@ -997,6 +1000,7 @@ class TestKni(TestCase): self.result_table_add([flows, float(pps) / 10 ** 6]) self.dut.send_expect("ifconfig br1 down", "# ") + self.verify(self.dut.is_interface_down(intf='br1'), "Wrong link status, should be down") self.dut.send_expect("brctl delbr \"br1\"", "# ", 30) for port in allow_list: -- 2.25.1