From: Yu Jiang <yux.jiang@intel.com>
To: lijuan.tu@intel.com, dts@dpdk.org
Cc: Yu Jiang <yux.jiang@intel.com>
Subject: [dts][PATCH V1 1/2] flow_classify*: wait for interface up
Date: Thu, 24 Feb 2022 14:23:48 +0000 [thread overview]
Message-ID: <20220224142349.1508842-2-yux.jiang@intel.com> (raw)
In-Reply-To: <20220224142349.1508842-1-yux.jiang@intel.com>
optimize script: flow_classify/flow_classify_softnic,
1, use new method: is_interface_up to to ensure iface's link status before send_packets
2, wait_link_status_up for all ports after start testpmd
Signed-off-by: Yu Jiang <yux.jiang@intel.com>
---
tests/TestSuite_flow_classify.py | 1 +
tests/TestSuite_flow_classify_softnic.py | 9 ++++++---
2 files changed, 7 insertions(+), 3 deletions(-)
diff --git a/tests/TestSuite_flow_classify.py b/tests/TestSuite_flow_classify.py
index 200d39e0..5b28b884 100644
--- a/tests/TestSuite_flow_classify.py
+++ b/tests/TestSuite_flow_classify.py
@@ -253,6 +253,7 @@ class TestFlowClassify(TestCase):
tx_iface = config.get('tx_intf')
cmd = "ifconfig {0} up".format(tx_iface)
self.tester.send_expect(cmd, '# ', 30)
+ self.verify(self.tester.is_interface_up(intf=tx_iface), "Wrong link status, should be up")
pkts = config.get('stream')
# stream config
stream_configs = config.get('stream configs')
diff --git a/tests/TestSuite_flow_classify_softnic.py b/tests/TestSuite_flow_classify_softnic.py
index 7b6642d0..c5004f16 100644
--- a/tests/TestSuite_flow_classify_softnic.py
+++ b/tests/TestSuite_flow_classify_softnic.py
@@ -179,12 +179,15 @@ class TestFlowClassifySoftnic(TestCase):
Sent pkts that read from the pcap_file.
Return the sniff pkts.
"""
- self.pmdout.wait_link_status_up(self.dut_ports[0])
+ self.pmdout.wait_link_status_up('all')
tx_port = self.tester.get_local_port(self.dut_ports[from_port%self.port_num])
rx_port = self.tester.get_local_port(self.dut_ports[to_port%self.port_num])
tx_interface = self.tester.get_interface(tx_port)
rx_interface = self.tester.get_interface(rx_port)
+ # check tester's link status before send packet
+ for iface in [tx_interface, rx_interface]:
+ self.verify(self.tester.is_interface_up(intf=iface), "Wrong link status, should be up")
self.tcpdump_start_sniff(rx_interface, filters)
@@ -284,9 +287,9 @@ class TestFlowClassifySoftnic(TestCase):
"""
Sends continuous packets.
"""
- self.pmdout.wait_link_status_up(self.dut_ports[0])
+ self.pmdout.wait_link_status_up('all')
+ self.verify(self.tester.is_interface_up(intf=itf), "Wrong link status, should be up")
self.tester.scapy_foreground()
- time.sleep(2)
if src_dst == "src":
if ptype == "ipv4":
var = src_addr.split(".")
--
2.25.1
next prev parent reply other threads:[~2022-02-24 6:24 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-02-24 14:23 [dts][PATCH V1 0/2] " Yu Jiang
2022-02-24 14:23 ` Yu Jiang [this message]
2022-02-24 14:23 ` [dts][PATCH V1 2/2] tests/interrupt_pmd: " Yu Jiang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220224142349.1508842-2-yux.jiang@intel.com \
--to=yux.jiang@intel.com \
--cc=dts@dpdk.org \
--cc=lijuan.tu@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).